From a0206833a999972f4ea0adff795fb6852384fd78 Mon Sep 17 00:00:00 2001
From: Russell Ballestrini <russell@unturf.com>
Date: Fri, 19 Dec 2025 21:17:43 -0500
Subject: [PATCH] Remove deprecated stripe_id from User model

- Remove User.stripe_id column (no longer used with Stripe Checkout)
- Show billing link to all authenticated users in phone menu
- Remove old Stripe customer cleanup from tests
---
 remarkbox/models/user.py                   | 3 ---
 remarkbox/templates/snippets/phone-menu.j2 | 4 +---
 remarkbox/tests/test_views.py              | 6 ------
 3 files changed, 1 insertion(+), 12 deletions(-)

diff --git a/remarkbox/models/user.py b/remarkbox/models/user.py
index a1fa808..48e46ba 100644
--- a/remarkbox/models/user.py
+++ b/remarkbox/models/user.py
@@ -120,9 +120,6 @@ class User(RBase, Base):
         default='auto',
         nullable=False,
     )
-    # example: cus_12345678AbCdEF but may be null.
-    stripe_id = Column(Unicode(18), unique=True, nullable=True)
-
     votes = relationship(argument="Vote", backref="user", order_by="desc(Vote.created)")
 
     # lazy='dynamic' returns a query object instead of collection.
diff --git a/remarkbox/templates/snippets/phone-menu.j2 b/remarkbox/templates/snippets/phone-menu.j2
index daa302b..096d4e4 100644
--- a/remarkbox/templates/snippets/phone-menu.j2
+++ b/remarkbox/templates/snippets/phone-menu.j2
@@ -14,9 +14,7 @@
      {%- if request.user.authenticated %}
        <span class="avoidwrap"><li>{{ snippets.user_link(request.user) }} <a href="/log-out">[log out]</a></li></span>
        <li><a href="{{ request.link_prefix }}/u/settings">account settings</a></li>
-       {% if request.user.stripe_id %}
-       <li><a href="{{ request.link_prefix }}/billing">payment preferences</a></li>
-       {% endif %}
+       <li><a href="{{ request.link_prefix }}/billing">billing</a></li>
      {% else %}
      <li><a href="{{ request.app_url }}/join-or-log-in?return-to={{ request.path_url }}">join-or-log-in</a></li>
      {% endif %}
diff --git a/remarkbox/tests/test_views.py b/remarkbox/tests/test_views.py
index 79926f4..b5dee4f 100644
--- a/remarkbox/tests/test_views.py
+++ b/remarkbox/tests/test_views.py
@@ -1,7 +1,6 @@
 import transaction
 import unittest
 import webtest
-import stripe
 
 from remarkbox.models import (
     Node,
@@ -158,8 +157,6 @@ class AuthenticatedFunctionalTests(FunctionalTests):
             # Python 3.
             FunctionalTests.setUpClass.__func__(cls)
 
-        stripe.api_key = cls.settings["app.stripe.secret"]
-
     def setUp(self):
         # create test_user1
         self.test_user1 = get_or_create_user_by_email(
@@ -195,9 +192,6 @@ class AuthenticatedFunctionalTests(FunctionalTests):
         self.test_creds2 = ("test2@remarkbox.com", self.raw_otp2)
 
     def _clean_up_test_user(self, user):
-        if user.stripe_id:
-            # delete remote test Customer object on Stripe's test API.
-            stripe.Customer.retrieve(user.stripe_id).delete()
         self.dbsession.delete(user)
 
     def tearDown(self):