From 6b876d488c43cdd9f890a449e1a936daaec232b9 Mon Sep 17 00:00:00 2001
From: Russell Ballestrini <russell.ballestrini@gmail.com>
Date: Sun, 10 Aug 2025 21:06:10 -0400
Subject: [PATCH] Fix hardcoded paths in test files and improve YAML error
 handling

- Replace hardcoded absolute paths with relative paths using Path(__file__).parent
- Update test_activity_flows.py, test_guarded_ai.py, and test_battleship_pre_script.py to use dynamic path construction
- Import yaml module and catch yaml.YAMLError instead of broad Exception in test_activity_processing.py
- Ensures tests work across different environments and CI systems
- Makes YAML error handling more specific and prevents masking other exceptions
---
 .coverage                                      | Bin 53248 -> 0 bytes
 .gitignore                                     |   2 ++
 tests/functional/test_activity_flows.py        |  12 ++++++------
 tests/functional/test_battleship_pre_script.py |  12 ++++++------
 tests/functional/test_guarded_ai.py            |  12 ++++++------
 tests/integration/test_activity_processing.py  |   3 ++-
 6 files changed, 22 insertions(+), 19 deletions(-)
 delete mode 100644 .coverage

diff --git a/.coverage b/.coverage
deleted file mode 100644
index 371394de41d98b0b9984c2f8c9838a1f4f6b192e..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 53248
zcmeI53vd)g8i0FtCcD|^1R(}0NX7#Rk35LTBSa-|B7%{qL@+>HCfV7|>h8|6GfNU4
zApt$=tU5WlLU|}q=Xr2SAqOW2$3cA5U7<kE<0VRtlvqF=?>8KQ+}|_1c}Z5Fic-9P
zD%;)D)BX4VfBkp&_U_JP>@#^@RTA8C$S<lwf095LhU5wYA;b(XJG`QY2@+iN1Y)K|
zy1k^CWK>SD^W%uk_#48%V9)2%ZEx9oTEDdU&97RQnnZI6T)+bfAOR$R1pdDXR6k=g
zC3We-%$})=#Xd<5i6v4<5ADBvcEqrP5kkSR;dvtjJx}Om5#UHq7lsKTxl9O3A;InS
zNrE@v@|K9IH{cP}QYl(GtVk}p&_Nz7b+llHR-dMvUKi9-B@c)QhP-|;R3W@1RitSJ
zBCV-XxvFP?5XtKa&=NwgNcG-ANODUdDNrIQx)!~>uHKg3b7omgNgX>fb0y6tF;oJ7
z)>hU)MzblS+#sk#4!NlI#UU|JQYtBFg4kqXi41y{tGcxz*`KM(g3lY!%nT@A)hh=C
zsaz@vtCH)62BuMH(F5SMv<75NrUp&cYew2?L8rO$4QfV;M=HBPxquwS+FX$~4V5*W
z17UwLAb&CJ57N$o8hXR3++NN0>Z)?Y*qiQ~8}wzfy{)=4ik$YSUMn2%P6<m*ou4K&
z*G$vQ2*_yyH3B@~0jn`7yCXxuE2VN}iVxmzImNIlYv)erd}kH}wwF7^o03ven7LCl
zN1=F}#a>luN|;+YO;dI|u0yZ4?>BUmw006YihMpnc56e1))w^60dH<OW-_BN#1I{5
zf*dIbn*ONXMwJB}gkqmu+}hVPk5METATSq1i@C#r5;{~AYD0-URSJn7DI;=KpB8>>
zM*`Q$G8>adq_pQcO)lWfYD!wFyBJML$;r%Yv*t#T-ikz~RxT9n$s0_g(Mx_wRKlU?
zL=tO~jMiwLC8J{`as|vuHyM+LCAVizq?|J=l8CQ1ai*liM5bCF5p-Unueer5(46KW
z&}JdHdG&*$S}J^BcbW}~r^XqRauVB9oT}i=qM>olM1!XC+%6h@KTP`c#kNwJ<}|DP
zq*ReURrJAZ5){257_u-2>nngj3%W!oEEdaQRr6nZs<|g!dz$st1vH;W*+Z$`T5%ZO
zPs@tpg=Lj4Tgs4Vu8>+PDs&c7QiWn!_DNzuUmKvtC<WT|DuSlN_gAH%%`%h<D#J51
zRnsZDxX@|700v!jd_ltR7Xz-ydPSFET`J7|ba2vk^hpFN3aKzC6&RvzWJZNXuF@GR
zDnBC#OsG`9=+cKf?UWW0%Sxs1iPKl3$3#_9y?#lcMKonJ$0`#Qp(G^1MOaIFr?Ro!
zfcBO%i-vTU98cfMRi`kfq`rNb>TqN*>hp|KfkoXfM%9j-8d^C?n~Tl<k`EIuyxVE%
zCzM?a9Q0Igflh9E4;JebqNO75bu7K<2A|=t68OUd2_OL^fCP{L5<mh-00|%gB!C2v
z022855nveuW1{<i17A=0lMvv61dsp{Kmter2_OL^fCP{L5<mh-014cc1Z)QOK0f*j
zkA4XZo7^Sx8-PI>S^YBlTfiy<f0Xb?`3rZYfv7YRKmter2_OL^fCP{L5<mh-00|%g
zB+x{_#@@$7KL#*Z*kp6$Qvmw?e}eTC;dk(J_$M7#9lIQ}9S_@&+ZWjb_HMRsZ3}Eg
zwqz)P2NFO6NB{{S0VIF~kN^@u0(TpMJ_#(Dm{}_OrA)V6p6T(bnQ{=GSt9#`@Vphc
z**eo3@TyK%G2BX>%X6eUE@oj>QdA`qZZ=mlY0_CC`h8BHEYgRUfP{e#mMFI*Knw<<
z-jjA{Ir-Kq!qXh4desVD1-KpF3pbO?ArLmi#**nVWr^+99b*MW?vGhnN1)wL9fC*B
z06~p}KkQSzz|<KL?v)hKrMHD8g)znXWtZfmMV~Q4)2T7bw$n5)jJ8_gY<kWGh#V7t
zyVf)j3Wj8OzKx=H?_(yAXTJ#*qe_TA9gZg~hFp@%DSAPxd?QHdej8GXMOF1lN~t&K
z42C4Qi9X~Fsvxju981Q=l&5>y815!<v{k=F!yb6NgVXJk%b?wX><@W+NKzzt(n4uw
zD*#UzK##<j3hO=HR*$A$p$br+$zoXIy$M0^fDJbl303I#{|VO9#CFKB+j`nA^LhME
z{$)plV~*ny`w9DEdy4H1+Y7d?ciTjV`XT`&fCP{L5<mh-00|%gBtS@Cb|MpVhtRzL
zPZ-8k$HgwJ?@QX<|MP=b<<<n~J2OWfSDk!|72Dmz+jH3Iv1K*wqqL7NT7Gt5%jc@^
zk6pQ)P56!X|JFWiVQg_t`+v)`Ty<*fvh6h8?*89=+txG@YPJ85AHh}IZ$`zo8`oCb
zU(?fEb@$tm(qbFlYX5IcWyi*rr+Zo4&EjaQev5`%?*F+T^!6L?|JhMobz*FV^`364
zM^mpv_y2}0)@zPAx^+P<_W$_&KU@`%01`j~NB{{S0VIF~kN^@u0!RP}{HzJE@M{4(
z{r;cf8wmX2fdr5M5<mh-00|%gB!C2v01`j~NB{}^3<<ET-Aup#=Pln5{yhI0pXWGX
zf7d?Go^88i`?GC{E#G?FI?tK~m+?RXNB{{S0VIF~kN^@u0zY*E1$-Q1uI|Ni4cj*v
z2&q4QrGH}mo@t4JL}%Q|K2-bQ((JJeA(H}2^Wxxi(n&2M2WISa6){!o3JCGMV<0=<
z?w&}<N6NMdwKGl3BnOo`*uh=@ZfN1L%>!iriLx#0e!rTm98XqmG}M2+f1_p6k(^`8
z_{9TW+PiAeh1&eaRkQXs7G9e*uJLza_unqKKiqRK^U<ZA$5yP^Tj+j-q^w(Q3c8Cb
zw@<&oO|(<#1MOUmXIv50@$_?~a={0NhWEgL@t`Xqr@DbQmmjGG?I7=c2)0;A)rOIf
zd;J|leG0@uuxhJj;r0E0+_L!8LQ-=fr<+-{QQ^aFTtlI;#(Ln2YyPHBb{&3o@OR<C
zMP0vp&T;ShjZ4kH`gqK+e&@Mv^PZ|7Y}o4YecH8lL&eg(xx4rE9c23WqhGJPxa+}p
zI_~~QdhP3<&&ZKhcYml>`S(1k3mmzlt+a_wR<3esc*}oAKJAQOJ}~k9&a<m7AHP`M
zsBCsBk8hU8e&e5CvYg3H;QsQq=e6wY^4VWkItB;pXA3nG8aHmKt8_NbX`Eu{WZ@Wd
zAIp0UhAQ&g%U5O|>DE~Hitw13wh(XTDnrFr-g;|@be$TyU?g<l%I-&2LVEX^OFcTg
zd;Yb9W%K1X|CLkO|G~2sLTb7n**7%hE8qHuv$OlNx$#sAiKo4|f9rJ5wZ?;Iat}2W
zcrGyHw3vOkFojf&+_~`F=N@_dqwZ^0x~|&QbGhSO<D$g1!}pFWI&qjQFi{D;OkBgL
zH^#q7NWWvQ_4g%`++}Id0naa+R||dc&m(7+Len$XFDzQSxNzs5vt`e1-!Q$~7Za9!
z5DtvqH*MLpp?gNZGVNN$<aPT)$CsVYH*_*mn~k4&_U>C-yJ14*w(g4-Z{cQ-h=ayn
zvBa&JWGW3W=rlbg>)pnLykETh0EG_6QDW#^(vR36*^i#nfc_JDFk1`tpfg0;W$m<v
zz<Eubzh{RQMYLp9+YF&qhIUz#o~!2zTBJEA(bIa{G#gS053HMF?D5prwU;mUm9Gvs
zH;|B3S9g>%lPk{{asykBKJmitC7sBOKNK_ox!XNpfJYBVp7spN_$tRpa~_A6K-k<D
z4`$^RakS5da9ritS!-uqUzYK_`y})aEphPD{_U$YA(vA<<Fq_-`P`xGahh3=zMT(U
zT-uT5*Y{XOqnZ_09(tc8kY2KYo~E3-CzsWnimklolM`b)eDZkLt%vx(mu((db#C0~
zvz{{Vsm_P@&g@dLI%oQUv)3}1@@@Q(I$@1xc-8*PX^j@{+XL|~1C;;|1h~F^T9FQP
z@+L`}2xyy=zpfiiCn{2PA}~OMHCX;@*fn#<jEdFivkrG&vc6%_pB7vQYh?&=mwnMg
zN4l^secQJG!Yo+htDDbR7|v|&%pG}s2VtrCJimzWSK$+Y6Z~QRApaHrCI319DZiQj
zkYCNO;FrT?JdgkqKmter2_OL^fCP{L5<mh-00|(0J3)Yc5XA7j7C9VRWVdUP&89_G
zs}@--T4XkBQGC1>nM_(_G-^>?oECAM7O|`r84MhJ3ZQ-ePZI8g0Vop*AOR$R1dsp{
zKmter2_OL^fCP{L68NbQ(0=}a`~ROxcc30f00|%gB!C2v01`j~NB{{S0VIF~?g#;T
z|9=9%hW`HlB7cTI&L82w<?G-cfL-u^0Jrg<@mu*#a38>$JJL7`MFL0w2_OL^fCP{L
z5<mh-00|%gB!C2NNPta%hxW5P4IDJE)4)apD-A3(Fw-EO1|}L9X%I&Pjs`3Z3^bt6
G|NkFH-Wk9E

diff --git a/.gitignore b/.gitignore
index db2fcf9..6d64161 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,3 +7,5 @@ __pycache__/
 .aws-sam/
 samconfig.toml
 vars.sh
+.coverage
+htmlcov/
diff --git a/tests/functional/test_activity_flows.py b/tests/functional/test_activity_flows.py
index 1c64f5f..e5f7780 100644
--- a/tests/functional/test_activity_flows.py
+++ b/tests/functional/test_activity_flows.py
@@ -379,8 +379,8 @@ class TestRealActivityFiles(unittest.TestCase):
             mock_get_client.return_value = (self.mock_client, "test-model")
 
             # Load actual activity3.yaml
-            activity_file = "/home/fox/git/opencompletion/research/activity3.yaml"
-            activity = guarded_ai.load_yaml_activity(activity_file)
+            activity_file = Path(__file__).parent.parent.parent / "research" / "activity3.yaml"
+            activity = guarded_ai.load_yaml_activity(str(activity_file))
 
             # Should have section_5 as the terminal section
             section_5 = None
@@ -408,9 +408,9 @@ class TestRealActivityFiles(unittest.TestCase):
             mock_get_client.return_value = (self.mock_client, "test-model")
 
             activity_file = (
-                "/home/fox/git/opencompletion/research/activity17-choose-adventure.yaml"
+                Path(__file__).parent.parent.parent / "research" / "activity17-choose-adventure.yaml"
             )
-            activity = guarded_ai.load_yaml_activity(activity_file)
+            activity = guarded_ai.load_yaml_activity(str(activity_file))
 
             # Find a step with metadata_remove operations
             found_remove_operation = False
@@ -450,9 +450,9 @@ class TestRealActivityFiles(unittest.TestCase):
             mock_get_client.return_value = (self.mock_client, "test-model")
 
             activity_file = (
-                "/home/fox/git/opencompletion/research/activity20-n-plus-1.yaml"
+                Path(__file__).parent.parent.parent / "research" / "activity20-n-plus-1.yaml"
             )
-            activity = guarded_ai.load_yaml_activity(activity_file)
+            activity = guarded_ai.load_yaml_activity(str(activity_file))
 
             # Find the step with integer bucket (1912)
             found_integer_bucket = False
diff --git a/tests/functional/test_battleship_pre_script.py b/tests/functional/test_battleship_pre_script.py
index 7f0a8a4..db9226a 100644
--- a/tests/functional/test_battleship_pre_script.py
+++ b/tests/functional/test_battleship_pre_script.py
@@ -28,9 +28,9 @@ class TestBattleshipPreScript(unittest.TestCase):
     def test_battleship_yaml_has_pre_script(self):
         """Test that battleship YAML loads and has pre_script"""
         activity_file = (
-            "/home/fox/git/opencompletion/research/activity29-battleship.yaml"
+            Path(__file__).parent.parent.parent / "research" / "activity29-battleship.yaml"
         )
-        activity = guarded_ai.load_yaml_activity(activity_file)
+        activity = guarded_ai.load_yaml_activity(str(activity_file))
 
         # Find step with pre_script
         found_pre_script = False
@@ -57,9 +57,9 @@ class TestBattleshipPreScript(unittest.TestCase):
     def test_battleship_pre_script_execution_simulation(self):
         """Test simulated battleship pre_script execution"""
         activity_file = (
-            "/home/fox/git/opencompletion/research/activity29-battleship.yaml"
+            Path(__file__).parent.parent.parent / "research" / "activity29-battleship.yaml"
         )
-        activity = guarded_ai.load_yaml_activity(activity_file)
+        activity = guarded_ai.load_yaml_activity(str(activity_file))
 
         # Find the step with pre_script (step_2)
         step_with_pre_script = None
@@ -96,8 +96,8 @@ class TestBattleshipPreScript(unittest.TestCase):
 
     def test_testship_yaml_has_pre_script(self):
         """Test that testship YAML also has pre_script"""
-        activity_file = "/home/fox/git/opencompletion/research/activity29-testship.yaml"
-        activity = guarded_ai.load_yaml_activity(activity_file)
+        activity_file = Path(__file__).parent.parent.parent / "research" / "activity29-testship.yaml"
+        activity = guarded_ai.load_yaml_activity(str(activity_file))
 
         # Should also have pre_script (same structure as battleship)
         found_pre_script = False
diff --git a/tests/functional/test_guarded_ai.py b/tests/functional/test_guarded_ai.py
index a5a6114..69f6adf 100644
--- a/tests/functional/test_guarded_ai.py
+++ b/tests/functional/test_guarded_ai.py
@@ -320,8 +320,8 @@ class TestActivityYAMLChanges(unittest.TestCase):
         """Test that activity3's new terminal section loads correctly"""
         import guarded_ai as guarded_ai
 
-        activity_file = "/home/fox/git/opencompletion/research/activity3.yaml"
-        activity = guarded_ai.load_yaml_activity(activity_file)
+        activity_file = Path(__file__).parent.parent.parent / "research" / "activity3.yaml"
+        activity = guarded_ai.load_yaml_activity(str(activity_file))
 
         # Should have section_5 now
         section_ids = [section["section_id"] for section in activity["sections"]]
@@ -348,9 +348,9 @@ class TestActivityYAMLChanges(unittest.TestCase):
         import guarded_ai as guarded_ai
 
         activity_file = (
-            "/home/fox/git/opencompletion/research/activity17-choose-adventure.yaml"
+            Path(__file__).parent.parent.parent / "research" / "activity17-choose-adventure.yaml"
         )
-        activity = guarded_ai.load_yaml_activity(activity_file)
+        activity = guarded_ai.load_yaml_activity(str(activity_file))
 
         # Find steps with metadata_remove
         found_metadata_remove = False
@@ -375,8 +375,8 @@ class TestActivityYAMLChanges(unittest.TestCase):
             "activity29-battleship.yaml",
             "activity29-testship.yaml",
         ]:
-            activity_file = f"/home/fox/git/opencompletion/research/{battleship_file}"
-            activity = guarded_ai.load_yaml_activity(activity_file)
+            activity_file = Path(__file__).parent.parent.parent / "research" / battleship_file
+            activity = guarded_ai.load_yaml_activity(str(activity_file))
 
             # Find exit transitions and verify they go to step_4
             exit_transitions_found = 0
diff --git a/tests/integration/test_activity_processing.py b/tests/integration/test_activity_processing.py
index e263742..78da2d3 100644
--- a/tests/integration/test_activity_processing.py
+++ b/tests/integration/test_activity_processing.py
@@ -11,6 +11,7 @@ import tempfile
 import json
 import sys
 import os
+import yaml
 from unittest.mock import Mock, patch, MagicMock
 from pathlib import Path
 
@@ -446,7 +447,7 @@ script_result = {'status': 'error'}
                 with open(test_file, "w") as f:
                     f.write(malformed_yaml)
 
-                with self.assertRaises(Exception):  # YAML parsing error
+                with self.assertRaises(yaml.YAMLError):  # YAML parsing error
                     app.get_activity_content("research/malformed.yaml")
 
         finally: