engineering/make_post_sell
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases 2 Packages Wiki Activity Actions

fix: split Subscription / Comments / Gift Cards into separate cards

Browse source 
Three sections shared a single <section class="shop-settings well">
wrapper — Subscription and Comments were nested *inside the same
card*, and Gift Cards lived in a bare <section class="well"> right
after Comments inside the same outer .one-column. So:

  - Subscription's body bled directly into Comment System Settings,
    no margin, no card break (fox's screenshot).
  - Gift Cards picked up only the legacy flat .well treatment — no
    elevation, no margin-bottom — because it lacked .shop-settings.

Split each into its own <section class="one-column">→<section
class="shop-settings well"> so the margin-bottom + elevation rules
from common.css land on every one. Gift Cards now also carries
.shop-settings so it matches the rest of the page.

Markup is otherwise unchanged. 18 tests in the shop_settings /
gift_card / styleguide / subscription / comment_settings slice green.
This commit is contained in:
russell@unturf.com 2026-05-15 15:58:16 -04:00
parent 91c0854a1f
commit 0f84e6871b
No known key found for this signature in database
1 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

16
make_post_sell/templates/shop_settings.j2
View file

@ -1180,6 +1180,15 @@ Existing sales honored for download buy purchasers.
</form>
</section>
</section>
<br />
<br />
<section class="one-column">
<section class="shop-settings well">
<form method="post" action="/s/{{ request.shop.id }}/settings">
<input type="hidden" name="form_section" value="comment-settings" />
@ -1217,8 +1226,13 @@ Existing sales honored for download buy purchasers.
</form>
</section>
</section>
<section class="well">
<br />
<br />
<section class="one-column">
<section class="shop-settings well">
<h3>Gift Cards</h3>
<form action="/s/{{ request.shop.uuid_str }}/settings" method="POST">