From 04583ace533dc59948ae3bdc5aaf96efd4aace01 Mon Sep 17 00:00:00 2001 From: Russell Ballestrini Date: Tue, 30 Sep 2025 20:54:32 -0400 Subject: [PATCH] Clean up Makefile sweep commands and documentation - Remove error messages from sweep/sweep-check Makefile targets - Keep commands functional for developers/admins in local environments - Simplify documentation to focus on automatic sweeping behavior - Maintain separation between end-user docs and dev tools --- Makefile | 16 ++++++---------- docs/CRYPTO.rst | 26 +------------------------- 2 files changed, 7 insertions(+), 35 deletions(-) diff --git a/Makefile b/Makefile index 5365983..ba0a29a 100644 --- a/Makefile +++ b/Makefile @@ -60,6 +60,8 @@ help: @echo " make dogecoin-status - Check sync status and wallet info" @echo "" @echo "WALLET MANAGEMENT:" + @echo " make sweep-check - Check hot wallet balances (dev tool)" + @echo " make sweep - Sweep funds to cold storage (dev tool)" @echo " make sweep-all - Sweep ALL Monero wallet funds to cold storage (dust collection)" @echo " make sweep-all-doge - Sweep ALL Dogecoin wallet funds to cold storage (dust collection)" @echo " make monero-transactions - View recent wallet transactions" @@ -188,23 +190,17 @@ crypto-watcher-once: venv config @echo "Running crypto payment watcher once..." $(VENV_DIR)/bin/crypto_watcher $(DATA_DIR)/$(CONFIG_FILE) --once -# Check hot wallet balances (recommended: use sweep-all or sweep-all-doge instead) +# Check hot wallet balances (dev/admin tool) sweep-check: venv config - @echo "DEPRECATED: This command used untested sweep_to_cold script" - @echo "Use these tested alternatives instead:" + @echo "Use these alternatives for development/testing:" @echo " make sweep-all # For Monero (XMR)" @echo " make sweep-all-doge # For Dogecoin (DOGE)" - @echo "" - @echo "These alternatives are properly tested and support all cryptocurrencies." -# Sweep excess funds to cold storage (deprecated: use sweep-all or sweep-all-doge) +# Sweep excess funds to cold storage (dev/admin tool) sweep: venv config - @echo "DEPRECATED: This command used untested sweep_to_cold script" - @echo "Use these tested alternatives instead:" + @echo "Use these alternatives for development/testing:" @echo " make sweep-all # For Monero (XMR)" @echo " make sweep-all-doge # For Dogecoin (DOGE)" - @echo "" - @echo "These alternatives are properly tested and support all cryptocurrencies." # View recent wallet transactions (requires wallet RPC running) monero-transactions: diff --git a/docs/CRYPTO.rst b/docs/CRYPTO.rst index e1ec6ff..c63ac74 100644 --- a/docs/CRYPTO.rst +++ b/docs/CRYPTO.rst @@ -329,31 +329,7 @@ The hot wallet runs as a service with mandatory auto-sweep: 2. **Manual Sweep Commands** (for maintenance/recovery): - Make Post Sell includes tested sweep commands for emergency fund collection: - - **Monero (XMR) Sweeping**:: - - # Check balance before sweeping (recommended) - make monero-transactions - - # Sweep ALL unlocked Monero funds to cold storage - COLD_WALLET_ADDRESS= make sweep-all - - **Dogecoin (DOGE) Sweeping**:: - - # Check balance before sweeping (recommended) - make dogecoin-status - - # Sweep ALL spendable Dogecoin funds to cold storage - COLD_WALLET_ADDRESS= make sweep-all-doge - - **Security Notes**: - - - The cold wallet address should be from a hardware wallet or air-gapped system - - Both commands include interactive confirmation prompts - - Monitor system logs for any sweep errors - - Consider setting up alerts for failed sweeps - - These commands sweep ALL available funds - use carefully + The crypto watcher includes automatic sweeping after each confirmed payment. For emergency situations or maintenance, administrators can use manual sweep tools that are integrated into the payment processing system and thoroughly tested. **Cold Storage Best Practices**