java-topology/test/jdk/java/io/FileReader/ConstructorTest.java
russell@unturf.com 0a580b313d undefect. CWE-407 — 63 sites patched across 27 ecosystems
Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com

Patches, unit tests, benchmarks, whitepaper, and outreach briefs.
Public domain — no copyright claimed. Use freely.
2026-03-26 17:11:57 -04:00

130 lines
4.6 KiB
Java

/*
* Copyright (c) 2018, 2026, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
import java.io.File;
import java.io.FileInputStream;
import java.io.FileReader;
import java.io.FileWriter;
import java.io.IOException;
import java.io.InputStreamReader;
import java.io.Reader;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
import java.util.stream.Stream;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
import static org.junit.jupiter.api.Assertions.assertEquals;
/**
* @test
* @bug 8183554
* @summary Test to verify the new Constructors that take a Charset.
* @run junit ConstructorTest
*/
public class ConstructorTest {
static String USER_DIR = System.getProperty("user.dir", ".");
public static enum ConstructorType {
STRING,
FILE
}
static final String TEST_STRING = "abc \u0100 \u0101 \u0555 \u07FD \u07FF";
static final int BUFFER_SIZE = 8192;
public static Stream<Arguments> parameters() throws IOException {
File file1 = new File(USER_DIR, "FileReaderTest1.txt");
File file2 = new File(USER_DIR, "FileReaderTest2.txt");
return Stream.of
(Arguments.of(ConstructorType.STRING, file1, file2, StandardCharsets.UTF_8),
Arguments.of(ConstructorType.FILE, file1, file2, StandardCharsets.UTF_8),
Arguments.of(ConstructorType.STRING, file1, file2, StandardCharsets.ISO_8859_1),
Arguments.of(ConstructorType.FILE, file1, file2, StandardCharsets.ISO_8859_1));
}
/**
* Verifies that the new constructors that take a Charset function the same
* as an InputStreamReader on a FileInputStream as was recommended before
* this change.
*
* @param type the type of the constructor
* @param file1 file1 to be read with a FileReader
* @param file2 file2 to be read with an InputStreamReader
* @param charset the charset
* @throws IOException
*/
@ParameterizedTest
@MethodSource("parameters")
void test(ConstructorType type, File file1, File file2, Charset charset)
throws Exception {
prepareFile(file1, TEST_STRING, charset);
prepareFile(file2, TEST_STRING, charset);
try (FileReader fr = getFileReader(type, file1, charset);
FileInputStream is = new FileInputStream(file2);
InputStreamReader isr = new InputStreamReader(is, charset);) {
String result1 = readAll(fr, BUFFER_SIZE);
String result2 = readAll(isr, BUFFER_SIZE);
assertEquals(result2, result1);
}
}
public String readAll(Reader reader, int bufferSize) throws IOException {
StringBuilder sb = new StringBuilder();
char[] buf = new char[bufferSize];
int numRead;
while ((numRead = reader.read(buf)) != -1) {
if (numRead == buf.length) {
sb.append(buf);
} else {
sb.append(String.valueOf(buf, 0, numRead));
}
}
return sb.toString();
}
/*
* Creates a FileReader over the given input file.
*/
FileReader getFileReader(ConstructorType type, File file, Charset charset)
throws IOException {
switch (type) {
case STRING:
return new FileReader(file.getPath(), charset);
case FILE:
return new FileReader(file, charset);
}
return null;
}
void prepareFile(File file, String content, Charset charset) throws IOException {
try (FileWriter writer = new FileWriter(file, charset);) {
writer.write(content);
}
}
}