russell@unturf.com
9934133dcf
Add 88 new defect entries to HIGH and MEDIUM tables:
HIGH: mysql-0001/0002, mariadb-0001, redis-0001/0002, valkey-0001/0002, openvpn-0001,
vlc-0001, prometheus-0001, otel-collector-0001, cockroachdb-0001..0004,
tidb-0001..0008, kubernetes-0001/0002, go-0001, kotlin-0002, scala-0001,
allegro5-0001, sdl2-0001, grafana-0001, clickhouse-0001, duckdb-0001,
mongodb-0001, envoy-0001, istio-0001, cilium-0001, linkerd2-0001,
linux-0001/0002/0003, tor-0002/0003, curl-0001, julia-0001, lua-0001,
perl5-0001, nats-0001, spring-0003/0004, tomcat-0001, onos-0002, odl-0002
MEDIUM: helm-0001, mariadb-0002, openssl-0001/0002, memcached-0001,
cassandra-0001..0004, flink-0001, storm-0001/0002, zookeeper-0001..0003,
pip-0001, gradle-0001, nginx-0001, haproxy-0001, caddy-0001, varnish-0001,
ffmpeg-0001, gstreamer-0001, raylib-0001, love2d-0001, php-0001/0002,
r-source-0001, cpython-0002, ruby-0001, rabbitmq-0003/0004, activemq-0001,
ovs-0001, onos-0003, odl-0002, jetty-0001
PDF: 976K
38 lines
1.3 KiB
Diff
38 lines
1.3 KiB
Diff
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
|
|
--- a/Zend/zend_compile.c
|
|
+++ b/Zend/zend_compile.c
|
|
@@ -3753,13 +3753,30 @@ static uint32_t zend_get_arg_num(const zend_function *fn, const zend_string *ar
|
|
{
|
|
- // TODO: Caching?
|
|
- for (uint32_t i = 0; i < fn->common.num_args; i++) {
|
|
- zend_arg_info *arg_info = &fn->op_array.arg_info[i];
|
|
- if (zend_string_equals(arg_info->name, arg_name)) {
|
|
- return i + 1;
|
|
- }
|
|
- }
|
|
-
|
|
- /* Either an invalid argument name, or collected into a variadic argument. */
|
|
- return (uint32_t) -1;
|
|
+ /*
|
|
+ * Build a HashTable from arg_name -> (1-based position) on first call,
|
|
+ * cache it on the zend_op_array. Subsequent calls are O(1) lookups.
|
|
+ * Replaces O(M) linear scan — was O(N*M) for N named args, M params.
|
|
+ */
|
|
+ if (!fn->op_array.arg_name_map) {
|
|
+ HashTable *ht = emalloc(sizeof(HashTable));
|
|
+ zend_hash_init(ht, fn->common.num_args, NULL, NULL, 0);
|
|
+ for (uint32_t i = 0; i < fn->common.num_args; i++) {
|
|
+ zend_arg_info *arg_info = &fn->op_array.arg_info[i];
|
|
+ zval pos;
|
|
+ ZVAL_LONG(&pos, i + 1);
|
|
+ zend_hash_add(ht, arg_info->name, &pos);
|
|
+ }
|
|
+ ((zend_op_array *)&fn->op_array)->arg_name_map = ht;
|
|
+ }
|
|
+
|
|
+ zval *zv = zend_hash_find(fn->op_array.arg_name_map, arg_name);
|
|
+ if (zv) {
|
|
+ return (uint32_t)Z_LVAL_P(zv);
|
|
+ }
|
|
+ return (uint32_t) -1;
|
|
}
|