russell@unturf.com
9934133dcf
Add 88 new defect entries to HIGH and MEDIUM tables:
HIGH: mysql-0001/0002, mariadb-0001, redis-0001/0002, valkey-0001/0002, openvpn-0001,
vlc-0001, prometheus-0001, otel-collector-0001, cockroachdb-0001..0004,
tidb-0001..0008, kubernetes-0001/0002, go-0001, kotlin-0002, scala-0001,
allegro5-0001, sdl2-0001, grafana-0001, clickhouse-0001, duckdb-0001,
mongodb-0001, envoy-0001, istio-0001, cilium-0001, linkerd2-0001,
linux-0001/0002/0003, tor-0002/0003, curl-0001, julia-0001, lua-0001,
perl5-0001, nats-0001, spring-0003/0004, tomcat-0001, onos-0002, odl-0002
MEDIUM: helm-0001, mariadb-0002, openssl-0001/0002, memcached-0001,
cassandra-0001..0004, flink-0001, storm-0001/0002, zookeeper-0001..0003,
pip-0001, gradle-0001, nginx-0001, haproxy-0001, caddy-0001, varnish-0001,
ffmpeg-0001, gstreamer-0001, raylib-0001, love2d-0001, php-0001/0002,
r-source-0001, cpython-0002, ruby-0001, rabbitmq-0003/0004, activemq-0001,
ovs-0001, onos-0003, odl-0002, jetty-0001
PDF: 976K
18 lines
1.1 KiB
Diff
18 lines
1.1 KiB
Diff
--- a/src/java/org/apache/cassandra/gms/Gossiper.java
|
|
+++ b/src/java/org/apache/cassandra/gms/Gossiper.java
|
|
@@ -144,10 +144,14 @@ public class Gossiper implements IFailureDetectionEventListener, GossiperMBean,
|
|
static final ApplicationState[] STATES = ApplicationState.values();
|
|
- static final List<String> DEAD_STATES = Arrays.asList(REMOVING_TOKEN, REMOVED_TOKEN, STATUS_LEFT, HIBERNATE);
|
|
- static ArrayList<String> SILENT_SHUTDOWN_STATES = new ArrayList<>();
|
|
+ // CWE-407 fix: use Set for O(1) membership test instead of O(N) List.contains().
|
|
+ // isDeadState() / isSilentShutdownState() are called per-endpoint per gossip tick;
|
|
+ // O(N) scans compound to O(|endpoints| * |DEAD_STATES|) per second.
|
|
+ static final Set<String> DEAD_STATES = ImmutableSet.of(
|
|
+ REMOVING_TOKEN, REMOVED_TOKEN, STATUS_LEFT, HIBERNATE);
|
|
+ static final Set<String> SILENT_SHUTDOWN_STATES;
|
|
static
|
|
{
|
|
- SILENT_SHUTDOWN_STATES.addAll(DEAD_STATES);
|
|
+ Set<String> s = new HashSet<>(DEAD_STATES);
|
|
+ SILENT_SHUTDOWN_STATES = Collections.unmodifiableSet(s);
|
|
}
|