russell@unturf.com
d67ec93a5d
vitest-0001: coverage-v8 coverage.result.find inside merged.result.forEach -> Map<url, result> lookup. Bench: 824x at N=M=10000 coverage entries. testng-0001: DynamicGraph.toDot freeNodes.contains inside two for-each loops -> Map<T, String> color lookup via getOrDefault. Bench: 64x at N=2000. jasmine-0001: SpyRegistry.spyOnAllFunctions propertiesToSkip.indexOf inside Array.filter + .concat growth across D prototype levels -> Set.has + O(1) growth. Bench: 61x at D=10, P=300. check-0001: libcheck suite_tcase linear strcmp scan over tclst List -> parallel hashtable for O(1) lookup amortized. Bench: 117x at N=1000. Shipped as design sketch; full integration requires companion hashtable. Also ships whitepaper/outreach/test-harness-survey.md documenting 14 clean-scan frameworks across Clojure, OCaml, Haskell, Erlang, Go, F#, Julia, Shell, Lua, JS. Scope covered 61 targets across 30+ languages. UNDF IDs: 1292 (check), 1293 (jasmine), 1294 (testng), 1295 (vitest). All 12 tests pass.
35 lines
1.7 KiB
Diff
35 lines
1.7 KiB
Diff
# UNDF: UNDF-2026-000001295
|
|
# UNDF: UNDF-2026-XXXXXXXXX
|
|
# CWE-407: Algorithmic Complexity -- O(N*M) -> O(N+M) in coverage-v8 generation
|
|
#
|
|
# Defect: onFileRead callback rebuilds missing startOffset by calling
|
|
# coverage.result.find(r => r.url === result.url) inside merged.result.forEach.
|
|
# N merged results x M per-process entries = O(N*M) per coverage file read.
|
|
# Fires on every coverage-enabled test run, compounds across multi-process.
|
|
#
|
|
# Fix: Build a Map<url, RawCoverageResult> once per onFileRead callback, then
|
|
# look up by url in O(1). Preserves existing semantics exactly; just swaps
|
|
# the lookup structure.
|
|
#
|
|
# Complexity gate (tests/test-vitest-cwe407.py):
|
|
# N=M=5000 coverage entries: fixed must complete in <10ms
|
|
# k-scaling 5x: time ratio must be <17.5x
|
|
--- a/packages/coverage-v8/src/provider.ts
|
|
+++ b/packages/coverage-v8/src/provider.ts
|
|
@@ -49,10 +49,13 @@ export class V8CoverageProvider extends BaseCoverageProvider<ResolvedCoverageOpt
|
|
await this.readCoverageFiles<RawCoverage>({
|
|
onFileRead(coverage) {
|
|
merged = mergeProcessCovs([merged, coverage])
|
|
|
|
+ // Build a URL lookup once; mergeProcessCovs sometimes loses startOffset
|
|
+ // (observed in Vue). Prior impl called coverage.result.find per missing
|
|
+ // entry, giving O(N*M) per callback; Map.get is O(1).
|
|
+ const byUrl = new Map(coverage.result.map(r => [r.url, r]))
|
|
// mergeProcessCovs sometimes loses startOffset, e.g. in vue
|
|
merged.result.forEach((result) => {
|
|
if (!result.startOffset) {
|
|
- const original = coverage.result.find(r => r.url === result.url)
|
|
+ const original = byUrl.get(result.url)
|
|
result.startOffset = original?.startOffset || 0
|
|
}
|
|
})
|