russell@unturf.com
d4ed2dff91
Hibernate (5 HIGH): addColumn/addReferencedColumn/addIndex ArrayList→LinkedHashSet (19x) FK second-pass LinkedHashSet, orderHierarchy LinkedHashSet MyBatis (1 MEDIUM): sortConstructorMappings indexOf→HashMap (12x) EF Core (2 HIGH + 1 MEDIUM): FindGenerationProperty HashSet (250x), AddPrincipals HashSet (250x), FK discovery HashSet (6x) Diesel (3 MEDIUM): SQLite/MySQL row position()→BTreeMap (51x) SQLAlchemy (2 HIGH): _values_bindparam Set (500x), evaluated_keys Set (500x) Peewee (1 MEDIUM): _SortedFieldList.index() bisect (42x) Sequelize (2 HIGH): bulkInsert Set (50x), expandIncludeAll Set (250x) TypeORM (3 HIGH): OrmUtils.uniq Map (500x), diffColumns Set (125x), updatedColumns Set (100x) Doctrine ORM (1 HIGH + 2 MEDIUM): hydrator discriminator (26x), addSubClass (250x), SqlWalker partial (130x) GORM (1 MEDIUM): sortCallbacks getRIndex→map (194x) SQLite: SqliteTest unit proof 4/4 PASS (101x) Unit tests: all PASS — Hibernate/MyBatis/EfCore/Diesel/SQLAlchemy/Peewee/ Sequelize/TypeORM/Doctrine/GORM Whitepaper: 157 sites, 62 ecosystems; PDF 752K
20 lines
920 B
Diff
20 lines
920 B
Diff
diff --git a/packages/core/src/abstract-dialect/query-generator.js b/packages/core/src/abstract-dialect/query-generator.js
|
|
--- a/packages/core/src/abstract-dialect/query-generator.js
|
|
+++ b/packages/core/src/abstract-dialect/query-generator.js
|
|
@@ -346,11 +346,13 @@ class AbstractQueryGenerator {
|
|
const tuples = [];
|
|
const serials = {};
|
|
- const allAttributes = [];
|
|
+ // CWE-407 fix: use a Set for O(1) membership test inside the double loop
|
|
+ // (for fieldValueHash -> forOwn key) to avoid O(rows * cols^2) complexity.
|
|
+ const allAttributesSet = new Set();
|
|
+ const allAttributes = [];
|
|
let onDuplicateKeyUpdate = '';
|
|
|
|
for (const fieldValueHash of fieldValueHashes) {
|
|
forOwn(fieldValueHash, (value, key) => {
|
|
- if (!allAttributes.includes(key)) {
|
|
+ if (!allAttributesSet.has(key)) {
|
|
+ allAttributesSet.add(key);
|
|
allAttributes.push(key);
|
|
}
|