russell@unturf.com
9934133dcf
Add 88 new defect entries to HIGH and MEDIUM tables:
HIGH: mysql-0001/0002, mariadb-0001, redis-0001/0002, valkey-0001/0002, openvpn-0001,
vlc-0001, prometheus-0001, otel-collector-0001, cockroachdb-0001..0004,
tidb-0001..0008, kubernetes-0001/0002, go-0001, kotlin-0002, scala-0001,
allegro5-0001, sdl2-0001, grafana-0001, clickhouse-0001, duckdb-0001,
mongodb-0001, envoy-0001, istio-0001, cilium-0001, linkerd2-0001,
linux-0001/0002/0003, tor-0002/0003, curl-0001, julia-0001, lua-0001,
perl5-0001, nats-0001, spring-0003/0004, tomcat-0001, onos-0002, odl-0002
MEDIUM: helm-0001, mariadb-0002, openssl-0001/0002, memcached-0001,
cassandra-0001..0004, flink-0001, storm-0001/0002, zookeeper-0001..0003,
pip-0001, gradle-0001, nginx-0001, haproxy-0001, caddy-0001, varnish-0001,
ffmpeg-0001, gstreamer-0001, raylib-0001, love2d-0001, php-0001/0002,
r-source-0001, cpython-0002, ruby-0001, rabbitmq-0003/0004, activemq-0001,
ovs-0001, onos-0003, odl-0002, jetty-0001
PDF: 976K
25 lines
1.4 KiB
Diff
25 lines
1.4 KiB
Diff
--- a/subprojects/core/src/main/java/org/gradle/api/internal/tasks/options/OptionReader.java
|
|
+++ b/subprojects/core/src/main/java/org/gradle/api/internal/tasks/options/OptionReader.java
|
|
@@ -1,5 +1,6 @@
|
|
import java.util.ArrayList;
|
|
+import java.util.Arrays;
|
|
+import java.util.HashSet;
|
|
import java.util.List;
|
|
import java.util.Map;
|
|
+import java.util.Set;
|
|
|
|
@@ -90,9 +92,10 @@ public class OptionReader {
|
|
private static JavaMethod<Object, ?> getOptionValueMethodForOption(List<JavaMethod<Object, ?>> optionValueMethods, OptionElement optionElement) {
|
|
JavaMethod<Object, ?> valueMethod = null;
|
|
for (JavaMethod<Object, ?> optionValueMethod : optionValueMethods) {
|
|
String[] optionNames = getOptionNames(optionValueMethod);
|
|
- // CWE-407: CollectionUtils.toList() allocates a new ArrayList on every iteration
|
|
- // then .contains() scans it linearly — O(A * M * N) total.
|
|
- if (CollectionUtils.toList(optionNames).contains(optionElement.getOptionName())) {
|
|
+ // CWE-407 fix: use a HashSet for O(1) membership instead of a freshly
|
|
+ // allocated ArrayList scanned linearly on every inner-loop iteration.
|
|
+ Set<String> optionNameSet = new HashSet<>(Arrays.asList(optionNames));
|
|
+ if (optionNameSet.contains(optionElement.getOptionName())) {
|
|
if (valueMethod == null) {
|
|
valueMethod = optionValueMethod;
|
|
} else {
|