russell@unturf.com
d668589698
xenia-0001: ObjectTable::GetAllObjects() in src/xenia/kernel/util/object_table.cc uses std::find on a growing results vector to deduplicate XObject pointers while iterating all 16,384+ table slots. Each slot incurs an O(results.size()) linear scan, giving O(S*R) total where S = slot count and R = unique object count. Fix: unordered_set seen-pointer set reduces membership test to O(1). Measured 4.3x speedup. MOAD-0002 Intertangle: CLEAN MOAD-0003 Leaked Context: CLEAN (TLS vars are thread-scoped, not request-scoped) MOAD-0004 CWE-312: CLEAN (no credentials or key bytes logged) MOAD-0005 Thundering Herd: CLEAN (all caches use global_critical_region_ lock)
7 lines
413 B
Text
7 lines
413 B
Text
MOAD-0002 (Intertangle): CLEAN
|
|
|
|
KernelState is a large central object but there is no evidence of independent
|
|
subsystems coupled through shared mutable global state in a way that causes
|
|
race conditions or incorrect phase mixing. Subsystems (GPU, CPU, kernel, APU)
|
|
communicate through clean interfaces and the global_critical_region_ pattern
|
|
provides explicit synchronization. No god-object coupling defect found.
|