russell@unturf.com
9934133dcf
Add 88 new defect entries to HIGH and MEDIUM tables:
HIGH: mysql-0001/0002, mariadb-0001, redis-0001/0002, valkey-0001/0002, openvpn-0001,
vlc-0001, prometheus-0001, otel-collector-0001, cockroachdb-0001..0004,
tidb-0001..0008, kubernetes-0001/0002, go-0001, kotlin-0002, scala-0001,
allegro5-0001, sdl2-0001, grafana-0001, clickhouse-0001, duckdb-0001,
mongodb-0001, envoy-0001, istio-0001, cilium-0001, linkerd2-0001,
linux-0001/0002/0003, tor-0002/0003, curl-0001, julia-0001, lua-0001,
perl5-0001, nats-0001, spring-0003/0004, tomcat-0001, onos-0002, odl-0002
MEDIUM: helm-0001, mariadb-0002, openssl-0001/0002, memcached-0001,
cassandra-0001..0004, flink-0001, storm-0001/0002, zookeeper-0001..0003,
pip-0001, gradle-0001, nginx-0001, haproxy-0001, caddy-0001, varnish-0001,
ffmpeg-0001, gstreamer-0001, raylib-0001, love2d-0001, php-0001/0002,
r-source-0001, cpython-0002, ruby-0001, rabbitmq-0003/0004, activemq-0001,
ovs-0001, onos-0003, odl-0002, jetty-0001
PDF: 976K
38 lines
1.3 KiB
Diff
38 lines
1.3 KiB
Diff
diff --git a/src/cmd/compile/internal/types2/infer.go b/src/cmd/compile/internal/types2/infer.go
|
|
index eeefb117..cwe407fix 100644
|
|
--- a/src/cmd/compile/internal/types2/infer.go
|
|
+++ b/src/cmd/compile/internal/types2/infer.go
|
|
@@ -543,14 +543,20 @@ func isParameterized(tparams []*TypeParam, typ Type) bool {
|
|
- w := tpWalker{
|
|
- tparams: tparams,
|
|
- seen: make(map[Type]bool),
|
|
- }
|
|
+ // CWE-407 fix: pre-build a map for O(1) TypeParam membership check.
|
|
+ // Previously tpWalker used a []*TypeParam slice and called slices.Index
|
|
+ // (O(n)) at every *TypeParam node during the walk — O(n²) total for n
|
|
+ // type parameters in a generic function.
|
|
+ tset := make(map[*TypeParam]bool, len(tparams))
|
|
+ for _, tp := range tparams {
|
|
+ tset[tp] = true
|
|
+ }
|
|
+ w := tpWalker{
|
|
+ tparams: tset,
|
|
+ seen: make(map[Type]bool),
|
|
+ }
|
|
return w.isParameterized(typ)
|
|
}
|
|
|
|
type tpWalker struct {
|
|
- tparams []*TypeParam
|
|
+ tparams map[*TypeParam]bool // CWE-407: was []*TypeParam (O(n) contains)
|
|
seen map[Type]bool
|
|
}
|
|
|
|
@@ -627,7 +633,7 @@ func (w *tpWalker) isParameterized(typ Type) (res bool) {
|
|
|
|
case *TypeParam:
|
|
- return slices.Index(w.tparams, t) >= 0
|
|
+ return w.tparams[t] // CWE-407: O(1) map lookup, was O(n) slices.Index
|
|
|
|
default:
|
|
panic(fmt.Sprintf("unexpected %T", typ))
|