russell@unturf.com
9934133dcf
Add 88 new defect entries to HIGH and MEDIUM tables:
HIGH: mysql-0001/0002, mariadb-0001, redis-0001/0002, valkey-0001/0002, openvpn-0001,
vlc-0001, prometheus-0001, otel-collector-0001, cockroachdb-0001..0004,
tidb-0001..0008, kubernetes-0001/0002, go-0001, kotlin-0002, scala-0001,
allegro5-0001, sdl2-0001, grafana-0001, clickhouse-0001, duckdb-0001,
mongodb-0001, envoy-0001, istio-0001, cilium-0001, linkerd2-0001,
linux-0001/0002/0003, tor-0002/0003, curl-0001, julia-0001, lua-0001,
perl5-0001, nats-0001, spring-0003/0004, tomcat-0001, onos-0002, odl-0002
MEDIUM: helm-0001, mariadb-0002, openssl-0001/0002, memcached-0001,
cassandra-0001..0004, flink-0001, storm-0001/0002, zookeeper-0001..0003,
pip-0001, gradle-0001, nginx-0001, haproxy-0001, caddy-0001, varnish-0001,
ffmpeg-0001, gstreamer-0001, raylib-0001, love2d-0001, php-0001/0002,
r-source-0001, cpython-0002, ruby-0001, rabbitmq-0003/0004, activemq-0001,
ovs-0001, onos-0003, odl-0002, jetty-0001
PDF: 976K
63 lines
2.3 KiB
Diff
63 lines
2.3 KiB
Diff
diff --git a/controller/api/destination/federated_service_watcher.go b/controller/api/destination/federated_service_watcher.go
|
|
index 1234567..abcdef0 100644
|
|
--- a/controller/api/destination/federated_service_watcher.go
|
|
+++ b/controller/api/destination/federated_service_watcher.go
|
|
@@ -43,7 +43,8 @@ type federatedService struct {
|
|
sync.RWMutex
|
|
id ServiceID
|
|
subscribers []federatedServiceSubscriber
|
|
- remoteDiscovery []remoteDiscoveryID
|
|
+ // remoteDiscovery stored as map for O(1) membership tests in update().
|
|
+ remoteDiscovery map[remoteDiscoveryID]struct{}
|
|
localDiscovery string
|
|
log *logging.Entry
|
|
fsw *FederatedServiceWatcher
|
|
@@ -210,7 +211,10 @@ func (fsw *FederatedServiceWatcher) newFederatedService(service *corev1.Service)
|
|
fs := &federatedService{...}
|
|
- fs.remoteDiscovery = remoteDiscoveryIDs(service, fsw.log)
|
|
+ ids := remoteDiscoveryIDs(service, fsw.log)
|
|
+ fs.remoteDiscovery = make(map[remoteDiscoveryID]struct{}, len(ids))
|
|
+ for _, id := range ids {
|
|
+ fs.remoteDiscovery[id] = struct{}{}
|
|
+ }
|
|
...
|
|
}
|
|
|
|
@@ -225,18 +229,18 @@ func (fs *federatedService) update(service *corev1.Service) {
|
|
fs.Lock()
|
|
defer fs.Unlock()
|
|
|
|
- newRemoteDiscovery := remoteDiscoveryIDs(service, fs.log)
|
|
- for _, id := range newRemoteDiscovery {
|
|
- if !slices.Contains(fs.remoteDiscovery, id) {
|
|
+ // Build new set in O(N), then diff old vs new in O(N).
|
|
+ newIDs := remoteDiscoveryIDs(service, fs.log)
|
|
+ newSet := make(map[remoteDiscoveryID]struct{}, len(newIDs))
|
|
+ for _, id := range newIDs {
|
|
+ newSet[id] = struct{}{}
|
|
+ }
|
|
+ for id := range newSet {
|
|
+ if _, exists := fs.remoteDiscovery[id]; !exists {
|
|
for i := range fs.subscribers {
|
|
fs.remoteDiscoverySubscribe(&fs.subscribers[i], id)
|
|
}
|
|
}
|
|
}
|
|
- for _, id := range fs.remoteDiscovery {
|
|
- if !slices.Contains(newRemoteDiscovery, id) {
|
|
+ for id := range fs.remoteDiscovery {
|
|
+ if _, exists := newSet[id]; !exists {
|
|
for i := range fs.subscribers {
|
|
fs.remoteDiscoveryUnsubscribe(&fs.subscribers[i], id)
|
|
}
|
|
}
|
|
}
|
|
- fs.remoteDiscovery = newRemoteDiscovery
|
|
+ fs.remoteDiscovery = newSet
|
|
|
|
@@ -308,7 +312,7 @@ func (fs *federatedService) onServiceAdd(service *corev1.Service) {
|
|
- for _, id := range fs.remoteDiscovery {
|
|
+ for id := range fs.remoteDiscovery {
|
|
fs.remoteDiscoverySubscribe(&fs.subscribers[len(fs.subscribers)-1], id)
|
|
}
|
|
}
|