19 lines
1.1 KiB
Diff
19 lines
1.1 KiB
Diff
# UNDF: UNDF-2026-000000023
|
|
--- a/src/java/org/apache/cassandra/gms/Gossiper.java
|
|
+++ b/src/java/org/apache/cassandra/gms/Gossiper.java
|
|
@@ -144,10 +144,14 @@ public class Gossiper implements IFailureDetectionEventListener, GossiperMBean,
|
|
static final ApplicationState[] STATES = ApplicationState.values();
|
|
- static final List<String> DEAD_STATES = Arrays.asList(REMOVING_TOKEN, REMOVED_TOKEN, STATUS_LEFT, HIBERNATE);
|
|
- static ArrayList<String> SILENT_SHUTDOWN_STATES = new ArrayList<>();
|
|
+ // CWE-407 fix: use Set for O(1) membership test instead of O(N) List.contains().
|
|
+ // isDeadState() / isSilentShutdownState() are called per-endpoint per gossip tick;
|
|
+ // O(N) scans compound to O(|endpoints| * |DEAD_STATES|) per second.
|
|
+ static final Set<String> DEAD_STATES = ImmutableSet.of(
|
|
+ REMOVING_TOKEN, REMOVED_TOKEN, STATUS_LEFT, HIBERNATE);
|
|
+ static final Set<String> SILENT_SHUTDOWN_STATES;
|
|
static
|
|
{
|
|
- SILENT_SHUTDOWN_STATES.addAll(DEAD_STATES);
|
|
+ Set<String> s = new HashSet<>(DEAD_STATES);
|
|
+ SILENT_SHUTDOWN_STATES = Collections.unmodifiableSet(s);
|
|
}
|