russell@unturf.com
9934133dcf
Add 88 new defect entries to HIGH and MEDIUM tables:
HIGH: mysql-0001/0002, mariadb-0001, redis-0001/0002, valkey-0001/0002, openvpn-0001,
vlc-0001, prometheus-0001, otel-collector-0001, cockroachdb-0001..0004,
tidb-0001..0008, kubernetes-0001/0002, go-0001, kotlin-0002, scala-0001,
allegro5-0001, sdl2-0001, grafana-0001, clickhouse-0001, duckdb-0001,
mongodb-0001, envoy-0001, istio-0001, cilium-0001, linkerd2-0001,
linux-0001/0002/0003, tor-0002/0003, curl-0001, julia-0001, lua-0001,
perl5-0001, nats-0001, spring-0003/0004, tomcat-0001, onos-0002, odl-0002
MEDIUM: helm-0001, mariadb-0002, openssl-0001/0002, memcached-0001,
cassandra-0001..0004, flink-0001, storm-0001/0002, zookeeper-0001..0003,
pip-0001, gradle-0001, nginx-0001, haproxy-0001, caddy-0001, varnish-0001,
ffmpeg-0001, gstreamer-0001, raylib-0001, love2d-0001, php-0001/0002,
r-source-0001, cpython-0002, ruby-0001, rabbitmq-0003/0004, activemq-0001,
ovs-0001, onos-0003, odl-0002, jetty-0001
PDF: 976K
34 lines
1.2 KiB
Diff
34 lines
1.2 KiB
Diff
--- a/pkg/sql/opt/exec/execbuilder/builder.go
|
|
+++ b/pkg/sql/opt/exec/execbuilder/builder.go
|
|
@@ -197,16 +197,28 @@ type IndexesUsed struct {
|
|
// IndexesUsed is a list of indexes used in a query.
|
|
type IndexesUsed struct {
|
|
indexes []struct {
|
|
tableID cat.StableID
|
|
indexID cat.StableID
|
|
}
|
|
+ // seen is a set of already-added (tableID, indexID) pairs for O(1)
|
|
+ // deduplication. Without it, add() calls slices.Contains on the growing
|
|
+ // slice — O(N) per add, O(N²) total across N index references in a query.
|
|
+ seen map[[2]cat.StableID]struct{}
|
|
}
|
|
|
|
-// add adds the given index to the list, if it is not already present.
|
|
+// add adds the given index to the list if it is not already present.
|
|
+// O(1) amortized via the seen map; previously O(N) via slices.Contains.
|
|
func (iu *IndexesUsed) add(tableID, indexID cat.StableID) {
|
|
s := struct {
|
|
tableID cat.StableID
|
|
indexID cat.StableID
|
|
}{tableID, indexID}
|
|
- if !slices.Contains(iu.indexes, s) {
|
|
- iu.indexes = append(iu.indexes, s)
|
|
+ key := [2]cat.StableID{tableID, indexID}
|
|
+ if iu.seen == nil {
|
|
+ iu.seen = make(map[[2]cat.StableID]struct{})
|
|
}
|
|
+ if _, ok := iu.seen[key]; !ok {
|
|
+ iu.seen[key] = struct{}{}
|
|
+ iu.indexes = append(iu.indexes, s)
|
|
+ }
|
|
}
|