russell@unturf.com
9934133dcf
Add 88 new defect entries to HIGH and MEDIUM tables:
HIGH: mysql-0001/0002, mariadb-0001, redis-0001/0002, valkey-0001/0002, openvpn-0001,
vlc-0001, prometheus-0001, otel-collector-0001, cockroachdb-0001..0004,
tidb-0001..0008, kubernetes-0001/0002, go-0001, kotlin-0002, scala-0001,
allegro5-0001, sdl2-0001, grafana-0001, clickhouse-0001, duckdb-0001,
mongodb-0001, envoy-0001, istio-0001, cilium-0001, linkerd2-0001,
linux-0001/0002/0003, tor-0002/0003, curl-0001, julia-0001, lua-0001,
perl5-0001, nats-0001, spring-0003/0004, tomcat-0001, onos-0002, odl-0002
MEDIUM: helm-0001, mariadb-0002, openssl-0001/0002, memcached-0001,
cassandra-0001..0004, flink-0001, storm-0001/0002, zookeeper-0001..0003,
pip-0001, gradle-0001, nginx-0001, haproxy-0001, caddy-0001, varnish-0001,
ffmpeg-0001, gstreamer-0001, raylib-0001, love2d-0001, php-0001/0002,
r-source-0001, cpython-0002, ruby-0001, rabbitmq-0003/0004, activemq-0001,
ovs-0001, onos-0003, odl-0002, jetty-0001
PDF: 976K
29 lines
1.5 KiB
Diff
29 lines
1.5 KiB
Diff
diff --git a/src/core/or/scheduler_kist.c b/src/core/or/scheduler_kist.c
|
|
index abc1234..def5678 100644
|
|
--- a/src/core/or/scheduler_kist.c
|
|
+++ b/src/core/or/scheduler_kist.c
|
|
@@ -753,15 +753,13 @@ kist_scheduler_run(void)
|
|
/* Re-add any channels we need to */
|
|
if (to_readd) {
|
|
SMARTLIST_FOREACH_BEGIN(to_readd, channel_t *, readd_chan) {
|
|
scheduler_set_channel_state(readd_chan, SCHED_CHAN_PENDING);
|
|
- if (!smartlist_contains(cp, readd_chan)) {
|
|
- if (!SCHED_BUG(readd_chan->sched_heap_idx != -1, readd_chan)) {
|
|
- /* XXXX Note that the check above is in theory redundant with
|
|
- * the smartlist_contains check. But let's make sure we're
|
|
- * not messing anything up, and leave them both for now. */
|
|
- smartlist_pqueue_add(cp, scheduler_compare_channels,
|
|
- offsetof(channel_t, sched_heap_idx), readd_chan);
|
|
- }
|
|
+ /*
|
|
+ * CWE-407 fix: sched_heap_idx == -1 is the O(1) test for "not already
|
|
+ * in the pending pqueue cp". The previous smartlist_contains(cp, ...)
|
|
+ * was an O(|cp|) linear scan that the comment already called "in theory
|
|
+ * redundant". Remove it; rely on the heap-index invariant alone.
|
|
+ */
|
|
+ if (readd_chan->sched_heap_idx == -1) {
|
|
+ smartlist_pqueue_add(cp, scheduler_compare_channels,
|
|
+ offsetof(channel_t, sched_heap_idx), readd_chan);
|
|
}
|
|
} SMARTLIST_FOREACH_END(readd_chan);
|
|
smartlist_free(to_readd);
|