java-topology/test/hotspot/jtreg/compiler/c2/irTests/UDivINodeIdealizationTests.java
russell@unturf.com 0a580b313d undefect. CWE-407 — 63 sites patched across 27 ecosystems
Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com

Patches, unit tests, benchmarks, whitepaper, and outreach briefs.
Public domain — no copyright claimed. Use freely.
2026-03-26 17:11:57 -04:00

162 lines
5.6 KiB
Java

/*
* Copyright (c) 2022, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
package compiler.c2.irTests;
import jdk.test.lib.Asserts;
import jdk.test.lib.Utils;
import java.util.Random;
import compiler.lib.ir_framework.*;
/*
* @test
* @bug 8332268
* @key randomness
* @summary Test that Ideal transformations of UDivINode* are being performed as expected.
* @library /test/lib /
* @run driver compiler.c2.irTests.UDivINodeIdealizationTests
*/
public class UDivINodeIdealizationTests {
public static final int RANDOM_POWER_OF_2 = 1 << (1 + Utils.getRandomInstance().nextInt(30));
public static void main(String[] args) {
TestFramework.run();
}
@Run(test = {"constant", "identity", "identityAgain", "identityAgainButBig", "identityThird",
"retainDenominator", "divByPow2", "divByPow2Big", "divByPow2Random" })
public void runMethod() {
int a = RunInfo.getRandom().nextInt();
a = (a == 0) ? 1 : a;
int b = RunInfo.getRandom().nextInt();
b = (b == 0) ? 1 : b;
int min = Integer.MIN_VALUE;
int max = Integer.MAX_VALUE;
assertResult(0, 0, true);
assertResult(a, b, false);
assertResult(min, min, false);
assertResult(max, max, false);
}
@DontCompile
public void assertResult(int a, int b, boolean shouldThrow) {
try {
Asserts.assertEQ(Integer.divideUnsigned(a, a), constant(a));
Asserts.assertFalse(shouldThrow, "Expected an exception to be thrown.");
} catch (ArithmeticException e) {
Asserts.assertTrue(shouldThrow, "Did not expect an exception to be thrown.");
}
try {
Asserts.assertEQ(Integer.divideUnsigned(a, Integer.divideUnsigned(b, b)), identityThird(a, b));
Asserts.assertFalse(shouldThrow, "Expected an exception to be thrown.");
} catch (ArithmeticException e) {
Asserts.assertTrue(shouldThrow, "Did not expect an exception to be thrown.");
}
try {
Asserts.assertEQ(Integer.divideUnsigned((a * b), b), retainDenominator(a, b));
Asserts.assertFalse(shouldThrow, "Expected an exception to be thrown.");
} catch (ArithmeticException e) {
Asserts.assertTrue(shouldThrow, "Did not expect an exception to be thrown.");
}
Asserts.assertEQ(Integer.divideUnsigned(a, 1), identity(a));
Asserts.assertEQ(Integer.divideUnsigned(a, Integer.divideUnsigned(13, 13)), identityAgain(a));
Asserts.assertEQ(Integer.divideUnsigned(a, 8), divByPow2(a), "divByPow2 " + a);
Asserts.assertEQ(Integer.divideUnsigned(a, Integer.MIN_VALUE), divByPow2Big(a));
Asserts.assertEQ(Integer.divideUnsigned(a, Integer.divideUnsigned((1 << 20) + 1, (1 << 20) + 1)), identityAgainButBig(a));
}
@Test
@IR(failOn = {IRNode.UDIV})
@IR(counts = {IRNode.DIV_BY_ZERO_TRAP, "1"})
// Checks x / x => 1
public int constant(int x) {
return Integer.divideUnsigned(x, x);
}
@Test
@IR(failOn = {IRNode.UDIV})
// Checks x / 1 => x
public int identity(int x) {
return Integer.divideUnsigned(x, 1);
}
@Test
@IR(failOn = {IRNode.UDIV})
// Checks x / (c / c) => x
public int identityAgain(int x) {
return Integer.divideUnsigned(x, Integer.divideUnsigned(13, 13));
}
@Test
@IR(failOn = {IRNode.UDIV})
// Checks x / (c / c) => x
public int identityAgainButBig(int x) {
// (1 << 20) + 1 is an arbitrary integer that cannot be optimized by the power of 2 optimizations
return Integer.divideUnsigned(x, Integer.divideUnsigned((1 << 20) + 1, (1 << 20) + 1));
}
@Test
@IR(failOn = {IRNode.UDIV})
@IR(counts = {IRNode.DIV_BY_ZERO_TRAP, "1"})
// Checks x / (y / y) => x
public int identityThird(int x, int y) {
return Integer.divideUnsigned(x, Integer.divideUnsigned(y, y));
}
@Test
@IR(counts = {IRNode.MUL, "1",
IRNode.UDIV_I, "1",
IRNode.DIV_BY_ZERO_TRAP, "1"
})
public int retainDenominator(int x, int y) {
return Integer.divideUnsigned((x * y), y);
}
@Test
@IR(failOn = {IRNode.UDIV})
@IR(counts = {IRNode.URSHIFT, "1"})
// Dividing an unsigned number by 8 is a trivial right shift by 3
public int divByPow2(int x) {
return Integer.divideUnsigned(x, 8);
}
@Test
@IR(failOn = {IRNode.UDIV})
@IR(counts = {IRNode.URSHIFT, "1"})
public int divByPow2Random(int x) {
return Integer.divideUnsigned(x, RANDOM_POWER_OF_2);
}
@Test
@IR(failOn = {IRNode.UDIV})
@IR(counts = {IRNode.URSHIFT, "1"})
public int divByPow2Big(int x) {
return Integer.divideUnsigned(x, Integer.MIN_VALUE);
}
}