java-topology/test/jdk/sun/security/tools/jarsigner/RemovedFiles.java

/*
 * Copyright (c) 2024, 2025, Oracle and/or its affiliates. All rights reserved.
 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
 *
 * This code is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License version 2 only, as
 * published by the Free Software Foundation.
 *
 * This code is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 * version 2 for more details (a copy is included in the LICENSE file that
 * accompanied this code).
 *
 * You should have received a copy of the GNU General Public License version
 * 2 along with this work; if not, write to the Free Software Foundation,
 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
 *
 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
 * or visit www.oracle.com if you need additional information or have any
 * questions.
 */

/*
 * @test
 * @bug 8309841 8365559
 * @summary Jarsigner should print a warning if an entry is removed
 * @library /test/lib
 */

import jdk.test.lib.SecurityTools;
import jdk.test.lib.util.JarUtils;

import java.nio.file.Files;
import java.nio.file.Path;
import java.util.jar.Attributes;
import java.util.jar.Manifest;

public class RemovedFiles {

    private static final String NONEXISTENT_ENTRIES_FOUND
            = "This jar contains signed entries for files that do not exist. See the -verbose output for more details.";
    private static final String WEAK_UNSIGNED
            = "The jar will be treated as unsigned, because it is signed with a weak algorithm that is now disabled";

    public static void main(String[] args) throws Exception {
        t8309841();
        t8365559();
    }

    static void t8309841() throws Exception {
        JarUtils.createJarFile(
                Path.of("a.jar"),
                Path.of("."),
                Files.writeString(Path.of("a"), "a"),
                Files.writeString(Path.of("b"), "b"));
        SecurityTools.keytool("-genkeypair -storepass changeit -keystore ks -alias x -dname CN=x -keyalg ed25519");
        SecurityTools.jarsigner("-storepass changeit -keystore ks a.jar x");

        // All is fine at the beginning.
        SecurityTools.jarsigner("-verify a.jar")
                .shouldNotContain(NONEXISTENT_ENTRIES_FOUND);

        // Remove an entry after signing. There will be a warning.
        JarUtils.deleteEntries(Path.of("a.jar"), "a");
        SecurityTools.jarsigner("-verify a.jar")
                .shouldContain(NONEXISTENT_ENTRIES_FOUND);
        SecurityTools.jarsigner("-verify -verbose a.jar")
                .shouldContain(NONEXISTENT_ENTRIES_FOUND)
                .shouldContain("Warning: nonexistent signed entries: [a]");

        // Remove one more entry.
        JarUtils.deleteEntries(Path.of("a.jar"), "b");
        SecurityTools.jarsigner("-verify a.jar")
                .shouldContain(NONEXISTENT_ENTRIES_FOUND);
        SecurityTools.jarsigner("-verify -verbose a.jar")
                .shouldContain(NONEXISTENT_ENTRIES_FOUND)
                .shouldContain("Warning: nonexistent signed entries: [a, b]");

        // Re-sign will not clear the warning.
        SecurityTools.jarsigner("-storepass changeit -keystore ks a.jar x");
        SecurityTools.jarsigner("-verify a.jar")
                .shouldContain(NONEXISTENT_ENTRIES_FOUND);

        // Unfortunately, if there is a non-file entry in manifest, there will be
        // a false alarm. See https://bugs.openjdk.org/browse/JDK-8334261.
        var man = new Manifest();
        man.getMainAttributes().putValue("Manifest-Version", "1.0");
        man.getEntries().computeIfAbsent("Hello", _ -> new Attributes())
                .putValue("Foo", "Bar");
        JarUtils.createJarFile(Path.of("b.jar"),
                man,
                Path.of("."),
                Path.of("a"));
        SecurityTools.jarsigner("-storepass changeit -keystore ks b.jar x");
        SecurityTools.jarsigner("-verbose -verify b.jar")
                .shouldContain("Warning: nonexistent signed entries: [Hello]")
                .shouldContain(NONEXISTENT_ENTRIES_FOUND);
    }

    static void t8365559() throws Exception {
        JarUtils.createJarFile(
                Path.of("c.jar"),
                Path.of("."),
                Files.writeString(Path.of("c"), "c"));
        SecurityTools.keytool("-genkeypair -storepass changeit -keystore ks -alias w -dname CN=w -keyalg ec");

        // Sign the JAR using an already disabled signature algorithm SHA1withECDSA.
        // The file can still be signed but verification will treat it as unsigned.
        SecurityTools.jarsigner("-storepass changeit -keystore ks c.jar w -sigalg SHA1withECDSA")
                        .shouldContain("the -sigalg option is considered a security risk and is disabled.");

        SecurityTools.jarsigner("-verify c.jar")
                .shouldContain(WEAK_UNSIGNED)
                .shouldNotContain(NONEXISTENT_ENTRIES_FOUND);
        SecurityTools.jarsigner("-verify -verbose c.jar")
                .shouldContain(WEAK_UNSIGNED)
                .shouldNotContain(NONEXISTENT_ENTRIES_FOUND)
                .shouldNotContain("Warning: nonexistent signed entries:");
    }
}