java-topology/defects/contiki-0001/patch/contiki-0001.patch

27 lines
1.3 KiB
Diff

# UNDF: UNDF-2026-000001071
--- a/os/services/lwm2m/lwm2m-security.c
+++ b/os/services/lwm2m/lwm2m-security.c
@@ -204,10 +204,8 @@ write_security_object(lwm2m_object_instance_t *object,
lwm2m_object_read_string(ctx, ctx->inbuf->buffer, ctx->inbuf->size, security->public_key, LWM2M_SECURITY_KEY_SIZE);
security->public_key_len = ctx->last_value_len;
- LOG_DBG("Writing client PKI: len: %"PRIu16" '", ctx->last_value_len);
- LOG_DBG_COAP_STRING((const char *)security->public_key,
- ctx->last_value_len);
- LOG_DBG_("'\n");
+ /* CWE-312: do not log PKI credential material, even at DBG level */
+ LOG_DBG("Writing client PKI: len: %"PRIu16"\n", ctx->last_value_len);
break;
case LWM2M_SECURITY_KEY_ID:
lwm2m_object_read_string(ctx, ctx->inbuf->buffer, ctx->inbuf->size, security->secret_key, LWM2M_SECURITY_KEY_SIZE);
@@ -215,10 +213,8 @@ write_security_object(lwm2m_object_instance_t *object,
- LOG_DBG("Writing secret key: len: %"PRIu16" '", ctx->last_value_len);
- LOG_DBG_COAP_STRING((const char *)security->secret_key,
- ctx->last_value_len);
- LOG_DBG_("'\n");
+ /* CWE-312: do not log PSK secret key material, even at DBG level */
+ LOG_DBG("Writing secret key: len: %"PRIu16"\n", ctx->last_value_len);
break;
}