|
|
806713a90c
|
xonotic: 4 CWE-407 defects in DarkPlaces engine, MOAD 0002-0005 CLEAN
xonotic-0001: Mod_Mesh_GetTexture O(T) linear scan per draw call, 43x
model_shared.c:4481 scans all textures for every quad/char/image drawn.
Fix: hash table keyed on (name, drawflag, texflags, matflags).
xonotic-0002: SV_ModelIndex O(M) linear scan, 81x
sv_main.c:1421 scans model_precache[] (up to 8192) on every model ref.
Fix: hash table on model filename.
xonotic-0003: SV_SoundIndex O(S) linear scan, 66x
sv_main.c:1484 scans sound_precache[] (up to 4096) on every sound ref.
Fix: hash table on sound filename.
xonotic-0004: S_FindName O(N) linked list scan, 72x
snd_main.c:913 traverses linked list (has "TODO: hash table search?").
Fix: hash chain on sfx name.
MOAD-0002 (Intertangle): CLEAN, god objects are idiomatic Quake engine.
MOAD-0003 (Leaked Context): CLEAN, no thread_local usage.
MOAD-0004 (Logged Secret): CLEAN, rcon_password uses CF_PRIVATE flag.
MOAD-0005 (Thundering Herd): CLEAN, single-threaded cache access.
|
2026-03-31 12:43:16 -04:00 |
|
