engineering/java-topology
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

wave17: postgres-0001/asterisk-0001/haproxy-0001/nginx-0001; postfix+bevy CLEAN

Browse source 
postgres-0001: pg_inherits.c typeInheritsFrom() BFS visited List → HTAB O(1)
asterisk-0001: app_queue.c interface_exists() ao2_iterator walk → ao2_find O(1)
haproxy-0001: http_ana.c cookie-server scan linked-list → eb-tree index O(log S)
nginx-0001: ngx_http_link_multi_headers() O(H²) double-scan → O(H) hash pass
postfix: CLEAN (htable throughout; two marginal LOW admin-bounded candidates)
bevy: CLEAN (FixedBitSet/HashSet throughout; only hardware-bounded marginals)
This commit is contained in:
russell@unturf.com 2026-03-30 07:57:30 -04:00
parent da8b4a41d6
commit ff6292d067
10 changed files with 627 additions and 252 deletions
Download patch file Download diff file Expand all files Collapse all files

72
defects/haproxy/patch/haproxy-0001-cookie-srv-ebtree-index.patch Normal file
View file

@ -0,0 +1,72 @@
--- a/include/haproxy/server-t.h
+++ b/include/haproxy/server-t.h
@@ -343,6 +343,7 @@ struct server {
int cklen; /* the len of the cookie, to speed up checks */
unsigned int flags; /* server permanent flags */
char *cookie; /* the id set in the cookie */
+ struct ebpt_node cookie_node; /* eb-tree node keyed by cookie string; used by proxy->cookies_tree */
--- a/include/haproxy/proxy-t.h
+++ b/include/haproxy/proxy-t.h
@@ -364,6 +364,7 @@ struct proxy {
struct server *srv, *defsrv; /* known servers; default server configuration */
+ struct eb_root cookies_tree; /* eb-tree of srv->cookie_node for O(1) cookie lookup; populated after config parse */
--- a/src/server.c
+++ b/src/server.c
@@ -XXX,0 +XXX,12 @@
+/*
+ * Build or rebuild the proxy's cookies_tree index.
+ * Called after srv_set_dyncookie() and after initial config parse.
+ * O(S log S) one-time cost; amortises the O(C×S) per-request cookie scan.
+ */
+void proxy_build_cookie_tree(struct proxy *px)
+{
+ struct server *srv;
+ px->cookies_tree = EB_ROOT_UNIQUE;
+ for (srv = px->srv; srv; srv = srv->next) {
+ if (srv->cookie) {
+ srv->cookie_node.key = srv->cookie;
+ ebis_insert(&px->cookies_tree, &srv->cookie_node);
+ }
+ }
+}
--- a/src/http_ana.c
+++ b/src/http_ana.c
@@ -3514,10 +3514,18 @@ static void http_manage_client_side_cookies(...)
if ((delim == val_beg) || (s->flags & (SF_IGNORE_PRST | SF_ASSIGNED)))
srv = NULL;
- while (srv) {
- if (srv->cookie && (srv->cklen == delim - val_beg) &&
- !memcmp(val_beg, srv->cookie, delim - val_beg)) {
- /* ... */
- }
- srv = srv->next;
- }
+ /* Replace O(S) linked-list walk with O(log S) eb-tree lookup.
+ * proxy_build_cookie_tree() indexes all srv->cookie strings at
+ * config-time; lookup is safe at runtime (cookies are immutable). */
+ if (srv) {
+ char cookie_key[delim - val_beg + 1];
+ memcpy(cookie_key, val_beg, delim - val_beg);
+ cookie_key[delim - val_beg] = '\0';
+
+ struct ebpt_node *node = ebis_lookup(&s->be->cookies_tree, cookie_key);
+ srv = node ? container_of(node, struct server, cookie_node) : NULL;
+ if (srv) {
+ if ((srv->cur_state != SRV_ST_STOPPED) ||
+ (s->be->options & PR_O_PERSIST) ||
+ (s->flags & SF_FORCE_PRST)) {
+ txn->flags &= ~TX_CK_MASK;
+ txn->flags |= (srv->cur_state != SRV_ST_STOPPED) ? TX_CK_VALID : TX_CK_DOWN;
+ s->flags |= SF_DIRECT | SF_ASSIGNED;
+ stream_set_srv_target(s, srv);
+ } else {
+ txn->flags &= ~TX_CK_MASK;
+ txn->flags |= TX_CK_DOWN;
+ srv = NULL;
+ }
+ }
+ }