django/rails/bottle/pyramid: web framework wave complete — 133 sites 52 ecosystems

This commit is contained in:
russell@unturf.com 2026-03-27 12:16:27 -04:00
parent 08989870a6
commit db2986ae44
8 changed files with 376 additions and 8 deletions

View file

@ -0,0 +1,25 @@
Fixes django-0001: Model.from_db() — field_names list membership test inside concrete_fields loop.
--- a/django/db/models/base.py
+++ b/django/db/models/base.py
@@ DEFECT django-0001: Model.from_db() lines 618-624
@classmethod
def from_db(cls, db, field_names, values, *, fetch_mode=None):
if len(values) != len(cls._meta.concrete_fields):
values_iter = iter(values)
+ field_names_set = set(field_names) # FIX django-0001: O(F) once; was O(1) per loop
values = [
- next(values_iter) if f.attname in field_names else DEFERRED # O(F) list scan — CWE-407
+ next(values_iter) if f.attname in field_names_set else DEFERRED # O(1) — fixed
for f in cls._meta.concrete_fields
]
# BEFORE: field_names is a list; `f.attname in field_names` is O(F) per field.
# Called once per queryset row in ModelIterable.__iter__.
# Total for N rows × F fields: O(N × F²).
# AFTER: field_names_set is a frozenset; O(1) per field.
# Total: O(N × F).
# Triggered by: QuerySet.defer(), .only() — the primary Django ORM optimization APIs.
# ~50× speedup for a 50-field model.

View file

@ -0,0 +1,30 @@
Fixes django-0002: Serializer.serialize() — selected_fields list membership tested 3× per field per object.
--- a/django/core/serializers/base.py
+++ b/django/core/serializers/base.py
@@ DEFECT django-0002: Serializer.serialize() lines 102, 130, 136, 143
def serialize(self, queryset, *, stream=None, fields=None, use_natural_foreign_keys=False,
use_natural_primary_keys=False, progress_output=None, object_count=0):
...
- self.selected_fields = fields # raw list — CWE-407
+ self.selected_fields = frozenset(fields) if fields is not None else None # FIX django-0002
for count, obj in enumerate(queryset, start=1): # N objects
...
for field in concrete_model._meta.local_fields: # F fields
if field.serialize or field is pk_parent:
if field.remote_field is None:
if (
self.selected_fields is None
- or field.attname in self.selected_fields # O(S) list scan × 3 — CWE-407
+ or field.attname in self.selected_fields # O(1) frozenset — fixed
):
# BEFORE: selected_fields is a list; 3 × O(S) scans per field per object.
# Total: O(N × F × S) for N objects, F fields, S selected fields.
# AFTER: selected_fields is frozenset; 3 × O(1) per field per object.
# Total: O(N × F).
# Triggered by: dumpdata, loaddata, REST serialization, Django REST Framework compat.
# One-line fix; frozenset supports `in` identically to list.

View file

@ -0,0 +1,48 @@
Fixes django-0003/0004: Model._check_column_name_clashes() list dedup + RawQuerySet.resolve_model_init_order() columns list scans.
--- a/django/db/models/base.py
+++ b/django/db/models/base.py
@@ DEFECT django-0003: Model._check_column_name_clashes() lines 2071-2094
@classmethod
def _check_column_name_clashes(cls):
- used_column_names = [] # list — O(F) scan per field — CWE-407
+ used_column_names = set() # FIX django-0003: O(1) lookup
errors = []
for f in cls._meta.local_fields:
column_name = f.column
- if column_name and column_name in used_column_names: # O(F) scan → O(F²) total
+ if column_name and column_name in used_column_names: # O(1) set → O(F) total — fixed
errors.append(
checks.Error(
"Field '%s' has column name '%s' that is used by another field."
% (f.name, column_name),
)
)
else:
- used_column_names.append(column_name) # preserves duplicates (defeats purpose)
+ used_column_names.add(column_name) # set.add is O(1)
return errors
--- a/django/db/models/query.py
+++ b/django/db/models/query.py
@@ DEFECT django-0004: RawQuerySet.resolve_model_init_order() lines 2375-2395
def resolve_model_init_order(self):
converter = connections[self.db].introspection.identifier_converter
+ columns_set = set(self.columns) # FIX django-0004: O(C) once
+ columns_index = {col: idx for idx, col in enumerate(self.columns)} # O(C) once
model_init_fields = [
field
for column_name, field in self.model_fields.items()
- if column_name in self.columns # O(C) list scan per field — CWE-407
+ if column_name in columns_set # O(1) — fixed
]
...
model_init_order = [
- self.columns.index(converter(f.column)) # O(C) list scan per field — CWE-407
+ columns_index[converter(f.column)] # O(1) dict lookup — fixed
for f in model_init_fields
]