comms/voip/smtp: 30 CWE-407 defects + 9 CLEAN; 224 sites, 101 ecosystems

This commit is contained in:
russell@unturf.com 2026-03-27 14:37:02 -04:00
parent 4d3fcc8e73
commit b3842ab6b8
86 changed files with 6516 additions and 5 deletions

View file

@ -0,0 +1,11 @@
--- a/synapse/handlers/sync.py
+++ b/synapse/handlers/sync.py
@@ -1437,7 +1437,8 @@ class SyncHandler:
if event.membership == Membership.JOIN:
- user_ids_in_room = await self.store.get_users_in_room(room_id)
- if user_id in user_ids_in_room:
+ # CWE-407 fix: get_users_in_room returns Sequence[str] (List); convert to set
+ # for O(1) membership test instead of O(n) linear scan over all room members.
+ user_ids_in_room = frozenset(await self.store.get_users_in_room(room_id))
+ if user_id in user_ids_in_room:
mutable_joined_room_ids.add(room_id)