engineering/java-topology
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

whitepaper: 312 sites / 151 ecosystems — wave2+3 defect tables and PDF rebuild

Browse source 
Add 88 new defect entries to HIGH and MEDIUM tables:
  HIGH: mysql-0001/0002, mariadb-0001, redis-0001/0002, valkey-0001/0002, openvpn-0001,
        vlc-0001, prometheus-0001, otel-collector-0001, cockroachdb-0001..0004,
        tidb-0001..0008, kubernetes-0001/0002, go-0001, kotlin-0002, scala-0001,
        allegro5-0001, sdl2-0001, grafana-0001, clickhouse-0001, duckdb-0001,
        mongodb-0001, envoy-0001, istio-0001, cilium-0001, linkerd2-0001,
        linux-0001/0002/0003, tor-0002/0003, curl-0001, julia-0001, lua-0001,
        perl5-0001, nats-0001, spring-0003/0004, tomcat-0001, onos-0002, odl-0002

  MEDIUM: helm-0001, mariadb-0002, openssl-0001/0002, memcached-0001,
          cassandra-0001..0004, flink-0001, storm-0001/0002, zookeeper-0001..0003,
          pip-0001, gradle-0001, nginx-0001, haproxy-0001, caddy-0001, varnish-0001,
          ffmpeg-0001, gstreamer-0001, raylib-0001, love2d-0001, php-0001/0002,
          r-source-0001, cpython-0002, ruby-0001, rabbitmq-0003/0004, activemq-0001,
          ovs-0001, onos-0003, odl-0002, jetty-0001

PDF: 976K
This commit is contained in:
russell@unturf.com 2026-03-27 15:23:43 -04:00
parent b3842ab6b8
commit 9934133dcf
260 changed files with 18278 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

93
defects/activemq/unit/ActiveMQTest.java Normal file
View file

@ -0,0 +1,93 @@
package unit;
import java.util.*;
import java.util.concurrent.*;
/**
* ActiveMQTest — CWE-407 benchmark for activemq-0001
*
* Models Topic.addSubscription() O(N²) CopyOnWriteArrayList.contains()
* duplicate check vs. O(1) parallel-Set guard.
*
* Real code (activemq-broker/.../region/Topic.java:151,167,293):
* synchronized (consumers) {
* if (!consumers.contains(sub)) { // O(N) CopyOnWriteArrayList scan
* consumers.add(sub);
* }
* }
*
* Fix: parallel Set<Subscription> from ConcurrentHashMap.newKeySet() for O(1) add.
*/
public class ActiveMQTest {
static void bench(String label, Runnable slow, Runnable fast, long sOps, long fOps) {
slow.run(); fast.run();
long t0 = System.nanoTime(); slow.run(); long sMs = (System.nanoTime() - t0) / 1_000_000;
long t1 = System.nanoTime(); fast.run(); long fMs = (System.nanoTime() - t1) / 1_000_000;
double speedup = fMs > 0 ? (double) sMs / fMs : 0;
System.out.printf(" %-54s slow:%4dms (%,d ops) fast:%4dms (%,d ops) speedup:%.0fx%n",
label, sMs, sOps, fMs, fOps, speedup);
}
// ---------- slow: ArrayList contains scan (the defect) ----------
/** Returns total membership-test comparisons performed */
static long slowSubscribe(int N) {
List<Integer> consumers = new ArrayList<>();
long ops = 0;
for (int sub = 0; sub < N; sub++) {
// simulate contains(): walk every existing entry
boolean found = false;
for (int i = 0; i < consumers.size(); i++) {
ops++;
if (consumers.get(i).equals(sub)) { found = true; break; }
}
if (!found) consumers.add(sub);
}
return ops;
}
// ---------- fast: Set.add() O(1) guard (the fix) ----------
/** Returns total membership-test operations (O(1) each) */
static long fastSubscribe(int N) {
Set<Integer> consumerSet = new HashSet<>(N * 2);
List<Integer> consumers = new ArrayList<>();
long ops = 0;
for (int sub = 0; sub < N; sub++) {
ops++; // O(1) set probe
if (consumerSet.add(sub)) consumers.add(sub);
}
return ops;
}
public static void main(String[] args) {
System.out.println("ActiveMQTest — activemq-0001: Topic.addSubscription() CopyOnWriteArrayList → Set guard");
System.out.println();
int[][] cases = {{100, 5000}, {500, 2000}, {1000, 1000}};
System.out.println(" [Topic.addSubscription duplicate guard — consumers CopyOnWriteArrayList.contains()]");
for (int[] c : cases) {
int N = c[0], R = c[1];
bench(
String.format("N=%d subscribers, %d subscribe() calls", N, R),
() -> { for (int i = 0; i < R; i++) slowSubscribe(N); },
() -> { for (int i = 0; i < R; i++) fastSubscribe(N); },
(long) N * (N - 1) / 2 * R,
(long) N * R
);
}
System.out.println();
System.out.println("Defect : activemq-broker/.../region/Topic.java:151,167,293 — consumers.contains(sub) CopyOnWriteArrayList O(n)");
System.out.println("Fix : parallel ConcurrentHashMap.newKeySet() guard — O(1) add/contains");
System.out.println("Ticket : activemq-0001-topic-consumers-copyonwrite-contains-quadratic.md");
System.out.println();
int pass = 0;
long s0 = slowSubscribe(500), f0 = fastSubscribe(500);
assert s0 > f0 * 50 : "activemq-0001 expected >50x; slow=" + s0 + " fast=" + f0; pass++;
System.out.printf("%d/1 PASS — activemq-0001: CWE-407 in ActiveMQ Topic subscriber dedup%n", pass);
System.out.printf("Hotpath: every new subscriber on a busy topic (fan-out bus workloads)%n");
}
}