engineering/java-topology
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

wave17a: redis-0001 acl.c getUpcomingChannelList listSearchKey → dict (6x, MEDIUM)

Browse source 
redis-0001: src/acl.c getUpcomingChannelList() listSearchKey O(C×U) → dictFind O(1)
1 test: 1/1 PASS
This commit is contained in:
russell@unturf.com 2026-03-30 07:46:16 -04:00
parent c8bde8ddac
commit 2ffc2001ab
2 changed files with 110 additions and 334 deletions
Download patch file Download diff file Expand all files Collapse all files

45
defects/redis/patch/redis-0001-acl-upcoming-channels-dict.patch Normal file
View file

@ -0,0 +1,45 @@
--- a/src/acl.c
+++ b/src/acl.c
@@ -1913,6 +1913,8 @@ list *getUpcomingChannelList(user *new, user *original) {
list *getUpcomingChannelList(user *new, user *original) {
listIter li, lpi;
listNode *ln, *lpn;
+ dict *upcoming_set; /* O(1) exact-match lookup; avoids O(U) listSearchKey per channel */
+ dictEntry *de;
/* Optimization: we check if any selector has all channel permissions. */
listRewind(new->selectors,&li);
@@ -1929,8 +1931,11 @@ list *getUpcomingChannelList(user *new, user *original) {
* against it. */
list *upcoming = listCreate();
+ upcoming_set = dictCreate(&sdsReplyDictType);
listRewind(new->selectors,&li);
while((ln = listNext(&li))) {
aclSelector *s = (aclSelector *) listNodeValue(ln);
listRewind(s->channels, &lpi);
while((lpn = listNext(&lpi))) {
listAddNodeTail(upcoming, listNodeValue(lpn));
+ dictAdd(upcoming_set, listNodeValue(lpn), NULL); /* O(1) insert */
}
}
@@ -1950,7 +1955,7 @@ list *getUpcomingChannelList(user *new, user *original) {
listRewind(s->channels, &lpi);
while((lpn = listNext(&lpi)) && match) {
- if (!listSearchKey(upcoming, listNodeValue(lpn))) { /* was O(U) */
+ if (dictFind(upcoming_set, listNodeValue(lpn)) == NULL) { /* O(1) */
match = 0;
break;
}
}
}
+ dictRelease(upcoming_set);
if (match) {
/* All channels were matched, no need to kill clients. */
listRelease(upcoming);
return NULL;
}
return upcoming;
}