engineering/java-topology
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

undefect. CWE-407 — 63 sites patched across 27 ecosystems

Browse source 
Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com

Patches, unit tests, benchmarks, whitepaper, and outreach briefs.
Public domain — no copyright claimed. Use freely.
This commit is contained in:
russell@unturf.com 2026-03-26 17:11:57 -04:00
commit 0a580b313d
70422 changed files with 17213626 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

172
test/langtools/jdk/jshell/ModifiersTest.java Normal file
View file

@ -0,0 +1,172 @@
/*
* Copyright (c) 2015, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test 8167643 8129559 8247456
* @summary Tests for modifiers
* @build KullaTesting TestingInputStream ExpectedDiagnostic
* @run junit ModifiersTest
*/
import java.util.ArrayList;
import java.util.List;
import java.util.function.Consumer;
import javax.tools.Diagnostic;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.TestInstance;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.MethodSource;
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
public class ModifiersTest extends KullaTesting {
public Object[][] getTestCases() {
List<Object[]> testCases = new ArrayList<>();
String[] ignoredModifiers = new String[] {
};
String[] silentlyIgnoredModifiers = new String[] {
"public", "protected", "private", "static"
};
String[] before = new String[] {
"strictfp", "abstract", "final", "@X", "@X(value=9)"
};
String context = "@interface X { int value() default 0; }";
Consumer<String> eval = this::assertEval;
Consumer<String> evalWarn = s -> assertDeclareWarn1(s, "jdk.eval.warn.illegal.modifiers");
for (String ignoredModifier : ignoredModifiers) {
for (ClassType classType : ClassType.values()) {
testCases.add(new Object[] { ignoredModifier, classType, evalWarn, "", null });
}
}
for (String ignoredModifier : ignoredModifiers) {
for (String preface : before) {
testCases.add(new Object[] { ignoredModifier, ClassType.CLASS, evalWarn, preface, context});
}
}
for (String ignoredModifier : silentlyIgnoredModifiers) {
for (ClassType classType : ClassType.values()) {
testCases.add(new Object[] { ignoredModifier, classType, eval, "", null });
}
}
for (String ignoredModifier : silentlyIgnoredModifiers) {
for (String preface : before) {
testCases.add(new Object[] { ignoredModifier, ClassType.CLASS, eval, preface, context});
}
}
return testCases.toArray(new Object[testCases.size()][]);
}
@ParameterizedTest
@MethodSource("getTestCases")
public void ignoredModifiers(String modifier, ClassType classType,
Consumer<String> eval, String preface, String context) {
if (context != null) {
assertEval(context);
}
String decl = String.format("%s %s %s A {}", preface, modifier, classType);
eval.accept(decl);
if (context != null) {
assertNumberOfActiveClasses(2);
assertClasses(clazz(ClassType.ANNOTATION, "X"), clazz(classType, "A"));
} else {
assertNumberOfActiveClasses(1);
assertClasses(clazz(classType, "A"));
}
assertActiveKeys();
}
@Test
public void accessToStaticFieldsOfClass() {
assertEval("class A {" +
"int x = 14;" +
"static int y = 18;" +
" }");
assertDeclareFail("A.x;",
new ExpectedDiagnostic("compiler.err.non-static.cant.be.ref", 0, 3, 1, -1, -1, Diagnostic.Kind.ERROR));
assertEval("A.y;", "18");
assertEval("new A().x;", "14");
assertEval("A.y = 88;", "88");
assertActiveKeys();
}
@Test
public void accessToStaticMethodsOfClass() {
assertEval("class A {" +
"void x() {}" +
"static void y() {}" +
" }");
assertDeclareFail("A.x();",
new ExpectedDiagnostic("compiler.err.non-static.cant.be.ref", 0, 3, 1, -1, -1, Diagnostic.Kind.ERROR));
assertEval("A.y();");
assertActiveKeys();
}
@Test
public void accessToStaticFieldsOfInterface() {
assertEval("interface A {" +
"int x = 14;" +
"static int y = 18;" +
" }");
assertEval("A.x;", "14");
assertEval("A.y;", "18");
assertDeclareFail("A.x = 18;",
new ExpectedDiagnostic("compiler.err.cant.assign.val.to.var", 0, 3, 1, -1, -1, Diagnostic.Kind.ERROR));
assertDeclareFail("A.y = 88;",
new ExpectedDiagnostic("compiler.err.cant.assign.val.to.var", 0, 3, 1, -1, -1, Diagnostic.Kind.ERROR));
assertActiveKeys();
}
@Test
public void accessToStaticMethodsOfInterface() {
assertEval("interface A { static void x() {} }");
assertEval("A.x();");
assertActiveKeys();
}
@Test
public void finalMethod() {
assertEval("class A { final void f() {} }");
assertDeclareFail("class B extends A { void f() {} }",
new ExpectedDiagnostic("compiler.err.override.meth", 20, 31, 25, -1, -1, Diagnostic.Kind.ERROR));
assertActiveKeys();
}
//TODO: is this the right semantics?
@Test
public void finalConstructor() {
assertDeclareFail("class A { final A() {} }",
new ExpectedDiagnostic("compiler.err.mod.not.allowed.here", 10, 22, 16, -1, -1, Diagnostic.Kind.ERROR));
assertActiveKeys();
}
//TODO: is this the right semantics?
@Test
public void finalDefaultMethod() {
assertDeclareFail("interface A { final default void a() {} }",
new ExpectedDiagnostic("compiler.err.mod.not.allowed.here", 14, 39, 33, -1, -1, Diagnostic.Kind.ERROR));
assertActiveKeys();
}
}