undefect. CWE-407 — 63 sites patched across 27 ecosystems

Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com

Patches, unit tests, benchmarks, whitepaper, and outreach briefs.
Public domain — no copyright claimed. Use freely.

test/langtools/jdk/jshell/JShellStateClosedTest.java

@@ -0,0 +1,148 @@
+/*
+ * Copyright (c) 2015, 2025, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test 8164277
+ * @summary Testing IllegalStateException.
+ * @build KullaTesting TestingInputStream JShellStateClosedTest
+ * @run junit JShellStateClosedTest
+ */
+
+import java.util.function.Consumer;
+
+import jdk.jshell.DeclarationSnippet;
+import jdk.jshell.ImportSnippet;
+import jdk.jshell.MethodSnippet;
+import jdk.jshell.Snippet;
+import jdk.jshell.TypeDeclSnippet;
+import jdk.jshell.VarSnippet;
+import static org.junit.jupiter.api.Assertions.fail;
+import org.junit.jupiter.api.Test;
+
+public class JShellStateClosedTest extends KullaTesting {
+
+    private void testStateClosedException(Runnable action) {
+        getState().close();
+        try {
+            action.run();
+            fail("Exception expected");
+        } catch (IllegalStateException e) {
+            // Expected
+        }
+    }
+
+    @Test
+    public void testClasses() {
+        TypeDeclSnippet sc = classKey(assertEval("class C { }"));
+        TypeDeclSnippet si = classKey(assertEval("interface I { }"));
+        getState().close();
+        assertStreamMatch(getState().types(), sc, si);
+    }
+
+    @Test
+    public void testVariables() {
+        VarSnippet sx = varKey(assertEval("int x = 5;"));
+        VarSnippet sfoo = varKey(assertEval("String foo;"));
+        getState().close();
+        assertStreamMatch(getState().variables(), sx, sfoo);
+    }
+
+    @Test
+    public void testMethods() {
+        MethodSnippet smm = methodKey(assertEval("int mm() { return 6; }"));
+        MethodSnippet svv = methodKey(assertEval("void vv() { }"));
+        getState().close();
+        assertStreamMatch(getState().methods(), smm, svv);
+    }
+
+    @Test
+    public void testImports() {
+        ImportSnippet simp = importKey(assertEval("import java.lang.reflect.*;"));
+        getState().close();
+        assertStreamMatch(getState().imports(), simp);
+    }
+
+    @Test
+    public void testSnippets() {
+        VarSnippet sx = varKey(assertEval("int x = 5;"));
+        VarSnippet sfoo = varKey(assertEval("String foo;"));
+        MethodSnippet smm = methodKey(assertEval("int mm() { return 6; }"));
+        MethodSnippet svv = methodKey(assertEval("void vv() { }"));
+        TypeDeclSnippet sc = classKey(assertEval("class C { }"));
+        TypeDeclSnippet si = classKey(assertEval("interface I { }"));
+        ImportSnippet simp = importKey(assertEval("import java.lang.reflect.*;"));
+        getState().close();
+        assertStreamMatch(getState().snippets(), sx, sfoo, smm, svv, sc, si, simp);
+    }
+
+    @Test
+    public void testEval() {
+        testStateClosedException(() -> getState().eval("int a;"));
+    }
+
+    private void testStateClosedException(Consumer<Snippet> action) {
+        Snippet k = varKey(assertEval("int a;"));
+        getState().close();
+        try {
+            action.accept(k);
+            fail("IllegalStateException expected since closed");
+        } catch (IllegalStateException e) {
+            // Expected
+        }
+    }
+
+    private void testStateClosedWithoutException(Consumer<Snippet> action) {
+        Snippet k = varKey(assertEval("int a;"));
+        getState().close();
+        try {
+            action.accept(k);
+        } catch (IllegalStateException e) {
+            fail("Expected no IllegalStateException even though closed");
+        }
+    }
+
+    @Test
+    public void testStatus() {
+        testStateClosedWithoutException((key) -> getState().status(key));
+    }
+
+    @Test
+    public void testVarValue() {
+        testStateClosedException((key) -> getState().varValue((VarSnippet) key));
+    }
+
+    @Test
+    public void testDrop() {
+        testStateClosedException((key) -> getState().drop(key));
+    }
+
+    @Test
+    public void testUnresolved() {
+        testStateClosedWithoutException((key) -> getState().unresolvedDependencies((DeclarationSnippet) key));
+    }
+
+    @Test
+    public void testDiagnostics() {
+        testStateClosedWithoutException((key) -> getState().diagnostics(key));
+    }
+}