undefect. CWE-407 — 63 sites patched across 27 ecosystems

Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com

Patches, unit tests, benchmarks, whitepaper, and outreach briefs.
Public domain — no copyright claimed. Use freely.

test/jdk/sun/security/ssl/SSLSocketImpl/SetClientMode.java

@@ -0,0 +1,130 @@
+/*
+ * Copyright (c) 2005, 2025, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+// SunJSSE does not support dynamic system properties, no way to re-use
+// system properties in samevm/agentvm mode.
+
+/*
+ * @test
+ * @bug 6223624
+ * @library /test/lib /javax/net/ssl/templates
+ * @summary SSLSocket.setUseClientMode() fails to throw expected
+ *        IllegalArgumentException
+ * @run main/othervm SetClientMode TLSv1
+ * @run main/othervm SetClientMode TLSv1.1
+ * @run main/othervm SetClientMode TLSv1.2
+ * @run main/othervm SetClientMode TLSv1.3
+ */
+
+/*
+ * Attempts to replicate a TCK test failure which creates SSLServerSockets
+ * and then runs client threads which connect and start handshaking. Once
+ * handshaking is begun the server side attempts to invoke
+ * SSLSocket.setUseClientMode() on one or the other of the ends of the
+ * connection, expecting an IllegalArgumentException.
+ *
+ * If the server side of the connection tries setUseClientMode() we
+ * see the expected exception. If the setting is tried on the
+ * client side SSLSocket, we do *not* see the exception, except
+ * occasionally on the very first iteration.
+ */
+
+import java.lang.*;
+import java.net.*;
+import java.util.concurrent.CountDownLatch;
+import javax.net.ssl.*;
+import jdk.test.lib.security.SecurityUtils;
+
+import static jdk.test.lib.Asserts.assertThrows;
+
+public class SetClientMode extends SSLContextTemplate {
+    private volatile int serverPort = 0;
+    private static final CountDownLatch HANDSHAKE_COMPLETE = new CountDownLatch(1);
+
+    public static void main(String[] args) throws Exception {
+        String protocol = args[0];
+
+        if ("TLSv1".equals(protocol) || "TLSv1.1".equals(protocol)) {
+            SecurityUtils.removeFromDisabledTlsAlgs(protocol);
+        }
+
+        new SetClientMode().run(protocol);
+    }
+
+    public void run(String protocol) throws Exception {
+        // Create a server socket
+        SSLServerSocketFactory ssf = createServerSSLContext().getServerSocketFactory();
+
+        try (SSLServerSocket serverSocket =
+                (SSLServerSocket) ssf.createServerSocket(serverPort)) {
+            serverSocket.setEnabledProtocols(new String[]{ protocol });
+            serverPort = serverSocket.getLocalPort();
+
+            // Create a client socket
+            SSLSocketFactory sf = createClientSSLContext().getSocketFactory();
+
+            try (SSLSocket clientSocket = (SSLSocket) sf.createSocket(
+                    InetAddress.getLocalHost(),
+                    serverPort)) {
+
+                // Create a client which will use the SSLSocket to talk to the server
+                Client client = new Client(clientSocket);
+
+                // Start the client and then accept any connection
+                client.start();
+
+                SSLSocket connectedSocket = (SSLSocket) serverSocket.accept();
+
+                // force handshaking to complete
+                connectedSocket.getSession();
+
+                HANDSHAKE_COMPLETE.await();
+
+                // Now try invoking setClientMode() on the client socket.
+                // We expect to see an IllegalArgumentException because
+                // handshaking has begun.
+                assertThrows(IllegalArgumentException.class,
+                        () -> clientSocket.setUseClientMode(false));
+            }
+        }
+    }
+
+    // A thread-based client which does nothing except
+    // start handshaking on the socket it's given.
+    static class Client extends Thread {
+        private final SSLSocket socket;
+
+        public Client(SSLSocket s) {
+            socket = s;
+        }
+
+        public void run() {
+            try {
+                socket.startHandshake();
+                HANDSHAKE_COMPLETE.countDown();
+            } catch (Exception e) {
+                e.printStackTrace();
+            }
+        }
+    }
+}