undefect. CWE-407 — 63 sites patched across 27 ecosystems
Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com Patches, unit tests, benchmarks, whitepaper, and outreach briefs. Public domain — no copyright claimed. Use freely.
This commit is contained in:
commit
0a580b313d
70422 changed files with 17213626 additions and 0 deletions
103
test/jdk/java/util/zip/ZipFile/MultiThreadedReadTest.java
Normal file
103
test/jdk/java/util/zip/ZipFile/MultiThreadedReadTest.java
Normal file
|
|
@ -0,0 +1,103 @@
|
|||
/*
|
||||
* Copyright (c) 2014, 2019, Oracle and/or its affiliates. All rights reserved.
|
||||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
|
||||
*
|
||||
* This code is free software; you can redistribute it and/or modify it
|
||||
* under the terms of the GNU General Public License version 2 only, as
|
||||
* published by the Free Software Foundation.
|
||||
*
|
||||
* This code is distributed in the hope that it will be useful, but WITHOUT
|
||||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
||||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
||||
* version 2 for more details (a copy is included in the LICENSE file that
|
||||
* accompanied this code).
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License version
|
||||
* 2 along with this work; if not, write to the Free Software Foundation,
|
||||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
|
||||
*
|
||||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
|
||||
* or visit www.oracle.com if you need additional information or have any
|
||||
* questions.
|
||||
*/
|
||||
|
||||
/* @test
|
||||
* @bug 8038491
|
||||
* @summary Crash in ZipFile.read() when ZipFileInputStream is shared between threads
|
||||
* @library /test/lib
|
||||
* @build jdk.test.lib.Platform
|
||||
* jdk.test.lib.util.FileUtils
|
||||
* @run main MultiThreadedReadTest
|
||||
*/
|
||||
|
||||
import java.io.BufferedOutputStream;
|
||||
import java.io.File;
|
||||
import java.io.FileOutputStream;
|
||||
import java.io.InputStream;
|
||||
import java.nio.file.Paths;
|
||||
import java.util.zip.CRC32;
|
||||
import java.util.zip.ZipEntry;
|
||||
import java.util.zip.ZipFile;
|
||||
import java.util.zip.ZipOutputStream;
|
||||
import jdk.test.lib.util.FileUtils;
|
||||
|
||||
public class MultiThreadedReadTest extends Thread {
|
||||
|
||||
private static final int NUM_THREADS = 10;
|
||||
private static final String ZIPFILE_NAME =
|
||||
System.currentTimeMillis() + "-bug8038491-tmp.large.zip";
|
||||
private static final String ZIPENTRY_NAME = "random.txt";
|
||||
private static InputStream is = null;
|
||||
|
||||
public static void main(String args[]) throws Exception {
|
||||
createZipFile();
|
||||
try (ZipFile zf = new ZipFile(new File(ZIPFILE_NAME))) {
|
||||
is = zf.getInputStream(zf.getEntry(ZIPENTRY_NAME));
|
||||
Thread[] threadArray = new Thread[NUM_THREADS];
|
||||
for (int i = 0; i < threadArray.length; i++) {
|
||||
threadArray[i] = new MultiThreadedReadTest();
|
||||
}
|
||||
for (int i = 0; i < threadArray.length; i++) {
|
||||
threadArray[i].start();
|
||||
}
|
||||
for (int i = 0; i < threadArray.length; i++) {
|
||||
threadArray[i].join();
|
||||
}
|
||||
} finally {
|
||||
long t = System.currentTimeMillis();
|
||||
FileUtils.deleteFileIfExistsWithRetry(Paths.get(ZIPFILE_NAME));
|
||||
System.out.println("Deleting zip file took:" +
|
||||
(System.currentTimeMillis() - t) + "ms");
|
||||
}
|
||||
}
|
||||
|
||||
private static void createZipFile() throws Exception {
|
||||
CRC32 crc32 = new CRC32();
|
||||
long t = System.currentTimeMillis();
|
||||
File zipFile = new File(ZIPFILE_NAME);
|
||||
try (FileOutputStream fos = new FileOutputStream(zipFile);
|
||||
BufferedOutputStream bos = new BufferedOutputStream(fos);
|
||||
ZipOutputStream zos = new ZipOutputStream(bos)) {
|
||||
ZipEntry e = new ZipEntry(ZIPENTRY_NAME);
|
||||
e.setMethod(ZipEntry.STORED);
|
||||
byte[] toWrite = "BLAH".repeat(10_000).getBytes();
|
||||
e.setTime(t);
|
||||
e.setSize(toWrite.length);
|
||||
crc32.reset();
|
||||
crc32.update(toWrite);
|
||||
e.setCrc(crc32.getValue());
|
||||
zos.putNextEntry(e);
|
||||
zos.write(toWrite);
|
||||
}
|
||||
}
|
||||
|
||||
@Override
|
||||
public void run() {
|
||||
try {
|
||||
while (is.read() != -1) { }
|
||||
} catch (Exception e) {
|
||||
System.out.println("read exception:" + e);
|
||||
// Swallow any Exceptions (which are expected) - we're only interested in the crash
|
||||
}
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue