undefect. CWE-407 — 63 sites patched across 27 ecosystems

Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com

Patches, unit tests, benchmarks, whitepaper, and outreach briefs.
Public domain — no copyright claimed. Use freely.

test/jdk/java/text/Format/NumberFormat/Bug6278616.java

@@ -0,0 +1,78 @@
+/*
+ * Copyright (c) 2005, 2023, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @summary Confirm that AtomicInteger and AtomicLong are formatted correctly.
+ *          That is, make sure they are not treated as a double when formatted
+ *          anymore (which can result in the loss of precision).
+ * @bug 6278616
+ * @run junit Bug6278616
+ */
+
+import java.text.NumberFormat;
+import java.util.concurrent.atomic.AtomicInteger;
+import java.util.concurrent.atomic.AtomicLong;
+
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class Bug6278616 {
+
+    private static final NumberFormat nf = NumberFormat.getInstance();
+
+    // Test that NumberFormat formats numerically equivalent int
+    // and AtomicInteger values the same
+    @ParameterizedTest
+    @MethodSource("ints")
+    public void formattedAtomicIntTest(int testInt) {
+        String formattedInt = nf.format(testInt);
+        String formattedAtomicInt = nf.format(new AtomicInteger(testInt));
+        assertEquals(formattedAtomicInt, formattedInt, "Formatting numerically" +
+                " equivalent AtomicInteger and int should produce the same String value");
+    }
+
+    // Various int values
+    private static int[] ints() {
+        return new int[] { Integer.MIN_VALUE, -1, 0, 1, Integer.MAX_VALUE};
+    }
+
+    // Test that NumberFormat formats numerically equivalent long
+    // and AtomicLong values the same
+    @ParameterizedTest
+    @MethodSource("longs")
+    public void formattedAtomicLongTest(long testLong) {
+        String formattedLong = nf.format(testLong);
+        String formattedAtomicLong = nf.format(new AtomicLong(testLong));
+        assertEquals(formattedAtomicLong, formattedLong, "Formatting numerically" +
+                " equivalent AtomicLong and long should produce the same String value");
+    }
+
+    // Various long values
+    private static long[] longs() {
+        return new long[] { Long.MIN_VALUE, -1, 0, 1, Long.MAX_VALUE};
+    }
+}