undefect. CWE-407 — 63 sites patched across 27 ecosystems

Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com

Patches, unit tests, benchmarks, whitepaper, and outreach briefs.
Public domain — no copyright claimed. Use freely.

test/jdk/java/security/AccessController/PreserveCombiner.java

@@ -0,0 +1,109 @@
+/*
+ * Copyright (c) 2005, 2021, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 4819194
+ * @summary doPrivileged should preserve DomainCombiner
+ */
+
+import java.security.*;
+import java.util.concurrent.Callable;
+import javax.security.auth.Subject;
+import javax.security.auth.x500.X500Principal;
+
+public class PreserveCombiner {
+
+    public static void main(String[] args) throws Exception {
+
+        Subject s = new Subject();
+        s.getPrincipals().add(new X500Principal("cn=duke"));
+
+        String result = Subject.callAs(s, new Callable<String>() {
+            public String call() {
+
+                // get subject from current ACC - this always worked
+                Subject callAsSubject = Subject.current();
+                if (callAsSubject == null) {
+                    return "test 1 failed";
+                } else {
+                    System.out.println(callAsSubject);
+                    System.out.println("test 1 passed");
+                }
+
+                // try doPriv (PrivilegedAction) test
+                String result = AccessController.doPrivilegedWithCombiner
+                    (new PrivilegedAction<String>() {
+                    public String run() {
+                        // get subject after doPriv
+                        Subject doPrivSubject = Subject.current();
+                        if (doPrivSubject == null) {
+                            return "test 2 failed";
+                        } else {
+                            System.out.println(doPrivSubject);
+                            return "test 2 passed";
+                        }
+                    }
+                });
+
+                if ("test 2 failed".equals(result)) {
+                    return result;
+                } else {
+                    System.out.println(result);
+                }
+
+                // try doPriv (PrivilegedExceptionAction) test
+                try {
+                    result = AccessController.doPrivilegedWithCombiner
+                        (new PrivilegedExceptionAction<String>() {
+                        public String run() throws PrivilegedActionException {
+                            // get subject after doPriv
+                            Subject doPrivSubject = Subject.current();
+                            if (doPrivSubject == null) {
+                                return "test 3 failed";
+                            } else {
+                                System.out.println(doPrivSubject);
+                                return "test 3 passed";
+                            }
+                        }
+                    });
+                } catch (PrivilegedActionException pae) {
+                    result = "test 3 failed";
+                }
+
+                if ("test 3 failed".equals(result)) {
+                    return result;
+                } else {
+                    System.out.println(result);
+                }
+
+                // tests passed
+                return result;
+            }
+        });
+
+        if (result.indexOf("passed") <= 0) {
+            throw new SecurityException("overall test failed");
+        }
+    }
+}