undefect. CWE-407 — 63 sites patched across 27 ecosystems

Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com

Patches, unit tests, benchmarks, whitepaper, and outreach briefs.
Public domain — no copyright claimed. Use freely.

test/jdk/java/rmi/server/clientStackTrace/ClientStackTrace.java

@@ -0,0 +1,121 @@
+/*
+ * Copyright (c) 1998, 2024, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/* @test
+ * @bug 4010355
+ * @summary RemoteException should have server's stack trace
+ *
+ * @author Laird Dornin
+ *
+ * @library ../../testlibrary
+ * @modules java.rmi/sun.rmi.registry
+ *          java.rmi/sun.rmi.server
+ *          java.rmi/sun.rmi.transport
+ *          java.rmi/sun.rmi.transport.tcp
+ * @build TestLibrary ClientStackTrace MyRemoteObject_Stub
+ * @run main/othervm/timeout=120 ClientStackTrace
+ */
+
+/*
+ * This test ensures that the stack trace in a caught server side
+ * remote exception contains the string "exceptionReceivedFromServer".
+ */
+
+import java.rmi.*;
+import java.rmi.server.*;
+import sun.rmi.transport.StreamRemoteCall;
+import java.io.ByteArrayOutputStream;
+import java.io.PrintStream;
+
+interface MyRemoteInterface extends Remote {
+    void ping() throws RemoteException;
+}
+
+class MyRemoteObject extends UnicastRemoteObject
+    implements MyRemoteInterface {
+
+    public MyRemoteObject () throws RemoteException {}
+
+    public void ping () throws RemoteException {
+        throw new RemoteException("This is a test remote exception");
+    }
+}
+
+public class ClientStackTrace {
+    Object dummy = new Object();
+
+    public static void main(String[] args) {
+        Object dummy = new Object();
+        MyRemoteObject myRobj = null;
+        MyRemoteInterface myStub = null;
+
+        try {
+            ByteArrayOutputStream bos = new ByteArrayOutputStream();
+            PrintStream ps = new PrintStream(bos);
+
+            System.err.println("\nRegression test for bug 4010355\n");
+
+            myRobj = new MyRemoteObject();
+
+            /* cause a remote exception to occur. */
+            try {
+                myStub = (MyRemoteInterface) RemoteObject.toStub(myRobj);
+                myStub.ping();
+
+            } catch (RemoteException re) {
+                re.printStackTrace(ps);
+                String trace = bos.toString();
+
+                if (trace.indexOf("exceptionReceivedFromServer") <0 ) {
+                    throw new RuntimeException("No client stack trace on " +
+                                               "thrown remote exception");
+                } else {
+                    System.err.println("test passed with stack trace: " +
+                                       trace);
+                }
+            }
+
+            deactivate(myRobj);
+
+        } catch (Exception e) {
+            e.printStackTrace();
+            System.err.println("test failed");
+            throw new RuntimeException(e.getMessage());
+        } finally {
+            myRobj = null;
+            myStub = null;
+        }
+    }
+
+    // make sure that the remote object goes away.
+    static void deactivate(RemoteServer r) {
+        // make sure that the object goes away
+        try {
+            System.err.println("deactivating object.");
+            UnicastRemoteObject.unexportObject(r, true);
+        } catch (Exception e) {
+            e.getMessage();
+            e.printStackTrace();
+        }
+    }
+}

test/jdk/java/rmi/server/clientStackTrace/MyRemoteObject_Stub.java

@@ -0,0 +1,88 @@
+/*
+ * Copyright (c) 1998, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+// Stub class generated by rmic, do not edit.
+// Contents subject to change without notice.
+
+public final class MyRemoteObject_Stub
+    extends java.rmi.server.RemoteStub
+    implements MyRemoteInterface, java.rmi.Remote
+{
+    private static java.rmi.server.Operation[] operations = {
+        new java.rmi.server.Operation("void ping()")
+    };
+
+    private static final long interfaceHash = -8409781791984809394L;
+
+    private static final long serialVersionUID = 2;
+
+    private static boolean useNewInvoke;
+    private static java.lang.reflect.Method $method_ping_0;
+
+    static {
+        try {
+            java.rmi.server.RemoteRef.class.getMethod("invoke",
+                new java.lang.Class[] {
+                    java.rmi.Remote.class,
+                    java.lang.reflect.Method.class,
+                    java.lang.Object[].class,
+                    long.class
+                });
+            useNewInvoke = true;
+            $method_ping_0 = MyRemoteInterface.class.getMethod("ping", new java.lang.Class[] {});
+        } catch (java.lang.NoSuchMethodException e) {
+            useNewInvoke = false;
+        }
+    }
+
+    // constructors
+    public MyRemoteObject_Stub() {
+        super();
+    }
+    public MyRemoteObject_Stub(java.rmi.server.RemoteRef ref) {
+        super(ref);
+    }
+
+    // methods from remote interfaces
+
+    // implementation of ping()
+    public void ping()
+        throws java.rmi.RemoteException
+    {
+        try {
+            if (useNewInvoke) {
+                ref.invoke(this, $method_ping_0, null, 5866401369815527589L);
+            } else {
+                java.rmi.server.RemoteCall call = ref.newCall((java.rmi.server.RemoteObject) this, operations, 0, interfaceHash);
+                ref.invoke(call);
+                ref.done(call);
+            }
+        } catch (java.lang.RuntimeException e) {
+            throw e;
+        } catch (java.rmi.RemoteException e) {
+            throw e;
+        } catch (java.lang.Exception e) {
+            throw new java.rmi.UnexpectedException("undeclared checked exception", e);
+        }
+    }
+}