undefect. CWE-407 — 63 sites patched across 27 ecosystems

Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com

Patches, unit tests, benchmarks, whitepaper, and outreach briefs.
Public domain — no copyright claimed. Use freely.

test/jdk/java/nio/channels/SocketChannel/SocketInheritance.java

@@ -0,0 +1,150 @@
+/*
+ * Copyright (c) 2007, 2025, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @summary Sockets shouldn't be inherited when creating a child process
+ * @requires (os.family == "windows")
+ */
+import java.nio.ByteBuffer;
+import java.nio.channels.*;
+import java.net.*;
+import java.io.*;
+
+public class SocketInheritance {
+
+    /*
+     * Simple helper class to direct process output to the parent
+     * System.out
+     */
+    static class IOHandler implements Runnable {
+        InputStream in;
+
+        IOHandler(InputStream in) {
+            this.in = in;
+        }
+
+        static void handle(InputStream in) {
+            IOHandler handler = new IOHandler(in);
+            Thread thr = new Thread(handler);
+            thr.setDaemon(true);
+            thr.start();
+        }
+
+        public void run() {
+            try {
+                byte b[] = new byte[100];
+                for (;;) {
+                    int n = in.read(b);
+                    if (n < 0) return;
+                    System.out.write(b, 0, n);
+                }
+            } catch (IOException ioe) { }
+        }
+
+    }
+
+    // connect to the given port
+    static SocketChannel connect(int port) throws IOException {
+        InetAddress lh = InetAddress.getLoopbackAddress();
+        InetSocketAddress isa = new InetSocketAddress(lh, port);
+        return SocketChannel.open(isa);
+    }
+
+    // simple child process that handshakes with the parent and then
+    // waits indefinitely until it is destroyed
+    static void child(int port) {
+        try {
+            connect(port).close();
+        } catch (IOException x) {
+            x.printStackTrace();
+            return;
+        }
+
+        for (;;) {
+            try {
+                Thread.sleep(10*1000);
+            } catch (InterruptedException x) { }
+        }
+    }
+
+
+    // Creates a loopback connection.
+    // Forks process which should not inherit the sockets.
+    // Close the sockets, and attempt to re-bind the listener.
+
+    static void start() throws Exception {
+
+        // setup loopback connection
+        ServerSocketChannel ssc = ServerSocketChannel.open();
+        ssc.socket().bind( new InetSocketAddress(0) );
+
+        int port = ssc.socket().getLocalPort();
+
+        SocketChannel sc1 = connect(port);
+        SocketChannel sc2 = ssc.accept();
+
+        // launch the child
+        String cmd = System.getProperty("java.home") + File.separator + "bin" +
+            File.separator + "java";
+        String testClasses = System.getProperty("test.classes");
+        if (testClasses != null)
+            cmd += " -cp " + testClasses;
+        cmd += " SocketInheritance -child " + port;
+
+        Process p = Runtime.getRuntime().exec(cmd);
+
+        IOHandler.handle(p.getInputStream());
+        IOHandler.handle(p.getErrorStream());
+
+        // wait for child to connect
+        SocketChannel sc3 = ssc.accept();
+
+        // close sockets
+        sc1.close();
+        sc2.close();
+        sc3.close();
+        ssc.close();
+
+        // re-bind the listener - if the sockets were inherited then
+        // this will fail
+        try {
+            ssc = ServerSocketChannel.open();
+            ssc.socket().bind(new InetSocketAddress(port));
+            ssc.close();
+        } finally {
+            p.destroy();
+        }
+
+    }
+
+    public static void main(String[] args) throws Exception {
+        if (args.length == 0) {
+            start();
+        } else {
+            if (args[0].equals("-child")) {
+                child(Integer.parseInt(args[1]));
+            }
+        }
+    }
+}