undefect. CWE-407 — 63 sites patched across 27 ecosystems

Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com

Patches, unit tests, benchmarks, whitepaper, and outreach briefs.
Public domain — no copyright claimed. Use freely.

test/jdk/java/nio/channels/Selector/BasicAccept.java

@@ -0,0 +1,150 @@
+/*
+ * Copyright (c) 2000, 2010, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/* @test
+ * @summary Test Selector with ServerSocketChannels
+ * @library ..
+ */
+
+import java.io.*;
+import java.net.*;
+import java.nio.*;
+import java.nio.channels.*;
+import java.nio.channels.spi.SelectorProvider;
+import java.util.*;
+
+
+public class BasicAccept {
+
+    static void server(ServerSocketChannel ssc) throws Exception {
+        Selector acceptSelector = Selector.open();
+        try {
+            ssc.configureBlocking(false);
+            SelectionKey acceptKey
+                = ssc.register(acceptSelector, SelectionKey.OP_ACCEPT);
+            for (;;) {
+                int n = acceptSelector.select();
+                if (Thread.interrupted())
+                    break;
+                if (n == 0)
+                    continue;
+                Set<SelectionKey> readyKeys = acceptSelector.selectedKeys();
+                Iterator<SelectionKey> i = readyKeys.iterator();
+                while (i.hasNext()) {
+                    SelectionKey sk = i.next();
+                    i.remove();
+                    ServerSocketChannel nextReady
+                        = (ServerSocketChannel)sk.channel();
+                    SocketChannel sc = nextReady.accept();
+                    ByteBuffer bb = ByteBuffer.wrap(new byte[] { 42 });
+                    sc.write(bb);
+                    sc.close();
+                }
+            }
+        } finally {
+            acceptSelector.close();
+        }
+    }
+
+    private static class Server extends TestThread {
+        final ServerSocketChannel ssc;
+        Server() throws IOException {
+            super("Server", System.err);
+            this.ssc = ServerSocketChannel.open()
+                .bind(new InetSocketAddress(0));
+        }
+        int port() {
+            return ssc.socket().getLocalPort();
+        }
+        void go() throws Exception {
+            try {
+                server(ssc);
+            } finally {
+                ssc.close();
+            }
+        }
+    }
+
+    static void client(int port) throws Exception {
+        // Get a connection from the server
+        InetAddress lh = InetAddress.getLocalHost();
+        InetSocketAddress isa
+            = new InetSocketAddress(lh, port);
+        int connectFailures = 0;
+        boolean result = false;
+        SocketChannel sc = SocketChannel.open();
+        for (;;) {
+            try {
+                result = sc.connect(isa);
+                break;
+            } catch (java.net.ConnectException e) {
+                connectFailures++;
+                if (connectFailures > 30)
+                    throw new RuntimeException("Cannot connect");
+                Thread.currentThread().sleep(100);
+                sc = SocketChannel.open();
+            }
+        }
+        if (result) {
+            System.err.println("Connected");
+        } else {
+            // Only happens when server and client are on separate machines
+            System.err.println("Connection pending...");
+            connectFailures = 0;
+            while (!result) {
+                try {
+                    result = sc.finishConnect();
+                    if (!result)
+                        System.err.println("Not finished");
+                    Thread.sleep(50);
+                } catch (java.net.ConnectException e) {
+                    Thread.sleep(100);
+                    connectFailures++;
+                    if (connectFailures > 30)
+                        throw new RuntimeException("Cannot finish connecting");
+                }
+            }
+            System.err.println("Finished connecting");
+        }
+
+        ByteBuffer bb = ByteBuffer.allocateDirect(1024);
+        if (sc.read(bb) < 0)
+            throw new RuntimeException("Failed to read from server");
+        if (bb.get(0) != 42)
+            throw new RuntimeException("Read wrong byte from server");
+        System.err.println("Read from server");
+        sc.close();
+    }
+
+    public static void main(String[] args) throws Exception {
+        Server server = new Server();
+        server.start();
+        try {
+            client(server.port());
+        } finally {
+            server.interrupt();
+            server.finish(2000);
+        }
+    }
+
+}