undefect. CWE-407 — 63 sites patched across 27 ecosystems
Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com Patches, unit tests, benchmarks, whitepaper, and outreach briefs. Public domain — no copyright claimed. Use freely.
This commit is contained in:
commit
0a580b313d
70422 changed files with 17213626 additions and 0 deletions
292
test/jdk/java/net/httpclient/UnauthorizedTest.java
Normal file
292
test/jdk/java/net/httpclient/UnauthorizedTest.java
Normal file
|
|
@ -0,0 +1,292 @@
|
|||
/*
|
||||
* Copyright (c) 2018, 2026, Oracle and/or its affiliates. All rights reserved.
|
||||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
|
||||
*
|
||||
* This code is free software; you can redistribute it and/or modify it
|
||||
* under the terms of the GNU General Public License version 2 only, as
|
||||
* published by the Free Software Foundation.
|
||||
*
|
||||
* This code is distributed in the hope that it will be useful, but WITHOUT
|
||||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
||||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
||||
* version 2 for more details (a copy is included in the LICENSE file that
|
||||
* accompanied this code).
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License version
|
||||
* 2 along with this work; if not, write to the Free Software Foundation,
|
||||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
|
||||
*
|
||||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
|
||||
* or visit www.oracle.com if you need additional information or have any
|
||||
* questions.
|
||||
*/
|
||||
|
||||
/*
|
||||
* @test
|
||||
* @bug 8203882 8352623
|
||||
* @summary (httpclient) Check that HttpClient throws IOException when
|
||||
* receiving 401/407 with no WWW-Authenticate/Proxy-Authenticate
|
||||
* header only in the case where an authenticator is configured
|
||||
* for the client. If no authenticator is configured the client
|
||||
* should simply let the caller deal with the unauthorized response.
|
||||
* @library /test/lib /test/jdk/java/net/httpclient/lib
|
||||
* @build jdk.httpclient.test.lib.common.HttpServerAdapters
|
||||
* jdk.test.lib.net.SimpleSSLContext ReferenceTracker
|
||||
* @run junit/othervm
|
||||
* -Djdk.httpclient.HttpClient.log=headers
|
||||
* UnauthorizedTest
|
||||
*/
|
||||
|
||||
import jdk.test.lib.net.SimpleSSLContext;
|
||||
|
||||
import javax.net.ssl.SSLContext;
|
||||
import java.io.IOException;
|
||||
import java.io.InputStream;
|
||||
import java.io.OutputStream;
|
||||
import java.lang.ref.WeakReference;
|
||||
import java.net.Authenticator;
|
||||
import java.net.URI;
|
||||
import java.net.http.HttpClient;
|
||||
import java.net.http.HttpRequest;
|
||||
import java.net.http.HttpResponse;
|
||||
import java.net.http.HttpResponse.BodyHandlers;
|
||||
import java.util.concurrent.ExecutionException;
|
||||
import java.util.concurrent.atomic.AtomicLong;
|
||||
import jdk.httpclient.test.lib.common.HttpServerAdapters;
|
||||
|
||||
import static java.lang.System.out;
|
||||
import static java.net.http.HttpClient.Version.HTTP_1_1;
|
||||
import static java.net.http.HttpClient.Version.HTTP_2;
|
||||
import static java.net.http.HttpClient.Version.HTTP_3;
|
||||
import static java.net.http.HttpOption.Http3DiscoveryMode.HTTP_3_URI_ONLY;
|
||||
import static java.net.http.HttpOption.H3_DISCOVERY;
|
||||
import static java.nio.charset.StandardCharsets.UTF_8;
|
||||
|
||||
import org.junit.jupiter.api.AfterAll;
|
||||
import static org.junit.jupiter.api.Assertions.assertEquals;
|
||||
import static org.junit.jupiter.api.Assertions.assertTrue;
|
||||
import org.junit.jupiter.api.BeforeAll;
|
||||
import org.junit.jupiter.params.ParameterizedTest;
|
||||
import org.junit.jupiter.params.provider.MethodSource;
|
||||
|
||||
public class UnauthorizedTest implements HttpServerAdapters {
|
||||
|
||||
private static final SSLContext sslContext = SimpleSSLContext.findSSLContext();
|
||||
private static HttpTestServer httpTestServer; // HTTP/1.1
|
||||
private static HttpTestServer httpsTestServer; // HTTPS/1.1
|
||||
private static HttpTestServer http2TestServer; // HTTP/2 ( h2c )
|
||||
private static HttpTestServer https2TestServer; // HTTP/2 ( h2 )
|
||||
private static HttpTestServer http3TestServer; // HTTP/3 ( h3 )
|
||||
private static String httpURI;
|
||||
private static String httpsURI;
|
||||
private static String http2URI;
|
||||
private static String https2URI;
|
||||
private static String http3URI;
|
||||
private static HttpClient authClient;
|
||||
private static HttpClient noAuthClient;
|
||||
|
||||
static final int ITERATIONS = 3;
|
||||
|
||||
/*
|
||||
* NOT_MODIFIED status code results from a conditional GET where
|
||||
* the server does not (must not) return a response body because
|
||||
* the condition specified in the request disallows it
|
||||
*/
|
||||
static final int UNAUTHORIZED = 401;
|
||||
static final int PROXY_UNAUTHORIZED = 407;
|
||||
static final int HTTP_OK = 200;
|
||||
static final String MESSAGE = "Unauthorized";
|
||||
|
||||
static WeakReference<HttpClient> ref(HttpClient client) {
|
||||
return new WeakReference<>(client);
|
||||
}
|
||||
|
||||
public static Object[][] positive() {
|
||||
return new Object[][] {
|
||||
{ http3URI + "/server", UNAUTHORIZED, true, ref(authClient)},
|
||||
{ http3URI + "/server", UNAUTHORIZED, false, ref(authClient)},
|
||||
{ http3URI + "/server", UNAUTHORIZED, true, ref(noAuthClient)},
|
||||
{ http3URI + "/server", UNAUTHORIZED, false, ref(noAuthClient)},
|
||||
|
||||
|
||||
{ httpURI + "/server", UNAUTHORIZED, true, ref(authClient)},
|
||||
{ httpsURI + "/server", UNAUTHORIZED, true, ref(authClient)},
|
||||
{ http2URI + "/server", UNAUTHORIZED, true, ref(authClient)},
|
||||
{ https2URI + "/server", UNAUTHORIZED, true, ref(authClient)},
|
||||
{ httpURI + "/proxy", PROXY_UNAUTHORIZED, true, ref(authClient)},
|
||||
{ httpsURI + "/proxy", PROXY_UNAUTHORIZED, true, ref(authClient)},
|
||||
{ http2URI + "/proxy", PROXY_UNAUTHORIZED, true, ref(authClient)},
|
||||
{ https2URI + "/proxy", PROXY_UNAUTHORIZED, true, ref(authClient)},
|
||||
{ httpURI + "/server", UNAUTHORIZED, false, ref(authClient)},
|
||||
{ httpsURI + "/server", UNAUTHORIZED, false, ref(authClient)},
|
||||
{ http2URI + "/server", UNAUTHORIZED, false, ref(authClient)},
|
||||
{ https2URI + "/server", UNAUTHORIZED, false, ref(authClient)},
|
||||
{ httpURI + "/proxy", PROXY_UNAUTHORIZED, false, ref(authClient)},
|
||||
{ httpsURI + "/proxy", PROXY_UNAUTHORIZED, false, ref(authClient)},
|
||||
{ http2URI + "/proxy", PROXY_UNAUTHORIZED, false, ref(authClient)},
|
||||
{ https2URI + "/proxy", PROXY_UNAUTHORIZED, false, ref(authClient)},
|
||||
{ httpURI + "/server", UNAUTHORIZED, true, ref(noAuthClient)},
|
||||
{ httpsURI + "/server", UNAUTHORIZED, true, ref(noAuthClient)},
|
||||
{ http2URI + "/server", UNAUTHORIZED, true, ref(noAuthClient)},
|
||||
{ https2URI + "/server", UNAUTHORIZED, true, ref(noAuthClient)},
|
||||
{ httpURI + "/proxy", PROXY_UNAUTHORIZED, true, ref(noAuthClient)},
|
||||
{ httpsURI + "/proxy", PROXY_UNAUTHORIZED, true, ref(noAuthClient)},
|
||||
{ http2URI + "/proxy", PROXY_UNAUTHORIZED, true, ref(noAuthClient)},
|
||||
{ https2URI + "/proxy", PROXY_UNAUTHORIZED, true, ref(noAuthClient)},
|
||||
{ httpURI + "/server", UNAUTHORIZED, false, ref(noAuthClient)},
|
||||
{ httpsURI + "/server", UNAUTHORIZED, false, ref(noAuthClient)},
|
||||
{ http2URI + "/server", UNAUTHORIZED, false, ref(noAuthClient)},
|
||||
{ https2URI + "/server", UNAUTHORIZED, false, ref(noAuthClient)},
|
||||
{ httpURI + "/proxy", PROXY_UNAUTHORIZED, false, ref(noAuthClient)},
|
||||
{ httpsURI + "/proxy", PROXY_UNAUTHORIZED, false, ref(noAuthClient)},
|
||||
{ http2URI + "/proxy", PROXY_UNAUTHORIZED, false, ref(noAuthClient)},
|
||||
{ https2URI + "/proxy", PROXY_UNAUTHORIZED, false, ref(noAuthClient)},
|
||||
};
|
||||
}
|
||||
|
||||
static final Authenticator authenticator = new Authenticator() {
|
||||
};
|
||||
|
||||
private HttpRequest.Builder newRequestBuilder(URI uri) {
|
||||
var builder = HttpRequest.newBuilder(uri);
|
||||
if (uri.getRawPath().contains("/http3/")) {
|
||||
builder = builder.version(HTTP_3)
|
||||
.setOption(H3_DISCOVERY, HTTP_3_URI_ONLY);
|
||||
}
|
||||
return builder;
|
||||
}
|
||||
|
||||
@ParameterizedTest
|
||||
@MethodSource("positive")
|
||||
void test(String uriString, int code, boolean async, WeakReference<HttpClient> clientRef) throws Throwable {
|
||||
HttpClient client = clientRef.get();
|
||||
out.printf("%n---- starting (%s, %d, %s, %s) ----%n",
|
||||
uriString, code, async ? "async" : "sync",
|
||||
client.authenticator().isPresent() ? "authClient" : "noAuthClient");
|
||||
URI uri = URI.create(uriString);
|
||||
|
||||
HttpRequest.Builder requestBuilder = newRequestBuilder(uri)
|
||||
.GET();
|
||||
|
||||
HttpRequest request = requestBuilder.build();
|
||||
out.println("Initial request: " + request.uri());
|
||||
|
||||
boolean shouldThrow = client.authenticator().isPresent();
|
||||
String header = (code==UNAUTHORIZED)?"WWW-Authenticate":"Proxy-Authenticate";
|
||||
|
||||
HttpResponse<String> response = null;
|
||||
try {
|
||||
if (async) {
|
||||
response = client.send(request, BodyHandlers.ofString());
|
||||
} else {
|
||||
try {
|
||||
response = client.sendAsync(request, BodyHandlers.ofString()).get();
|
||||
} catch (ExecutionException ex) {
|
||||
ex.printStackTrace();
|
||||
throw ex.getCause();
|
||||
}
|
||||
}
|
||||
} catch (IOException ex) {
|
||||
if (shouldThrow && ex.getMessage().contains(header)) {
|
||||
System.out.println("Got expected exception: " + ex);
|
||||
return;
|
||||
} else throw ex;
|
||||
}
|
||||
|
||||
out.println(" Got response: " + response);
|
||||
assertEquals(code, response.statusCode());
|
||||
assertEquals( (code == UNAUTHORIZED ? "WWW-" : "Proxy-") + MESSAGE, response.body());
|
||||
if (shouldThrow) {
|
||||
throw new RuntimeException("Expected IOException not thrown.");
|
||||
}
|
||||
}
|
||||
|
||||
// -- Infrastructure
|
||||
|
||||
@BeforeAll
|
||||
public static void setup() throws Exception {
|
||||
httpTestServer = HttpTestServer.create(HTTP_1_1);
|
||||
httpTestServer.addHandler(new UnauthorizedHandler(), "/http1/");
|
||||
httpURI = "http://" + httpTestServer.serverAuthority() + "/http1";
|
||||
httpsTestServer = HttpTestServer.create(HTTP_1_1, sslContext);
|
||||
httpsTestServer.addHandler(new UnauthorizedHandler(),"/https1/");
|
||||
httpsURI = "https://" + httpsTestServer.serverAuthority() + "/https1";
|
||||
|
||||
http2TestServer = HttpTestServer.create(HTTP_2);
|
||||
http2TestServer.addHandler(new UnauthorizedHandler(), "/http2/");
|
||||
http2URI = "http://" + http2TestServer.serverAuthority() + "/http2";
|
||||
https2TestServer = HttpTestServer.create(HTTP_2, sslContext);
|
||||
https2TestServer.addHandler(new UnauthorizedHandler(), "/https2/");
|
||||
https2URI = "https://" + https2TestServer.serverAuthority() + "/https2";
|
||||
|
||||
http3TestServer = HttpTestServer.create(HTTP_3_URI_ONLY, sslContext);
|
||||
http3TestServer.addHandler(new UnauthorizedHandler(), "/http3/");
|
||||
http3URI = "https://" + http3TestServer.serverAuthority() + "/http3";
|
||||
|
||||
authClient = HttpServerAdapters.createClientBuilderForH3()
|
||||
.proxy(HttpClient.Builder.NO_PROXY)
|
||||
.sslContext(sslContext)
|
||||
.authenticator(authenticator)
|
||||
.build();
|
||||
|
||||
noAuthClient = HttpServerAdapters.createClientBuilderForH3()
|
||||
.proxy(HttpClient.Builder.NO_PROXY)
|
||||
.sslContext(sslContext)
|
||||
.build();
|
||||
|
||||
httpTestServer.start();
|
||||
httpsTestServer.start();
|
||||
http2TestServer.start();
|
||||
https2TestServer.start();
|
||||
http3TestServer.start();
|
||||
}
|
||||
|
||||
@AfterAll
|
||||
public static void teardown() throws Exception {
|
||||
// authClient.close();
|
||||
// noAuthClient.close();
|
||||
var TRACKER = ReferenceTracker.INSTANCE;
|
||||
TRACKER.track(authClient);
|
||||
TRACKER.track(noAuthClient);
|
||||
authClient = noAuthClient = null;
|
||||
System.gc();
|
||||
var error = TRACKER.check(1000);
|
||||
|
||||
httpTestServer.stop();
|
||||
httpsTestServer.stop();
|
||||
http2TestServer.stop();
|
||||
https2TestServer.stop();
|
||||
http3TestServer.stop();
|
||||
if (error != null) throw error;
|
||||
}
|
||||
|
||||
static class UnauthorizedHandler implements HttpTestHandler {
|
||||
|
||||
@Override
|
||||
public void handle(HttpTestExchange t) throws IOException {
|
||||
readAllRequestData(t); // shouldn't be any
|
||||
String method = t.getRequestMethod();
|
||||
String path = t.getRequestURI().getPath();
|
||||
HttpTestResponseHeaders rsph = t.getResponseHeaders();
|
||||
|
||||
int code;
|
||||
if (path.contains("server")) {
|
||||
code = UNAUTHORIZED;
|
||||
} else {
|
||||
code = PROXY_UNAUTHORIZED;
|
||||
}
|
||||
String message = (code == UNAUTHORIZED ? "WWW-" : "Proxy-") + MESSAGE;
|
||||
byte[] bytes = message.getBytes(UTF_8);
|
||||
t.sendResponseHeaders(code, bytes.length);
|
||||
try (OutputStream os = t.getResponseBody()) {
|
||||
os.write(bytes);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
static void readAllRequestData(HttpTestExchange t) throws IOException {
|
||||
try (InputStream is = t.getRequestBody()) {
|
||||
is.readAllBytes();
|
||||
}
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue