undefect. CWE-407 — 63 sites patched across 27 ecosystems
Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com Patches, unit tests, benchmarks, whitepaper, and outreach briefs. Public domain — no copyright claimed. Use freely.
This commit is contained in:
commit
0a580b313d
70422 changed files with 17213626 additions and 0 deletions
|
|
@ -0,0 +1,280 @@
|
|||
/*
|
||||
* Copyright (c) 2020, 2026, Oracle and/or its affiliates. All rights reserved.
|
||||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
|
||||
*
|
||||
* This code is free software; you can redistribute it and/or modify it
|
||||
* under the terms of the GNU General Public License version 2 only, as
|
||||
* published by the Free Software Foundation.
|
||||
*
|
||||
* This code is distributed in the hope that it will be useful, but WITHOUT
|
||||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
||||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
||||
* version 2 for more details (a copy is included in the LICENSE file that
|
||||
* accompanied this code).
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License version
|
||||
* 2 along with this work; if not, write to the Free Software Foundation,
|
||||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
|
||||
*
|
||||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
|
||||
* or visit www.oracle.com if you need additional information or have any
|
||||
* questions.
|
||||
*/
|
||||
|
||||
/*
|
||||
* @test
|
||||
* @bug 8237470
|
||||
* @summary Confirm HttpResponse.BodyHandlers#ofFile(Path)
|
||||
* works with default and non-default file systems
|
||||
* @library /test/lib /test/jdk/java/net/httpclient/lib
|
||||
* @build jdk.httpclient.test.lib.common.HttpServerAdapters
|
||||
* jdk.httpclient.test.lib.http2.Http2TestServer
|
||||
* jdk.httpclient.test.lib.http2.Http2TestServerConnection
|
||||
* jdk.httpclient.test.lib.http2.Http2TestExchange
|
||||
* jdk.httpclient.test.lib.http2.Http2Handler
|
||||
* jdk.httpclient.test.lib.http2.OutgoingPushPromise
|
||||
* jdk.httpclient.test.lib.http2.Queue
|
||||
* jdk.test.lib.net.SimpleSSLContext
|
||||
* jdk.test.lib.Platform jdk.test.lib.util.FileUtils
|
||||
* @run junit/othervm BodyHandlerOfFileTest
|
||||
*/
|
||||
|
||||
import jdk.test.lib.net.SimpleSSLContext;
|
||||
import jdk.test.lib.util.FileUtils;
|
||||
|
||||
import javax.net.ssl.SSLContext;
|
||||
import java.io.IOException;
|
||||
import java.io.InputStream;
|
||||
import java.io.OutputStream;
|
||||
import java.net.URI;
|
||||
import java.net.http.HttpClient;
|
||||
import java.net.http.HttpRequest;
|
||||
import java.net.http.HttpRequest.BodyPublishers;
|
||||
import java.net.http.HttpResponse;
|
||||
import java.nio.charset.StandardCharsets;
|
||||
import java.nio.file.FileSystem;
|
||||
import java.nio.file.FileSystems;
|
||||
import java.nio.file.Files;
|
||||
import java.nio.file.Path;
|
||||
import java.util.Map;
|
||||
import jdk.httpclient.test.lib.common.HttpServerAdapters;
|
||||
import static java.lang.System.out;
|
||||
import static java.net.http.HttpClient.Builder.NO_PROXY;
|
||||
import static java.net.http.HttpClient.Version.HTTP_1_1;
|
||||
import static java.net.http.HttpClient.Version.HTTP_2;
|
||||
import static java.net.http.HttpClient.Version.HTTP_3;
|
||||
import static java.net.http.HttpOption.Http3DiscoveryMode.HTTP_3_URI_ONLY;
|
||||
import static java.net.http.HttpOption.H3_DISCOVERY;
|
||||
|
||||
import org.junit.jupiter.api.AfterAll;
|
||||
import org.junit.jupiter.api.BeforeAll;
|
||||
import org.junit.jupiter.params.ParameterizedTest;
|
||||
import org.junit.jupiter.params.provider.MethodSource;
|
||||
import static org.junit.jupiter.api.Assertions.assertEquals;
|
||||
|
||||
public class BodyHandlerOfFileTest implements HttpServerAdapters {
|
||||
static final String MSG = "msg";
|
||||
|
||||
private static final SSLContext sslContext = SimpleSSLContext.findSSLContext();
|
||||
private static HttpTestServer httpTestServer; // HTTP/1.1 [ 5 servers ]
|
||||
private static HttpTestServer httpsTestServer; // HTTPS/1.1
|
||||
private static HttpTestServer http2TestServer; // HTTP/2 ( h2c )
|
||||
private static HttpTestServer https2TestServer; // HTTP/2 ( h2 )
|
||||
private static HttpTestServer http3TestServer; // HTTP/3 ( h3 )
|
||||
private static String httpURI;
|
||||
private static String httpsURI;
|
||||
private static String http2URI;
|
||||
private static String https2URI;
|
||||
private static String http3URI;
|
||||
|
||||
private static FileSystem zipFs;
|
||||
private static Path defaultFsPath;
|
||||
private static Path zipFsPath;
|
||||
|
||||
// Default file system set-up
|
||||
|
||||
static Path defaultFsFile() throws Exception {
|
||||
var file = Path.of("defaultFile.txt");
|
||||
if (Files.notExists(file)) {
|
||||
Files.createFile(file);
|
||||
}
|
||||
return file;
|
||||
}
|
||||
|
||||
public static Object[][] defaultFsData() {
|
||||
return new Object[][]{
|
||||
{ http3URI, defaultFsPath, MSG, true },
|
||||
{ http3URI, defaultFsPath, MSG, false },
|
||||
|
||||
{ httpURI, defaultFsPath, MSG, true },
|
||||
{ httpsURI, defaultFsPath, MSG, true },
|
||||
{ http2URI, defaultFsPath, MSG, true },
|
||||
{ https2URI, defaultFsPath, MSG, true },
|
||||
{ httpURI, defaultFsPath, MSG, false },
|
||||
{ httpsURI, defaultFsPath, MSG, false },
|
||||
{ http2URI, defaultFsPath, MSG, false },
|
||||
{ https2URI, defaultFsPath, MSG, false },
|
||||
};
|
||||
}
|
||||
|
||||
@ParameterizedTest
|
||||
@MethodSource("defaultFsData")
|
||||
public void testDefaultFs(String uriString,
|
||||
Path path,
|
||||
String expectedMsg,
|
||||
boolean sameClient) throws Exception {
|
||||
out.printf("\n\n--- testDefaultFs(%s, %s, \"%s\", %b): starting\n",
|
||||
uriString, path, expectedMsg, sameClient);
|
||||
receive(uriString, path, expectedMsg, sameClient);
|
||||
}
|
||||
|
||||
// Zip file system set-up
|
||||
|
||||
static FileSystem newZipFs() throws Exception {
|
||||
Path zipFile = Path.of("file.zip");
|
||||
return FileSystems.newFileSystem(zipFile, Map.of("create", "true"));
|
||||
}
|
||||
|
||||
static Path zipFsFile(FileSystem fs) throws Exception {
|
||||
var file = fs.getPath("fileInZip.txt");
|
||||
if (Files.notExists(file)) {
|
||||
Files.createFile(file);
|
||||
}
|
||||
return file;
|
||||
}
|
||||
|
||||
public static Object[][] zipFsData() {
|
||||
return new Object[][]{
|
||||
{ http3URI, zipFsPath, MSG, true },
|
||||
{ http3URI, zipFsPath, MSG, false },
|
||||
|
||||
{ httpURI, zipFsPath, MSG, true },
|
||||
{ httpsURI, zipFsPath, MSG, true },
|
||||
{ http2URI, zipFsPath, MSG, true },
|
||||
{ https2URI, zipFsPath, MSG, true },
|
||||
{ httpURI, zipFsPath, MSG, false },
|
||||
{ httpsURI, zipFsPath, MSG, false },
|
||||
{ http2URI, zipFsPath, MSG, false },
|
||||
{ https2URI, zipFsPath, MSG, false },
|
||||
};
|
||||
}
|
||||
|
||||
@ParameterizedTest
|
||||
@MethodSource("zipFsData")
|
||||
public void testZipFs(String uriString,
|
||||
Path path,
|
||||
String expectedMsg,
|
||||
boolean sameClient) throws Exception {
|
||||
out.printf("\n\n--- testZipFs(%s, %s, \"%s\", %b): starting\n",
|
||||
uriString, path, expectedMsg, sameClient);
|
||||
receive(uriString, path, expectedMsg, sameClient);
|
||||
}
|
||||
|
||||
private static final int ITERATION_COUNT = 3;
|
||||
|
||||
private HttpClient newHttpClient(String uri) {
|
||||
var builder = uri.contains("/http3/")
|
||||
? newClientBuilderForH3()
|
||||
: HttpClient.newBuilder();
|
||||
return builder.proxy(NO_PROXY)
|
||||
.sslContext(sslContext)
|
||||
.build();
|
||||
}
|
||||
|
||||
private HttpRequest.Builder newRequestBuilder(URI uri) {
|
||||
var builder = HttpRequest.newBuilder(uri);
|
||||
if (uri.getRawPath().contains("/http3/")) {
|
||||
builder = builder.version(HTTP_3)
|
||||
.setOption(H3_DISCOVERY, HTTP_3_URI_ONLY);
|
||||
}
|
||||
return builder;
|
||||
}
|
||||
|
||||
private void receive(String uriString,
|
||||
Path path,
|
||||
String expectedMsg,
|
||||
boolean sameClient) throws Exception {
|
||||
HttpClient client = null;
|
||||
|
||||
for (int i = 0; i < ITERATION_COUNT; i++) {
|
||||
if (!sameClient || client == null) {
|
||||
client = newHttpClient(uriString);
|
||||
}
|
||||
var req = newRequestBuilder(URI.create(uriString))
|
||||
.POST(BodyPublishers.noBody())
|
||||
.build();
|
||||
var resp = client.send(req, HttpResponse.BodyHandlers.ofFile(path));
|
||||
String msg = Files.readString(path, StandardCharsets.UTF_8);
|
||||
out.printf("Resp code: %s\n", resp.statusCode());
|
||||
out.printf("Msg written to %s: %s\n", resp.body(), msg);
|
||||
assertEquals(200, resp.statusCode());
|
||||
assertEquals(expectedMsg, msg);
|
||||
if (!sameClient) {
|
||||
client.close();
|
||||
}
|
||||
}
|
||||
if (sameClient && client != null) {
|
||||
client.close();
|
||||
}
|
||||
}
|
||||
|
||||
@BeforeAll
|
||||
public static void setup() throws Exception {
|
||||
defaultFsPath = defaultFsFile();
|
||||
zipFs = newZipFs();
|
||||
zipFsPath = zipFsFile(zipFs);
|
||||
|
||||
httpTestServer = HttpServerAdapters.HttpTestServer.create(HTTP_1_1);
|
||||
httpTestServer.addHandler(new HttpEchoHandler(), "/http1/echo");
|
||||
httpURI = "http://" + httpTestServer.serverAuthority() + "/http1/echo";
|
||||
|
||||
httpsTestServer = HttpServerAdapters.HttpTestServer.create(HTTP_1_1, sslContext);
|
||||
httpsTestServer.addHandler(new HttpEchoHandler(), "/https1/echo");
|
||||
httpsURI = "https://" + httpsTestServer.serverAuthority() + "/https1/echo";
|
||||
|
||||
http2TestServer = HttpServerAdapters.HttpTestServer.create(HTTP_2);
|
||||
http2TestServer.addHandler(new HttpEchoHandler(), "/http2/echo");
|
||||
http2URI = "http://" + http2TestServer.serverAuthority() + "/http2/echo";
|
||||
|
||||
https2TestServer = HttpServerAdapters.HttpTestServer.create(HTTP_2, sslContext);
|
||||
https2TestServer.addHandler(new HttpEchoHandler(), "/https2/echo");
|
||||
https2URI = "https://" + https2TestServer.serverAuthority() + "/https2/echo";
|
||||
|
||||
http3TestServer = HttpTestServer.create(HTTP_3_URI_ONLY, sslContext);
|
||||
http3TestServer.addHandler(new HttpEchoHandler(), "/http3/echo");
|
||||
http3URI = "https://" + http3TestServer.serverAuthority() + "/http3/echo";
|
||||
|
||||
httpTestServer.start();
|
||||
httpsTestServer.start();
|
||||
http2TestServer.start();
|
||||
https2TestServer.start();
|
||||
http3TestServer.start();
|
||||
}
|
||||
|
||||
@AfterAll
|
||||
public static void teardown() throws Exception {
|
||||
if (Files.exists(zipFsPath))
|
||||
FileUtils.deleteFileTreeWithRetry(zipFsPath);
|
||||
if (Files.exists(defaultFsPath))
|
||||
FileUtils.deleteFileTreeWithRetry(defaultFsPath);
|
||||
|
||||
httpTestServer.stop();
|
||||
httpsTestServer.stop();
|
||||
http2TestServer.stop();
|
||||
https2TestServer.stop();
|
||||
http3TestServer.stop();
|
||||
zipFs.close();
|
||||
}
|
||||
|
||||
static class HttpEchoHandler implements HttpServerAdapters.HttpTestHandler {
|
||||
@Override
|
||||
public void handle(HttpServerAdapters.HttpTestExchange t) throws IOException {
|
||||
try (InputStream is = t.getRequestBody();
|
||||
OutputStream os = t.getResponseBody()) {
|
||||
is.readAllBytes();
|
||||
t.sendResponseHeaders(200, MSG.getBytes().length);
|
||||
os.write(MSG.getBytes(StandardCharsets.UTF_8));
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue