undefect. CWE-407 — 63 sites patched across 27 ecosystems
Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com Patches, unit tests, benchmarks, whitepaper, and outreach briefs. Public domain — no copyright claimed. Use freely.
This commit is contained in:
commit
0a580b313d
70422 changed files with 17213626 additions and 0 deletions
211
test/jdk/java/net/httpclient/HeadTest.java
Normal file
211
test/jdk/java/net/httpclient/HeadTest.java
Normal file
|
|
@ -0,0 +1,211 @@
|
|||
/*
|
||||
* Copyright (c) 2018, 2026, Oracle and/or its affiliates. All rights reserved.
|
||||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
|
||||
*
|
||||
* This code is free software; you can redistribute it and/or modify it
|
||||
* under the terms of the GNU General Public License version 2 only, as
|
||||
* published by the Free Software Foundation.
|
||||
*
|
||||
* This code is distributed in the hope that it will be useful, but WITHOUT
|
||||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
||||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
||||
* version 2 for more details (a copy is included in the LICENSE file that
|
||||
* accompanied this code).
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License version
|
||||
* 2 along with this work; if not, write to the Free Software Foundation,
|
||||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
|
||||
*
|
||||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
|
||||
* or visit www.oracle.com if you need additional information or have any
|
||||
* questions.
|
||||
*/
|
||||
|
||||
/*
|
||||
* @test
|
||||
* @bug 8203433 8276559
|
||||
* @summary Tests Client handles HEAD and 304 responses correctly.
|
||||
* @library /test/lib /test/jdk/java/net/httpclient/lib
|
||||
* @build jdk.test.lib.net.SimpleSSLContext
|
||||
* @run junit/othervm -Djdk.httpclient.HttpClient.log=trace,headers,requests HeadTest
|
||||
*/
|
||||
|
||||
import jdk.test.lib.net.SimpleSSLContext;
|
||||
|
||||
import javax.net.ssl.SSLContext;
|
||||
import java.io.IOException;
|
||||
import java.io.InputStream;
|
||||
import java.io.PrintStream;
|
||||
import java.net.URI;
|
||||
import java.net.http.HttpClient.Redirect;
|
||||
import java.net.http.HttpClient.Version;
|
||||
import java.net.http.HttpRequest;
|
||||
import java.net.http.HttpOption.Http3DiscoveryMode;
|
||||
import java.net.http.HttpResponse;
|
||||
import java.net.http.HttpResponse.BodyHandlers;
|
||||
import jdk.httpclient.test.lib.common.HttpServerAdapters;
|
||||
|
||||
import static java.net.http.HttpClient.Version.HTTP_3;
|
||||
import static java.net.http.HttpClient.Version.HTTP_2;
|
||||
import static java.net.http.HttpClient.Version.HTTP_1_1;
|
||||
import static java.net.http.HttpOption.Http3DiscoveryMode.HTTP_3_URI_ONLY;
|
||||
import static java.net.http.HttpOption.H3_DISCOVERY;
|
||||
import static jdk.httpclient.test.lib.common.HttpServerAdapters.createClientBuilderForH3;
|
||||
|
||||
import org.junit.jupiter.api.AfterAll;
|
||||
import static org.junit.jupiter.api.Assertions.assertEquals;
|
||||
import org.junit.jupiter.api.BeforeAll;
|
||||
import org.junit.jupiter.params.ParameterizedTest;
|
||||
import org.junit.jupiter.params.provider.MethodSource;
|
||||
|
||||
public class HeadTest implements HttpServerAdapters {
|
||||
|
||||
private static final SSLContext sslContext = SimpleSSLContext.findSSLContext();
|
||||
private static HttpTestServer httpTestServer; // HTTP/1.1
|
||||
private static HttpTestServer httpsTestServer; // HTTPS/1.1
|
||||
private static HttpTestServer http2TestServer; // HTTP/2 ( h2c )
|
||||
private static HttpTestServer https2TestServer; // HTTP/2 ( h2 )
|
||||
private static HttpTestServer https3TestServer; // HTTP/3
|
||||
private static String httpURI, httpsURI;
|
||||
private static String http2URI, https2URI;
|
||||
private static String https3URI;
|
||||
|
||||
static final String CONTENT_LEN = "300";
|
||||
|
||||
/*
|
||||
* NOT_MODIFIED status code results from a conditional GET where
|
||||
* the server does not (must not) return a response body because
|
||||
* the condition specified in the request disallows it
|
||||
*/
|
||||
static final int HTTP_NOT_MODIFIED = 304;
|
||||
static final int HTTP_OK = 200;
|
||||
static final PrintStream out = System.out;
|
||||
|
||||
public static Object[][] positive() {
|
||||
return new Object[][] {
|
||||
// HTTP/1.1
|
||||
{ httpURI, "GET", HTTP_NOT_MODIFIED, HTTP_1_1 },
|
||||
{ httpsURI, "GET", HTTP_NOT_MODIFIED, HTTP_1_1 },
|
||||
{ httpURI, "HEAD", HTTP_OK, HTTP_1_1 },
|
||||
{ httpsURI, "HEAD", HTTP_OK, HTTP_1_1 },
|
||||
{ httpURI + "transfer/", "GET", HTTP_NOT_MODIFIED, HTTP_1_1 },
|
||||
{ httpsURI + "transfer/", "GET", HTTP_NOT_MODIFIED, HTTP_1_1 },
|
||||
{ httpURI + "transfer/", "HEAD", HTTP_OK, HTTP_1_1 },
|
||||
{ httpsURI + "transfer/", "HEAD", HTTP_OK, HTTP_1_1 },
|
||||
// HTTP/2
|
||||
{ http2URI, "GET", HTTP_NOT_MODIFIED, HTTP_2 },
|
||||
{ https2URI, "GET", HTTP_NOT_MODIFIED, HTTP_2 },
|
||||
{ http2URI, "HEAD", HTTP_OK, HTTP_2 },
|
||||
{ https2URI, "HEAD", HTTP_OK, HTTP_2 },
|
||||
// HTTP/3
|
||||
{ https3URI, "GET", HTTP_NOT_MODIFIED, HTTP_3 },
|
||||
{ https3URI, "HEAD", HTTP_OK, HTTP_3 },
|
||||
};
|
||||
}
|
||||
|
||||
@ParameterizedTest
|
||||
@MethodSource("positive")
|
||||
void test(String uriString, String method,
|
||||
int expResp, Version version) throws Exception {
|
||||
out.printf("%n---- starting (%s) ----%n", uriString);
|
||||
URI uri = URI.create(uriString);
|
||||
Http3DiscoveryMode config = version.equals(HTTP_3) ? HTTP_3_URI_ONLY : null;
|
||||
HttpRequest.Builder requestBuilder = HttpRequest
|
||||
.newBuilder(uri)
|
||||
.version(version)
|
||||
.setOption(H3_DISCOVERY, config)
|
||||
.method(method, HttpRequest.BodyPublishers.noBody());
|
||||
doTest(requestBuilder.build(), expResp);
|
||||
// repeat the test this time by building the request using convenience
|
||||
// GET and HEAD methods
|
||||
requestBuilder = HttpRequest.newBuilder(uri)
|
||||
.version(version)
|
||||
.setOption(H3_DISCOVERY, config);
|
||||
switch (method) {
|
||||
case "GET" -> requestBuilder.GET();
|
||||
case "HEAD" -> requestBuilder.HEAD();
|
||||
default -> throw new IllegalArgumentException("Unexpected method " + method);
|
||||
}
|
||||
doTest(requestBuilder.build(), expResp);
|
||||
}
|
||||
|
||||
// issue a request with no body and verify the response code is the expected response code
|
||||
private void doTest(HttpRequest request, int expResp) throws Exception {
|
||||
try (var client = createClientBuilderForH3().followRedirects(Redirect.ALWAYS).sslContext(sslContext).build()) {
|
||||
out.println("Initial request: " + request.uri());
|
||||
HttpResponse<String> response = client.send(request, BodyHandlers.ofString());
|
||||
|
||||
out.println(" Got response: " + response);
|
||||
|
||||
assertEquals(expResp, response.statusCode());
|
||||
assertEquals("", response.body());
|
||||
assertEquals(CONTENT_LEN, response.headers().firstValue("Content-length").get());
|
||||
assertEquals(request.version().get(), response.version());
|
||||
}
|
||||
}
|
||||
|
||||
// -- Infrastructure
|
||||
// TODO: See if test performs better with Vthreads, see H3SimplePost and H3SimpleGet
|
||||
@BeforeAll
|
||||
public static void setup() throws Exception {
|
||||
httpTestServer = HttpTestServer.create(HTTP_1_1);
|
||||
httpTestServer.addHandler(new HeadHandler(), "/");
|
||||
httpURI = "http://" + httpTestServer.serverAuthority() + "/";
|
||||
httpsTestServer = HttpTestServer.create(HTTP_1_1, sslContext);
|
||||
httpsTestServer.addHandler(new HeadHandler(),"/");
|
||||
httpsURI = "https://" + httpsTestServer.serverAuthority() + "/";
|
||||
|
||||
http2TestServer = HttpTestServer.create(HTTP_2);
|
||||
http2TestServer.addHandler(new HeadHandler(), "/");
|
||||
http2URI = "http://" + http2TestServer.serverAuthority() + "/";
|
||||
https2TestServer = HttpTestServer.create(HTTP_2, sslContext);
|
||||
https2TestServer.addHandler(new HeadHandler(), "/");
|
||||
https2URI = "https://" + https2TestServer.serverAuthority() + "/";
|
||||
|
||||
https3TestServer = HttpTestServer.create(HTTP_3_URI_ONLY, sslContext);
|
||||
https3TestServer.addHandler(new HeadHandler(), "/");
|
||||
https3URI = "https://" + https3TestServer.serverAuthority() + "/";
|
||||
|
||||
|
||||
httpTestServer.start();
|
||||
httpsTestServer.start();
|
||||
http2TestServer.start();
|
||||
https2TestServer.start();
|
||||
https3TestServer.start();
|
||||
}
|
||||
|
||||
@AfterAll
|
||||
public static void teardown() throws Exception {
|
||||
httpTestServer.stop();
|
||||
httpsTestServer.stop();
|
||||
http2TestServer.stop();
|
||||
https2TestServer.stop();
|
||||
https3TestServer.stop();
|
||||
}
|
||||
|
||||
static class HeadHandler implements HttpTestHandler {
|
||||
|
||||
@Override
|
||||
public void handle(HttpTestExchange t) throws IOException {
|
||||
readAllRequestData(t); // shouldn't be any
|
||||
String method = t.getRequestMethod();
|
||||
String path = t.getRequestURI().getPath();
|
||||
HttpTestResponseHeaders rsph = t.getResponseHeaders();
|
||||
if (path.contains("transfer"))
|
||||
rsph.addHeader("Transfer-Encoding", "chunked");
|
||||
rsph.addHeader("Content-length", CONTENT_LEN);
|
||||
if (method.equals("HEAD")) {
|
||||
t.sendResponseHeaders(HTTP_OK, -1);
|
||||
} else if (method.equals("GET")) {
|
||||
t.sendResponseHeaders(HTTP_NOT_MODIFIED, -1);
|
||||
}
|
||||
t.close();
|
||||
}
|
||||
}
|
||||
|
||||
static void readAllRequestData(HttpTestExchange t) throws IOException {
|
||||
try (InputStream is = t.getRequestBody()) {
|
||||
is.readAllBytes();
|
||||
}
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue