undefect. CWE-407 — 63 sites patched across 27 ecosystems

Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com

Patches, unit tests, benchmarks, whitepaper, and outreach briefs.
Public domain — no copyright claimed. Use freely.

test/jdk/java/io/PipedOutputStream/ClosedWrite.java

@@ -0,0 +1,53 @@
+/*
+ * Copyright (c) 1998, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 1267258
+ * @summary Check for IOException upon write on closed stream.
+ *
+ */
+
+import java.io.*;
+
+/**
+ * This class tests to see if an IOException is thrown when
+ * an attempt is made to write to a closed PipedOutputStream.
+ */
+
+public class ClosedWrite {
+
+    public static void main(String[] argv) throws Exception {
+        PipedOutputStream os = new PipedOutputStream();
+        PipedInputStream is = new PipedInputStream();
+        os.connect(is);
+        os.close();
+        try {
+            os.write(10);
+            throw new
+                RuntimeException("No IOException upon write on closed Stream");
+        } catch(IOException e) {
+            System.err.println("Test passed: IOException thrown");
+        }
+    }
+}

test/jdk/java/io/PipedOutputStream/DeadReader.java

@@ -0,0 +1,78 @@
+/*
+ * Copyright (c) 1998, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 1267045
+ * @summary Make sure write will fail if reading
+ *          end thread is dead.
+ *
+ */
+
+
+import java.io.*;
+
+public class DeadReader {
+
+    public static void main(String[] argv) throws Exception {
+        PipedOutputStream os = new PipedOutputStream();
+        PipedInputStream is = new PipedInputStream();
+        is.connect(os);
+
+        // create reader thread
+        LazyReader lr = new LazyReader(is);
+
+        os.write(new byte[1000]);
+
+        lr.start();
+        while (lr.isAlive()) {
+            Thread.sleep(100);
+        }
+
+        try{
+            os.write(27);
+            throw new Exception
+                ("Test failed: shouldn't be able to write");
+        } catch (IOException e) {
+            // test passed
+        }
+    }
+}
+
+class LazyReader extends Thread {
+    private PipedInputStream snk;
+    private int delay;
+
+    public LazyReader(PipedInputStream snk) {
+        this.snk = snk;
+    }
+
+    public void run() {
+        try {
+            snk.read();
+        } catch (Exception e) {
+            System.err.println("Test failed: unexpected exception");
+        }
+        return;
+    }
+}

test/jdk/java/io/PipedOutputStream/MultipleConnect.java

@@ -0,0 +1,46 @@
+/*
+ * Copyright (c) 1998, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 1266814
+ * @summary Check for IOException upon multiple connects.
+ *
+ */
+
+import java.io.*;
+
+public class MultipleConnect {
+
+    public static void main(String[] argv) throws Exception {
+        PipedOutputStream os = new PipedOutputStream();
+        PipedOutputStream os2 = new PipedOutputStream();
+        PipedInputStream is = new PipedInputStream();
+        os.connect(is);
+        try {
+            is.connect(os2);
+            throw new Exception("Test failed: IOException expected");
+        } catch(IOException e) {
+        }
+    }
+}

test/jdk/java/io/PipedOutputStream/NotConnected.java

@@ -0,0 +1,57 @@
+/*
+ * Copyright (c) 1998, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 1267038
+ * @summary Check for IOException upon read/write on unconnected stream.
+ *
+ */
+
+
+import java.io.*;
+
+public class NotConnected {
+    public static void main( String[] argv ) throws Exception {
+        PipedInputStream i = new PipedInputStream();
+        PipedOutputStream o = new PipedOutputStream();
+        boolean readPassed = false;
+        boolean writePassed = false;
+
+        try {
+            i.read();
+        } catch (IOException e) {
+            readPassed = true;
+        }
+
+        try {
+            o.write(10);
+        } catch (IOException e) {
+            writePassed = true;
+        }
+
+        if (!readPassed || !writePassed) {
+            throw new Exception("Test failed: IOException not thrown" );
+        }
+    }
+}

test/jdk/java/io/PipedOutputStream/WriteAfterClose.java

@@ -0,0 +1,55 @@
+/*
+ * Copyright (c) 1998, 2025, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/* @test
+ * @bug 4143704 8367943
+ * @summary Test if write throws exception after reader closes the pipe.
+ */
+
+import java.io.IOException;
+import java.io.PipedInputStream;
+import java.io.PipedOutputStream;
+
+public class WriteAfterClose {
+    public static void main(String argv[]) throws Exception {
+        try (PipedInputStream in = new PipedInputStream();
+             PipedOutputStream out = new PipedOutputStream(in)) {
+            in.close();
+            try {
+                out.write('a');
+                throw new Exception("Should not allow write after close");
+            } catch (IOException e) {
+            }
+        }
+
+        try (PipedInputStream in = new PipedInputStream();
+             PipedOutputStream out = new PipedOutputStream(in)) {
+            out.close();
+            try {
+                out.write(new byte[7], 3, 0);
+            } catch (IOException e) {
+                throw new Exception("Should not fail 0-length write after close");
+            }
+        }
+    }
+}