undefect. CWE-407 — 63 sites patched across 27 ecosystems

Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com

Patches, unit tests, benchmarks, whitepaper, and outreach briefs.
Public domain — no copyright claimed. Use freely.

test/jdk/java/awt/GraphicsConfiguration/HeadlessGraphicsConfiguration.java

@@ -0,0 +1,53 @@
+/*
+ * Copyright (c) 2007, 2014, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+import java.awt.*;
+import java.awt.geom.AffineTransform;
+import java.awt.image.BufferedImage;
+import java.awt.image.ColorModel;
+
+/*
+ * @test
+ * @summary Check that GraphicsConfiguration methods do not throw unexpected
+ *          exceptions in headless mode
+ * @run main/othervm -Djava.awt.headless=true HeadlessGraphicsConfiguration
+ */
+
+public class HeadlessGraphicsConfiguration {
+    public static void main(String args[]) {
+        GraphicsEnvironment ge = GraphicsEnvironment.getLocalGraphicsEnvironment();
+        Graphics2D gd = ge.createGraphics(new BufferedImage(100, 100, BufferedImage.TYPE_4BYTE_ABGR));
+        GraphicsConfiguration gc = gd.getDeviceConfiguration();
+        GraphicsDevice gdev = gc.getDevice();
+        BufferedImage bi = gc.createCompatibleImage(100, 100);
+        bi = gc.createCompatibleImage(100, 100, Transparency.TRANSLUCENT);
+
+        ColorModel cm = gc.getColorModel();
+        cm = gc.getColorModel(Transparency.TRANSLUCENT);
+
+        AffineTransform at = gc.getDefaultTransform();
+        at = gc.getNormalizingTransform();
+
+        Rectangle r = gc.getBounds();
+    }
+}

test/jdk/java/awt/GraphicsConfiguration/NonDefaultGC.java

@@ -0,0 +1,124 @@
+/*
+ * Copyright (c) 2002, 2024, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug     4131642
+ * @summary This test shows the ability to create Frames, Windows
+ *          and Canvases with a GraphicsConfiguration. The test should show a number
+ *          of windows with RGB stripes in according to the number of the
+ *          GraphicsConfigurations for each screen. It also displays the size of
+ *          the screen and the GraphicsConfiguration.toString().
+ * @library /java/awt/regtesthelpers
+ * @build PassFailJFrame
+ * @run main/manual NonDefaultGC
+ */
+
+import java.awt.Canvas;
+import java.awt.Color;
+import java.awt.Dimension;
+import java.awt.Graphics;
+import java.awt.GraphicsConfiguration;
+import java.awt.GraphicsDevice;
+import java.awt.GraphicsEnvironment;
+import java.awt.Rectangle;
+import javax.swing.JFrame;
+import javax.swing.SwingUtilities;
+
+public class NonDefaultGC {
+
+    private static final String INSTRUCTIONS = """
+        This test shows the ability to create Frames, Windows and Canvases
+        with a GraphicsConfiguration.
+        The test should show a number of windows with RGB stripes according
+        to the number of the GraphicsConfigurations for each screen.
+        The window also contains text which displays the size of the screen
+        and the output GraphicsConfiguration.toString().
+        The test passes if every screen displays at least one such window.
+        """;
+
+    public static void main(String[] argv) throws Exception {
+       SwingUtilities.invokeAndWait(NonDefaultGC::createUI);
+       PassFailJFrame.builder()
+                .title("GraphicsConfigurationTest")
+                .instructions(INSTRUCTIONS)
+                .testTimeOut(5)
+                .rows(12)
+                .columns(45)
+                .build()
+                .awaitAndCheck();
+
+    }
+
+    private static void createUI() {
+
+        GraphicsEnvironment ge = GraphicsEnvironment.
+                                 getLocalGraphicsEnvironment();
+        GraphicsDevice[] gs = ge.getScreenDevices();
+        for (int j = 0; j < gs.length; j++) {
+            GraphicsDevice gd = gs[j];
+            GraphicsConfiguration[] gc = gd.getConfigurations();
+            for (int i=0; i < gc.length; i++) {
+                JFrame f = new JFrame(gs[j].getDefaultConfiguration());
+                PassFailJFrame.addTestWindow(f); // to ensure it is disposed.
+                GCCanvas c = new GCCanvas(gc[i]);
+                Rectangle gcBounds = gc[i].getBounds();
+                int xoffs = gcBounds.x;
+                int yoffs = gcBounds.y;
+                f.getContentPane().add(c);
+                f.setTitle("Screen# "+ j +", GC# "+ i);
+                f.setSize(300, 150);
+                f.setLocation((i*50)+xoffs, (i*60)+yoffs);
+                f.show();
+            }
+        }
+    }
+}
+
+class GCCanvas extends Canvas {
+
+    GraphicsConfiguration gc;
+    Rectangle bounds;
+
+    public GCCanvas(GraphicsConfiguration gc) {
+        super(gc);
+        this.gc = gc;
+        bounds = gc.getBounds();
+    }
+
+    public Dimension getPreferredSize() {
+        return new Dimension(300, 150);
+    }
+
+    public void paint(Graphics g) {
+        g.setColor(Color.red);
+        g.fillRect(0, 0, 100, 150);
+        g.setColor(Color.green);
+        g.fillRect(100, 0, 100, 150);
+        g.setColor(Color.blue);
+        g.fillRect(200, 0, 100, 150);
+        g.setColor(Color.black);
+        g.drawString("ScreenSize="+bounds.width+"X"+ bounds.height, 10, 15);
+        g.drawString(gc.toString(), 10, 30);
+    }
+}

test/jdk/java/awt/GraphicsConfiguration/NormalizingTransformTest/NormalizingTransformTest.java

@@ -0,0 +1,56 @@
+/*
+ * Copyright (c) 2012, 2016, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/**
+ * @test
+ * @key headful
+ * @bug 6373505
+ * @summary Tests that the result of Toolkit.getScreenResolution() is
+ * consistent with GraphicsConfiguration.getNormalizingTransform().
+ * @author Dmitri.Trembovetski@Sun.COM: area=GraphicsConfiguration
+ * @run main NormalizingTransformTest
+ */
+
+import java.awt.GraphicsConfiguration;
+import java.awt.GraphicsEnvironment;
+import java.awt.Toolkit;
+import java.awt.geom.AffineTransform;
+
+public class NormalizingTransformTest {
+
+    public static void main(String[] args) {
+        GraphicsConfiguration gc =
+            GraphicsEnvironment.getLocalGraphicsEnvironment().
+                getDefaultScreenDevice().getDefaultConfiguration();
+        AffineTransform normTransform = gc.getNormalizingTransform();
+        int dpiX = Toolkit.getDefaultToolkit().getScreenResolution();
+        int normDpiX = (int)(normTransform.getScaleX() * 72.0);
+        if (dpiX != normDpiX) {
+            throw new RuntimeException(
+                "Test FAILED. Toolkit.getScreenResolution()=" + dpiX +
+                " GraphicsConfiguration.getNormalizingTransform()="+normDpiX);
+        }
+        System.out.println("Test PASSED. DPI="+normDpiX);
+    }
+
+}

test/jdk/java/awt/GraphicsConfiguration/Position.java

@@ -0,0 +1,94 @@
+/*
+ * Copyright (c) 1999, 2024, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug     4271200
+ * @summary This test should show that the default position of a Frame
+ *          should be on the physical screen for the GraphicsConfiguration.
+ *          The togglebutton shows and hides an empty frame on the second monitor.
+ *          The frame should be positioned at 0, 0 and is shown and hidden by clicking the button.
+ * @library /java/awt/regtesthelpers
+ * @build PassFailJFrame
+ * @run main/manual Position
+ */
+
+import java.awt.GraphicsDevice;
+import java.awt.GraphicsEnvironment;
+import java.awt.event.ActionEvent;
+import java.awt.event.ActionListener;
+import javax.swing.JButton;
+import javax.swing.JFrame;
+import javax.swing.JPanel;
+
+public class Position extends JPanel implements ActionListener {
+
+    static final String INSTRUCTIONS = """
+        This test should show that the default position of a Frame
+        should be on the physical screen for the specified GraphicsConfiguration.
+        There is a window "Show/Hide" button.
+        The button alternatively shows and hides an empty frame on the second monitor.
+        The frame should be positioned at 0, 0 and is shown and hidden by clicking the button.
+        The test passes if it behaves as described and fails otherwise.
+        """;
+
+    static volatile GraphicsDevice gd[];
+    static volatile JFrame secondFrame;
+    static volatile boolean on = true;
+
+    public Position() {
+        JPanel p = new JPanel();
+        JButton b = new JButton("Show/Hide Window on other screen");
+        b.addActionListener(this);
+        p.add(b);
+        add(p);
+    }
+
+    public void actionPerformed(ActionEvent e) {
+        if (secondFrame == null) {
+            secondFrame = new JFrame("screen1", gd[1].getDefaultConfiguration());
+            secondFrame.setSize(500, 500);
+            PassFailJFrame.addTestWindow(secondFrame);
+        }
+        secondFrame.setVisible(on);
+        on = !on;
+    }
+
+    public static void main(String[] args) throws Exception {
+
+        gd = GraphicsEnvironment.getLocalGraphicsEnvironment().getScreenDevices();
+        if (gd.length < 2) { /* test runs only on a multi-screen environment */
+            return;
+        }
+
+        PassFailJFrame.builder()
+                .title("Screen Device Position Test")
+                .instructions(INSTRUCTIONS)
+                .testTimeOut(5)
+                .rows(10)
+                .columns(50)
+                .splitUIBottom(Position::new)
+                .build()
+                .awaitAndCheck();
+    }
+}