undefect. CWE-407 — 63 sites patched across 27 ecosystems
Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com Patches, unit tests, benchmarks, whitepaper, and outreach briefs. Public domain — no copyright claimed. Use freely.
This commit is contained in:
commit
0a580b313d
70422 changed files with 17213626 additions and 0 deletions
118
test/jdk/com/sun/net/httpserver/bugs/ZeroLengthOutputStream.java
Normal file
118
test/jdk/com/sun/net/httpserver/bugs/ZeroLengthOutputStream.java
Normal file
|
|
@ -0,0 +1,118 @@
|
|||
/*
|
||||
* Copyright (c) 2023, 2026, Oracle and/or its affiliates. All rights reserved.
|
||||
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
|
||||
*
|
||||
* This code is free software; you can redistribute it and/or modify it
|
||||
* under the terms of the GNU General Public License version 2 only, as
|
||||
* published by the Free Software Foundation.
|
||||
*
|
||||
* This code is distributed in the hope that it will be useful, but WITHOUT
|
||||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
||||
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
||||
* version 2 for more details (a copy is included in the LICENSE file that
|
||||
* accompanied this code).
|
||||
*
|
||||
* You should have received a copy of the GNU General Public License version
|
||||
* 2 along with this work; if not, write to the Free Software Foundation,
|
||||
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
|
||||
*
|
||||
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
|
||||
* or visit www.oracle.com if you need additional information or have any
|
||||
* questions.
|
||||
*/
|
||||
|
||||
|
||||
import com.sun.net.httpserver.HttpExchange;
|
||||
import com.sun.net.httpserver.HttpHandler;
|
||||
import com.sun.net.httpserver.HttpServer;
|
||||
import jdk.test.lib.net.URIBuilder;
|
||||
import org.junit.jupiter.api.Test;
|
||||
|
||||
import java.io.IOException;
|
||||
import java.io.OutputStream;
|
||||
import java.net.HttpURLConnection;
|
||||
import java.net.InetAddress;
|
||||
import java.net.InetSocketAddress;
|
||||
import java.net.Proxy;
|
||||
import java.net.URL;
|
||||
import java.util.concurrent.CountDownLatch;
|
||||
import java.util.logging.ConsoleHandler;
|
||||
import java.util.logging.Handler;
|
||||
import java.util.logging.Level;
|
||||
import java.util.logging.Logger;
|
||||
|
||||
import static org.junit.jupiter.api.Assertions.*;
|
||||
import static com.sun.net.httpserver.HttpExchange.RSPBODY_EMPTY;
|
||||
|
||||
/*
|
||||
* @test
|
||||
* @bug 8219083
|
||||
* @summary HttpExchange.getResponseBody write and close should not throw
|
||||
* even when response length is zero
|
||||
* @library /test/lib
|
||||
* @comment We use othervm because this test configures logging handlers
|
||||
* for the system wide "com.sun.net.httpserver" logger
|
||||
* @run junit/othervm ${test.main.class}
|
||||
*/
|
||||
public class ZeroLengthOutputStream {
|
||||
|
||||
private static final Logger LOGGER = Logger.getLogger("com.sun.net.httpserver");
|
||||
public volatile boolean closed;
|
||||
public CountDownLatch cdl = new CountDownLatch(1);
|
||||
|
||||
@Test
|
||||
void test() throws IOException, InterruptedException {
|
||||
HttpServer httpServer = startHttpServer();
|
||||
int port = httpServer.getAddress().getPort();
|
||||
try {
|
||||
URL url = URIBuilder.newBuilder()
|
||||
.scheme("http")
|
||||
.loopback()
|
||||
.port(port)
|
||||
.path("/flis/")
|
||||
.toURLUnchecked();
|
||||
HttpURLConnection uc = (HttpURLConnection)url.openConnection(Proxy.NO_PROXY);
|
||||
uc.getResponseCode();
|
||||
cdl.await();
|
||||
assertTrue(closed, "OutputStream close did not complete");
|
||||
} finally {
|
||||
httpServer.stop(0);
|
||||
}
|
||||
}
|
||||
|
||||
private static void setupLogging() {
|
||||
final Handler handler = new ConsoleHandler();
|
||||
handler.setLevel(Level.FINEST);
|
||||
LOGGER.setLevel(Level.FINEST);
|
||||
LOGGER.addHandler(handler);
|
||||
}
|
||||
|
||||
/**
|
||||
* Http Server
|
||||
*/
|
||||
HttpServer startHttpServer() throws IOException {
|
||||
setupLogging(); // merely for debugging
|
||||
InetAddress loopback = InetAddress.getLoopbackAddress();
|
||||
HttpServer httpServer = HttpServer.create(new InetSocketAddress(loopback, 0), 0);
|
||||
httpServer.createContext("/flis/", new MyHandler());
|
||||
httpServer.start();
|
||||
return httpServer;
|
||||
}
|
||||
|
||||
class MyHandler implements HttpHandler {
|
||||
|
||||
@Override
|
||||
public void handle(HttpExchange t) throws IOException {
|
||||
try {
|
||||
OutputStream os = t.getResponseBody();
|
||||
t.sendResponseHeaders(200, RSPBODY_EMPTY);
|
||||
os.write(new byte[0]);
|
||||
os.close();
|
||||
System.out.println("Output stream closed");
|
||||
closed = true;
|
||||
} finally {
|
||||
cdl.countDown();
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue