undefect. CWE-407 — 63 sites patched across 27 ecosystems

Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com

Patches, unit tests, benchmarks, whitepaper, and outreach briefs.
Public domain — no copyright claimed. Use freely.

test/hotspot/jtreg/runtime/stack/Stack017.java

@@ -0,0 +1,141 @@
+/*
+ * Copyright (c) 2000, 2024, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @key stress
+ *
+ * @summary converted from VM testbase nsk/stress/stack/stack017.
+ * VM testbase keywords: [stress, diehard, stack, nonconcurrent]
+ * VM testbase readme:
+ * DESCRIPTION
+ *     The test invokes infinitely recursive method from within stack
+ *     overflow handler  -- repeatedly multiple times, and in multiple
+ *     threads.
+ *     The test is deemed passed, if VM have not crashed, and
+ *     if exception other than due to stack overflow was not
+ *     thrown.
+ * COMMENTS
+ *     This test crashes HS versions 2.0, 1.3, and 1.4 on both
+ *     Solaris and Win32 platforms.
+ *     See the bug:
+ *     4366625 (P4/S4) multiple stack overflow causes HS crash
+ *
+ * @requires (vm.opt.DeoptimizeALot != true & vm.compMode != "Xcomp" & vm.pageSize == 4096)
+ * @run main/othervm/timeout=900 -Xss220K Stack017
+ */
+
+public class Stack017 extends Thread {
+    private final static int THREADS = 10;
+    private final static int CYCLES = 10;
+    private final static int PROBES = 100;
+
+    public static void main(String[] args) {
+        Stack017 test = new Stack017();
+        test.doRun();
+    }
+
+    private static int depthToTry;
+
+    private void doRun() {
+        //
+        // Measure recursive depth before stack overflow:
+        //
+        try {
+            recurse(0);
+        } catch (StackOverflowError | OutOfMemoryError err) {
+        }
+        System.out.println("Maximal recursion depth: " + maxDepth);
+        depthToTry = maxDepth;
+
+        //
+        // Run the tested threads:
+        //
+        Stack017 threads[] = new Stack017[THREADS];
+        for (int i = 0; i < threads.length; i++) {
+            threads[i] = new Stack017();
+            threads[i].setName("Thread: " + (i + 1) + "/" + THREADS);
+            threads[i].start();
+        }
+        for (int i = 0; i < threads.length; i++) {
+            if (threads[i].isAlive()) {
+                try {
+                    threads[i].join();
+                } catch (InterruptedException exception) {
+                    throw new RuntimeException(exception);
+                }
+            }
+        }
+        //
+        // Check if unexpected exceptions were thrown:
+        //
+        for (int i = 0; i < threads.length; i++) {
+            if (threads[i].thrown != null) {
+                threads[i].thrown.printStackTrace();
+                throw new RuntimeException("Exception in the thread " + threads[i], threads[i].thrown);
+            }
+        }
+    }
+
+    private int maxDepth = 0;
+
+    private void recurse(int depth) {
+        maxDepth = depth;
+        recurse(depth + 1);
+    }
+
+    private void trickyRecurse(int depth) {
+        try {
+            maxDepth = depth;
+            trickyRecurse(depth + 1);
+        } catch (StackOverflowError | OutOfMemoryError error) {
+            //
+            // Stack problem caught: provoke it again,
+            // if current stack is enough deep:
+            //
+            if (depth < depthToTry - PROBES)
+                throw error;
+            recurse(depth + 1);
+        }
+    }
+
+    private Throwable thrown = null;
+
+    public void run() {
+        String threadName = Thread.currentThread().getName();
+        for (int i = 1; i <= CYCLES; i++)
+            try {
+                System.out.println(threadName + ", iteration: " + i + "/" + CYCLES);
+                trickyRecurse(0);
+                throw new Exception(
+                        "TEST_BUG: stack overflow was expected!");
+
+            } catch (StackOverflowError | OutOfMemoryError err) {
+                // It's OK
+            } catch (Throwable throwable) {
+                // It isn't OK!
+                thrown = throwable;
+                break;
+            }
+    }
+}