undefect. CWE-407 — 63 sites patched across 27 ecosystems

Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com

Patches, unit tests, benchmarks, whitepaper, and outreach briefs.
Public domain — no copyright claimed. Use freely.

test/hotspot/jtreg/compiler/vectorization/TestSignumVector.java

@@ -0,0 +1,116 @@
+/*
+ * Copyright (c) 2022, 2024, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/**
+ * @test
+ * @bug 8282711 8290249
+ * @summary Accelerate Math.signum function for AVX, AVX512, aarch64 (Neon and SVE)
+ *          and riscv64 (vector)
+ * @requires vm.compiler2.enabled
+ * @requires (os.simpleArch == "x64" & vm.cpu.features ~= ".*avx.*") | os.arch == "aarch64" |
+ *           (os.arch == "riscv64" & vm.cpu.features ~= ".*rvv.*")
+ * @library /test/lib /
+ * @run driver compiler.vectorization.TestSignumVector
+ */
+
+package compiler.vectorization;
+
+import java.util.Random;
+
+import compiler.lib.ir_framework.*;
+
+public class TestSignumVector {
+  private static final int ARRLEN = 1024;
+  private static final int ITERS  = 11000;
+
+  private static double [] dinp;
+  private static double [] dout;
+  private static float  [] finp;
+  private static float  [] fout;
+
+  public static void main(String args[]) {
+      TestFramework.runWithFlags("-XX:-TieredCompilation", "-XX:+UnlockDiagnosticVMOptions",
+                                 "-XX:+UseSignumIntrinsic", "-XX:CompileThresholdScaling=0.3");
+      System.out.println("PASSED");
+  }
+
+  @Test
+  @IR(counts = {IRNode.SIGNUM_VD, "> 0"})
+  public void test_signum_double(double[] dout, double[] dinp) {
+      for (int i = 0; i < dout.length; i+=1) {
+          dout[i] = Math.signum(dinp[i]);
+      }
+  }
+
+  @Run(test = {"test_signum_double"}, mode = RunMode.STANDALONE)
+  public void kernel_test_signum_double() {
+      dinp = new double[ARRLEN];
+      dout = new double[ARRLEN];
+      Random rnd = new Random(20);
+      for(int i = 0 ; i < ARRLEN; i++) {
+          dinp[i] = (i-ARRLEN/2)*rnd.nextDouble();
+      }
+      for (int i = 0; i < ITERS; i++) {
+          test_signum_double(dout , dinp);
+      }
+      for(int i = 0 ; i < ARRLEN; i++) {
+        if (i-ARRLEN/2<0) {
+            if (dout[i] != -1.0)  throw new RuntimeException("Expected negative numbers in first half of array: " + java.util.Arrays.toString(dout));
+        } else if (i-ARRLEN/2==0) {
+            if (dout[i] != 0)     throw new RuntimeException("Expected zero in the middle of array: " + java.util.Arrays.toString(dout));
+        } else {
+            if (dout[i] != 1.0)   throw new RuntimeException("Expected positive numbers in second half of array: " + java.util.Arrays.toString(dout));
+        }
+    }
+  }
+
+  @Test
+  @IR(counts = {IRNode.SIGNUM_VF, "> 0"})
+  public void test_signum_float(float[] fout, float[] finp) {
+      for (int i = 0; i < finp.length; i+=1) {
+          fout[i] = Math.signum(finp[i]);
+      }
+  }
+
+  @Run(test = {"test_signum_float"}, mode = RunMode.STANDALONE)
+  public void kernel_test_round() {
+      finp = new float[ARRLEN];
+      fout = new float[ARRLEN];
+      Random rnd = new Random(20);
+      for(int i = 0 ; i < ARRLEN; i++) {
+          finp[i] = (i-ARRLEN/2)*rnd.nextFloat();
+      }
+      for (int i = 0; i < ITERS; i++) {
+          test_signum_float(fout , finp);
+      }
+      for(int i = 0 ; i < ARRLEN; i++) {
+        if (i-ARRLEN/2<0) {
+            if (fout[i] != -1.0)  throw new RuntimeException("Expected negative numbers in first half of array: " + java.util.Arrays.toString(fout));
+        } else if (i-ARRLEN/2==0) {
+            if (fout[i] != 0)     throw new RuntimeException("Expected zero in the middle of array: " + java.util.Arrays.toString(fout));
+        } else {
+            if (fout[i] != 1.0)   throw new RuntimeException("Expected positive numbers in second half of array: " + java.util.Arrays.toString(fout));
+        }
+    }
+  }
+}