undefect. CWE-407 — 63 sites patched across 27 ecosystems

Authors: russell@unturf.com · brackishbert@gmail.com · foxhop.net · TimeHexOn.com

Patches, unit tests, benchmarks, whitepaper, and outreach briefs.
Public domain — no copyright claimed. Use freely.

make/langtools/tools/javacserver/client/ClientConfiguration.java

@@ -0,0 +1,131 @@
+/*
+ * Copyright (c) 2014, 2022, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.  Oracle designates this
+ * particular file as subject to the "Classpath" exception as provided
+ * by Oracle in the LICENSE file that accompanied this code.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+package javacserver.client;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Arrays;
+import java.util.List;
+import javacserver.shared.PortFile;
+import javacserver.util.Log;
+
+/**
+ * Description of the arguments needed to start a javacserver client, as extracted from
+ * the command line and configuration file.
+ */
+public record ClientConfiguration(PortFile portFile, String javaCommand, String[] javacArgs) {
+    static ClientConfiguration fromCommandLineArguments(String... args) {
+        String confFileName = getConfFileName(args);
+        if (confFileName == null) {
+            return null;
+        }
+
+        String confFileContent = getConfFileContent(confFileName);
+        if (confFileContent == null) {
+            return null;
+        }
+
+        String portFileName = getPortFileName(confFileContent);
+        if (portFileName == null) {
+            return null;
+        }
+        String javaCommand = getJavaCommandString(confFileContent);
+        if (javaCommand == null) {
+            return null;
+        }
+
+        PortFile portFile = new PortFile(portFileName);
+        String[] javacArgs = Arrays.copyOfRange(args, 1, args.length);
+
+        ClientConfiguration conf = new ClientConfiguration(portFile, javaCommand, javacArgs);
+        return conf;
+    }
+
+    private static String getConfFileName(String[] args) {
+        if (args.length < 1) {
+            Log.error("Error: javacserver client: missing --conf=<conf file> argument");
+            return null;
+        }
+        String[] conf = args[0].split("=", 2);
+        if (conf.length != 2 || !conf[0].equalsIgnoreCase("--conf")) {
+            Log.error("Error: javacserver client: first argument must be --conf=<conf file>");
+            return null;
+        }
+        String confFileName = conf[1];
+        if (!Files.exists(Path.of(confFileName))) {
+            Log.error("Error: javacserver client: specified conf file does not exist");
+            return null;
+        }
+        return confFileName;
+    }
+
+    private static String getConfFileContent(String confFile) {
+        try {
+            List<String> confFileLines = Files.readAllLines(Path.of(confFile));
+            String confFileContent = String.join("\n", confFileLines);
+            return confFileContent;
+        } catch (IOException e) {
+            Log.error("Cannot read configuration file " + confFile);
+            Log.debug(e);
+            return null;
+        }
+    }
+
+    private static String getJavaCommandString(String confFileContent) {
+        String serverCommandString = getConfValue("javacmd", confFileContent);
+        if (serverCommandString.isEmpty()) {
+            Log.error("Configuration file missing value for 'javacmd'");
+            return null;
+        } else {
+            return serverCommandString;
+        }
+    }
+
+    private static String getPortFileName(String confFileContent) {
+        String portfileName = getConfValue("portfile", confFileContent);
+        if (portfileName.isEmpty()) {
+            Log.error("Configuration file missing value for 'portfile'");
+            return null;
+        } else {
+            return portfileName;
+        }
+    }
+
+    private static String getConfValue(String optionName, String content) {
+        String result;
+        int p = content.indexOf(optionName + "=");
+        if (p == -1) {
+            result = "";
+        } else {
+            p += optionName.length() + 1;
+            int pe = content.indexOf('\n', p);
+            if (pe == -1) pe = content.length();
+            result = content.substring(p, pe);
+        }
+        return result.strip();
+    }
+}