arborist/tests
russell@unturf.com 439319f960
qa: question_hash strips articles + verifier coverage drops stopwords
Two related changes that tighten the dedup + grounding signals
without lowering quality bars.

1. question_hash drops standalone English articles (the/a/an).

   Fox 2026-04-29: `who is the batman?` and `who is batman?`
   produced different cache records; same question, different hash.
   Articles are filler at the question-equivalence layer. Add a 4th
   canonicalization step to question_hash: after lowercase + trailing
   punctuation strip, split on whitespace & drop tokens equal to
   "the" / "a" / "an", then rejoin.

   Equivalence class now includes:
       "who is X"      ┐
       "who is the X"  │
       "who is a X"    │ -> same question_hash
       "who is an X"   │
       "Who Is X?"    ┘  (CJK question mark)

   "thesis" stays untouched — exact-match standalone tokens only,
   not substring. Conservative on i18n: ASCII English articles only;
   "el / la / le / der / die / das" etc. await demand.

2. _token_coverage filters stopwords and per-token punctuation.

   Fox asked: should we lower the 0.85 paraphrase threshold? Honest
   answer: no — that would promote the Q1 Batman fabrication
   ("wealthy/businessman/resides" missing from corpus) to STRICT.
   Tighten the signal instead so 0.85 means more.

   - Per-token punctuation strip (.,;:!?\"()[]{}) so `wayne,` lines
     up with bare `wayne` in context. Apostrophes deliberately stay
     so `batman's` is distinct from `batman`.
   - English stopword filter on length-≥4 fillers (from / with /
     have / been / would / which / where / their / etc., curated set
     in _ENGLISH_STOPWORDS). These match almost any English text &
     inflate coverage scores when topical content is missing.

   Net effect on Q1 Batman case: missing tokens are
   `wealthy/businessman/resides` — all topical. Coverage stays well
   below 0.85, span stays UNGROUNDED. Net effect on a stylistic
   paraphrase (model wrote `from` instead of `with`): coverage
   computed only over topical tokens, both copies match → 1.0 →
   correctly promoted.

Tests: 8 new in tests/test_keys.py (article-strip equivalence
classes, substring preservation, distinct-topic non-collapse) +
2 in tests/test_verify.py (stopword filter doesn't inflate; 0.85
threshold still rejects fabrication). 335 passed, 1 skipped.

Note for fox: the underlying retrieval issue surfaced in Q1/Q2 is
independent — Batman main article IS in shard 002.db but FTS5 +
title rerank ranked List_of_Batman_comics higher. Different fix,
separate commit.
2026-04-29 14:00:44 -04:00
..
crawler crawler: skip feeds + sitemaps at ingest (they're discovery, not knowledge) 2026-04-29 05:55:28 -04:00
fixtures verify: strip wikitext from context before substring matching 2026-04-28 15:48:07 -04:00
__init__.py phase 0 explore: aborist core + sources + distill + evict 2026-04-27 07:53:18 -04:00
test_burn.py cli: 'aborist burn' — kindergarten leaf delete with audit event 2026-04-28 17:03:30 -04:00
test_burn_doc.py cli: extend 'aborist burn' to documents and cores 2026-04-28 17:32:40 -04:00
test_cli_render.py cli: human render for query by default; --json for raw; ensure_ascii=False 2026-04-29 10:14:36 -04:00
test_compress.py storage cheats + TF-IDF retrieval fix 2026-04-27 17:24:51 -04:00
test_concepts.py concept overlay: synonym expansion + rivalry exclusion 2026-04-27 12:34:00 -04:00
test_distill.py phase 0 explore: aborist core + sources + distill + evict 2026-04-27 07:53:18 -04:00
test_distill_recursive.py recursive distillation: core -> depth+1 core 2026-04-27 07:54:30 -04:00
test_evict.py phase 0 explore: aborist core + sources + distill + evict 2026-04-27 07:53:18 -04:00
test_grok_source.py add Grok export source: conversations + media posts 2026-04-27 13:49:42 -04:00
test_html_source.py phase 0 explore: aborist core + sources + distill + evict 2026-04-27 07:53:18 -04:00
test_ingest.py verify: layered strategies + entity policies, rename VISUAL → UNGROUNDED 2026-04-28 16:58:31 -04:00
test_inspect.py qa: 'aborist inspect' — sidecar diagnose for unverified spans 2026-04-29 10:29:06 -04:00
test_keys.py qa: question_hash strips articles + verifier coverage drops stopwords 2026-04-29 14:00:44 -04:00
test_llm_context_base.py qa: pipe wikitext-base-v1 into LLM context (was verifier-only) 2026-04-28 17:08:49 -04:00
test_merkle.py phase 0 explore: aborist core + sources + distill + evict 2026-04-27 07:53:18 -04:00
test_mesh.py mesh: cryptographic foundation, off by default 2026-04-27 19:00:24 -04:00
test_mesh_aead.py mesh: optional AEAD body encryption under per-epoch shared secret 2026-04-28 17:34:39 -04:00
test_mesh_chain.py mesh: per-peer audit chain-of-claims tracking on the wire 2026-04-28 19:41:25 -04:00
test_mesh_cli.py mesh: 'serve' and 'sync' CLI verbs over the wire layer 2026-04-28 17:05:31 -04:00
test_mesh_cli_pull.py mesh: 'pull' CLI verb — fetch document body from a peer 2026-04-28 17:33:27 -04:00
test_mesh_wire.py mesh: HTTP gossip wire — signed envelopes + 5 message types 2026-04-28 16:57:04 -04:00
test_mesh_wire_e2e.py mesh: HTTP gossip wire — signed envelopes + 5 message types 2026-04-28 16:57:04 -04:00
test_migration_audit_mode.py verify: layered strategies + entity policies, rename VISUAL → UNGROUNDED 2026-04-28 16:58:31 -04:00
test_qa.py qa: post-LLM faithfulness verifier sets STRICT/HYBRID/VISUAL audit_mode 2026-04-28 15:45:08 -04:00
test_query.py qa: post-LLM faithfulness verifier sets STRICT/HYBRID/VISUAL audit_mode 2026-04-28 15:45:08 -04:00
test_reclassify.py verify: layered strategies + entity policies, rename VISUAL → UNGROUNDED 2026-04-28 16:58:31 -04:00
test_resume.py resumable ingest + per-shard audit chain integrity 2026-04-27 11:29:27 -04:00
test_snapshot.py add corpus-level snapshots: single-hash identity for the forest 2026-04-27 21:29:10 -04:00
test_tfidf.py add TF-IDF keyword distiller 2026-04-27 07:55:53 -04:00
test_vcs_source.py add git and mercurial repo sources for self-play 2026-04-27 18:17:39 -04:00
test_verify.py qa: question_hash strips articles + verifier coverage drops stopwords 2026-04-29 14:00:44 -04:00
test_versioned_ingest.py storage cheats + TF-IDF retrieval fix 2026-04-27 17:24:51 -04:00
test_wikipedia_old.py prepare full Wikipedia 2003-05-16 ingest: cur + old (revisions) 2026-04-27 08:10:42 -04:00
test_wikipedia_xml.py add Phase IV Wikipedia XML + abstract sources 2026-04-27 17:24:28 -04:00
test_wikitext.py verify: layered strategies + entity policies, rename VISUAL → UNGROUNDED 2026-04-28 16:58:31 -04:00